This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#7021).
Commits
-------
c9c1ce6 [HttpKernel] exception listener, allow easier overloading of the default behavior
Discussion
----------
[HttpKernel] exception listener, allow easier overloading of the default behavior
Hi Fabien,
This commit you wrote about a month ago helped me to overload the 'logException' method:
1a6c9b3143
Because the logger property was private I could not access it from the subclass. This PR changes both properties: controller and logger from private to public members. So they can be used from 'logException'.
This PR was merged into the 2.2 branch.
Commits
-------
30b0c37 [Router] Fix TraceableUrlMatcher
Discussion
----------
[BugFix][Router] Fix TraceableUrlMatcher
TraceableUrlMatcher does not take care with new host route features
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #6744
| License | MIT
| Doc PR | n/a
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#7014).
Commits
-------
d043cb4 Fix style for abbr elements in toolbar
Discussion
----------
[WDT] Fix style for abbr elements in toolbar
Styling for `abbr` elements (e.g. dotted underline) weren't being applied unless you were viewing a profile.
This PR was merged into the 2.2 branch.
Commits
-------
5a2caa5 [HttpKernel] fixed the hinclude fragment renderer when the template is empty
Discussion
----------
[HttpKernel] fixed the hinclude fragment renderer when the template is empty
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
---------------------------------------------------------------------------
by lsmith77 at 2013-02-07T13:36:58Z
does it make sense to allow the template to be empty? i mean isnt this instead an error condition?
---------------------------------------------------------------------------
by fabpot at 2013-02-07T16:16:04Z
Why not? An empty template means and empty content, which you might want as this is just the fallback content displayed when the real content is not loaded yet.
This PR was merged into the 2.2 branch.
Commits
-------
bc4a0e7 [HttpFoundation] fixed Request::create() method
Discussion
----------
[HttpFoundation] fixed Request::create() method
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
When creating a Request with Request::create(), some information can
come from the URI and the server variable. Until now, it was not clear
which information had precedence over the other and as a matter of fact,
this method was not consistent.
Now, information contained in the URI always take precedence over
information coming from the server array. That makes sense as the server
array is often copied from another existing Request object.
---------------------------------------------------------------------------
by vicb at 2013-02-07T14:42:15Z
You should add a note in the changelog
When creating a Request with Request::create(), some information can
come from the URI and the server variable. Until now, it was not clear
which information had precedence over the other and as a matter of fact,
this method was not consistent.
Now, information contained in the URI always take precedence over
information coming from the server array. That makes sense as the server
array is often copied from another existing Request object.
This PR was merged into the 2.2 branch.
Commits
-------
3053194 [DependencyInjection] enhanced some error messages
Discussion
----------
[DependencyInjection] enhanced some error messages
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
* 2.1:
[HttpKernel] fixed the creation of the Profiler directory
[Security] fixed session creation when none is needed (closes#6917)
[FrameworkBundle] removed obsolete comment (see 2e356c1)
This PR was merged into the 2.2 branch.
Commits
-------
badb2b9 Add "'property_path' => false" deprecation message for forms
Discussion
----------
Add "'property_path' => false" deprecation message for forms
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#6808).
Commits
-------
0cb74a2 Added BCrypt password encoder.
Discussion
----------
Bcrypt password encoder
Bug fix: no
Feature addition: yes
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #5932
License of the code: MIT
Documentation PR: symfony/symfony-docs#1936
---------------------------------------------------------------------------
by TerjeBr at 2013-01-19T18:53:21Z
Finishing PR #5974
---------------------------------------------------------------------------
by jalliot at 2013-01-20T14:07:54Z
This looks very good! :)
But be careful to CS or this will not be merged.
---------------------------------------------------------------------------
by TerjeBr at 2013-01-20T14:17:35Z
I do not understand. What do you mean by "CS"?
---------------------------------------------------------------------------
by jalliot at 2013-01-20T14:20:33Z
[Coding standards](http://symfony.com/doc/current/contributing/code/standards.html).
You should run [PHP-CS-Fixer](https://github.com/fabpot/PHP-CS-Fixer) on your code to fix it.
---------------------------------------------------------------------------
by TerjeBr at 2013-01-20T14:47:23Z
The only thing php-cs-fixer.phar did was to realign some of the doc-block comments.
But thank you any way for pointing out the script to me.
---------------------------------------------------------------------------
by TerjeBr at 2013-01-20T15:52:07Z
Why does it look like @elnur added the commits? It was me.
---------------------------------------------------------------------------
by stof at 2013-01-20T16:32:12Z
@TerjeBr check your git configuration to be sure it uses your email address when committing
---------------------------------------------------------------------------
by TerjeBr at 2013-01-20T17:30:58Z
Now the commit is in my name.
But see what happens if I squash the commit wit git rebase ....
---------------------------------------------------------------------------
by TerjeBr at 2013-01-20T17:33:08Z
Now it looks like elnur added the commit.
---------------------------------------------------------------------------
by stof at 2013-01-26T15:57:59Z
@fabpot is there a chance to have this in 2.2 ?
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#6885).
Commits
-------
c5d15f8 [PropertyAccess] Removed underscores from test method names to be consistent with other components.
Discussion
----------
[PropertyAccess] Removed underscores from test method names
Removed underscores from test method names to be consistent with other components.
This was previously done in #6695, but was partly lost when merging with master (PropertyAccess component was created, so the location of tests has changed).
| Q | A |
|--------------|--------------------------------|
| Bug fix? | no |
|New feature? | no |
|BC breaks? | no |
|Deprecations? | no |
|Tests pass? | yes |
|Fixed tickets | n/a |
|License | MIT |
|Doc PR | n/a |
It is more common to use fully camel-cased names for test methods. Only some of the test methods are called with underscore notation. To avoid confusion it is better to be consistent.
This PR was merged into the 2.2 branch.
Commits
-------
35b62ac [Security] renamed Constraint namespace to Constraints for validator classes in order to be consistent with the whole current validator API.
Discussion
----------
[Security] renamed Constraint namespace to Constraints for validator classes in order to be consistent with the whole current validator API.
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | yes (for people already using the ``UserPassword`` constraint class in their code)
| Deprecations? | yes
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
This PR was merged into the 2.1 branch.
Commits
-------
8ca00c5 [Security] fixed session creation when none is needed (closes#6917)
Discussion
----------
[Security] fixed session creation when none is needed (closes#6917)
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #6917
| License | MIT
| Doc PR | n/a
---------------------------------------------------------------------------
by drak at 2013-02-04T16:24:49Z
That looks good. Maybe we need a test for this logic to prevent any regression in the future?
---------------------------------------------------------------------------
by bendavies at 2013-02-04T16:30:38Z
Yep, this was exactly what i tried locally, but really wasn't familiar enough with it to be confident enough to submit it as a fix.
Works for me!
---------------------------------------------------------------------------
by bendavies at 2013-02-04T17:19:32Z
A few test failures which were added by the breaking PR #2414 in the first place.
---------------------------------------------------------------------------
by fabpot at 2013-02-04T18:00:31Z
I've fixed the tests which now really test that the session is not started.
