This PR was merged into the 2.3 branch.
Discussion
----------
Prevent WDT from creating a session
The wdt should not create a session.
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: N/A
Todo: -
License of the code: MIT
Documentation PR: N/A
Commits
-------
4791351 Prevent WDT from creating a session
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes#10006).
Discussion
----------
Fixed coding standards (PSR-2)
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | ---
| Fixed tickets | ---
| License | MIT
| Doc PR | ---
> static MUST be declared after the visibility
-- (PSR-2)
Commits
-------
2fbc833 Coding standards
This PR was squashed before being merged into the 2.3 branch (closes#10000).
Discussion
----------
[Console] Fixed the compatibility with HHVM
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR | -
The only failures in the Console testsuite were due to facebook/hhvm#1327, and a workaround for this issue is easy.
This PR currently includes #9999 in it, to have a working HHVM build on Travis.
Commits
-------
ac1ba81 [Console] Fixed the compatibility with HHVM
This PR was squashed before being merged into the 2.3 branch (closes#9999).
Discussion
----------
Fixed the Travis setup for HHVM
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR | -
this replaces #9997 with a proper fix: fixing the cause of the issue instead of adding workarounds for it
"php -r" does not seem to behave properly in HHVM, so the check to detect HHVM has been switch to a check on the environment variable set by Travis.
Commits
-------
67d4959 Fixed the Travis setup for HHVM
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes#9991).
Discussion
----------
Fix for a couple of undefined classes in docblocks
These are the 2 that I've come across, but there may be some more.
Commits
-------
3918d6d Fix for a couple of undefined classes in docblocks
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes#9979).
Discussion
----------
[Doctrine Bridge][Validator] Fix for null values in assosiated properties when using UniqueEntityValidator
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #7382
| License | MIT
| Doc PR |
This fixes issue with UniqueEntityValidator when ignoreNull = false and associated property contains null value:
```
Warning: ReflectionProperty::getValue() expects parameter 1 to be object, null given in [...]/symfony2/vendor/doctrine/orm/lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php line 670
```
Here's what docs say about ignoreNull:
> If this option is set to true, then the constraint will allow multiple entities to have a null value for a field without failing validation. If set to false, only one null value is allowed - if a second entity also has a null value, validation would fail.
Commits
-------
bf368bc [Doctrine Bridge][Validator] Fix for null values in assosiated properties when using UniqueEntityValidator
This PR was merged into the 2.3 branch.
Discussion
----------
[TwigBridge] Update min. version of Twig
| Q | A
| ------------- | ---
| Bug fix? | kinda
| New feature? | no
| BC breaks? | no
| Tests pass? | yes
| License | MIT
The minimal version of Twig must be 1.12 because of usage the method `Twig_SimpleFunction` that was added in that version.
Commits
-------
c003291 [TwigBridge] Update min. version of Twig
This PR was merged into the 2.3 branch.
Discussion
----------
[CssSelector] fixed numeric attribute issue
This PR adds a cast from number to string when parsing a numeric attribute value.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #9968
Commits
-------
613535a [CssSelector] fixed numeric attribute issue
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes#9747).
Discussion
----------
[DoctrineBridge] Fix: Add type detection. Needed by pdo_dblib
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Commits
-------
75f5cc3 Add type detection. Needed by pdo_dblib
This PR was merged into the 2.3 branch.
Discussion
----------
[All] update license year to 2014
| Q | A |
| --- | --- |
| Bug fix? | n |
| New feature? | n |
| BC breaks? | n |
| Deprecations? | n |
| Tests pass? | y |
| Fixed tickets | na |
| License | MIT |
| Doc PR | na |
Sent using [Gush](https://github.com/cordoval/gush)
sorry about the previous PR now closed, forgot Gush had branched off of master and not 2.3
Commits
-------
8ace5f9 update year on licenses
This PR was merged into the 2.3 branch.
Discussion
----------
[Validator] rundown with some typo fixes and consistency
| Q | A |
| --- | --- |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | na |
| License | MIT |
| Doc PR | na |
Sent using [Gush](https://github.com/cordoval/gush)
Commits
-------
dcd23df rundown and typo fix
This PR was merged into the 2.3 branch.
Discussion
----------
[Process] Fix#9861 : Revert TTY mode
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #9861
| License | MIT
This revert the TTY mode support for the process component
Commits
-------
160b1cf [Process] Fix#9861 : Revert TTY mode
This PR was merged into the 2.3 branch.
Discussion
----------
[Form] Update minimal requirement in composer.json
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Tests pass? | yes
| Fixed tickets | #9959
| License | MIT
Minimal requirement for PropertyAccess component needs to be `~2.3` as Form component depends on new method `PropertyAccess::createPropertyAccessor()`.
Commits
-------
88153b3 [Form] Update minimal requirement in composer.json
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes#9952).
Discussion
----------
[Translator] Fix Empty translations with Qt files
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | n/a
| Fixed tickets | no
| License | MIT
| Doc PR |
When you use ts files, QtLinguist, generate empty string for all translations, even if there are not translated yet.
It could be a good idea to generate an entry in the MessageCatalogue only if translation value is not empty.
Commits
-------
1c220be [Translator] Fix Empty translations with Qt files
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes#9804).
Discussion
----------
[Form] Update UPGRADE-2.3.md to account for #9388
Added documentation for how to correctly pre-fill a form using the form's `data` option.
The "old" and also wrong way of doing it broke with Symfony 2.3.7 (with https://github.com/symfony/symfony/pull/9388 to be precise) and this short documentation should help others to fix the problem and do it right.
Commits
-------
5e06535 [Form] Update UPGRADE-2.3.md to account for #9388
This PR was squashed before being merged into the 2.3 branch (closes#9948).
Discussion
----------
[WebProfilerBundle] Fixed profiler toolbar icons for XHTML.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | n/a
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
Profiler page itself is entirely autonomic, but toolbar is not - unfortunately currently it doesn't work in XHTML documents :(.
#9877 backported to `2.3` branch.
Commits
-------
296c4d1 [WebProfilerBundle] Fixed profiler toolbar icons for XHTML.
This PR was merged into the 2.3 branch.
Discussion
----------
Propel1 exception message
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #9932
| License | MIT
| Doc PR | none
This add exception message for `ModelChoiceList` and `ModelType` when `class` parameter is not provided or invalid
Commits
-------
047492f [Propel1Bridge][ModelChoiceList] add exception message for invalid classes
This PR was squashed before being merged into the 2.3 branch (closes#9949).
Discussion
----------
[BrowserKit] Throw exception on invalid cookie expiration timestamp
Currently, if an invalid timestamp is provided, a fatal error with no stack trace will occur, making it difficult to trace the problem.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Commits
-------
8df535d [BrowserKit] Throw exception on invalid cookie expiration timestamp
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes#9938).
Discussion
----------
[Process] Add support SAPI cli-server
As of PHP 5.4.0, the CLI SAPI provides a built-in web server.
```php
PHP_SAPI == 'cli-server'
```
PHP can be used portable without installation on PC. For example, the [assembly](http://windows.php.net/download/) does not require installation in the system on Windows. In this case `PHP_BINARY` contains the path to the PHP executor, and all the other search methods will not return result.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Commits
-------
92d8323 Add support SAPI cli-server
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes#9940).
Discussion
----------
[EventDispatcher] Fix hardcoded listenerTag name in error message
| Q | A
| ------------- | ---
| Fixed tickets | N/A
| License | MIT
Just as the title say, there was a kernel.event_listener string hardcoded in an error message although everywhere else in this class it is stored in the `$listenerTag` property.
Commits
-------
8c91537 [EventDispatcher] Fix hardcoded listenerTag name in error message
This PR was merged into the 2.3 branch.
Discussion
----------
[HttpFoundation] Documented public properties
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #9670
| License | MIT
| Doc PR | -
`$request` and `$query` parameter bags could be hard to get for a newcommer, who's used to `$_POST` and `$_GET` variables. Some people claim naming makes no sense (see #9671).
For consistency I documented all public properties.
Commits
-------
1b79831 [HttpFoundation] Documented public properties.
This PR was squashed before being merged into the 2.3 branch (closes#9925).
Discussion
----------
[Routing] add missing unit tests for Route and RouteCollection classes
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | none
| License | MIT
| Doc PR | none
Just add few unit tests in Route and RouteCollection classes to have a full coverage.
Commits
-------
7bbd568 [Routing] add missing unit tests for Route and RouteCollection classes
