Commit Graph

36735 Commits

Author SHA1 Message Date
Eno Mullaraj
5cac9ad97d [Validator] improve translations for albanian ("sq") locale
* improve overall translation message consistency
* fix singular expression messages
* fix grammatical errors
* use albanian form of expression
* restore as lexical gap the "locale" translation
2019-02-17 14:05:03 +01:00
Nicolas Grekas
ce7afc222d bug #30274 [VarDumper] fix serializing Stub instances (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

[VarDumper] fix serializing Stub instances

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

There are more properties in child classes, and we can skip serializing properties that are set to their default values.

Commits
-------

46d6a4d9ec [VarDumper] fix serializing Stub instances
2019-02-17 10:38:12 +01:00
Nicolas Grekas
46d6a4d9ec [VarDumper] fix serializing Stub instances 2019-02-16 23:55:29 +01:00
Nicolas Grekas
eb3299341f bug #30247 Don't resolve the Deprecation error handler mode until a deprecation is triggered (ossinkine)
This PR was merged into the 3.4 branch.

Discussion
----------

Don't resolve the Deprecation error handler mode until a deprecation is triggered

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #30047
| License       | MIT

<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->
If an error happens before `.env.test` is loaded the mode is set to 0 and cached so SYMFONY_DEPRECATIONS_HELPER is not read from `.env.test`.

Commits
-------

1090b8cb6e Don't resolve the Deprecation error handler mode until a deprecation is triggered
2019-02-16 19:51:27 +01:00
Gocha Ossinkine
1090b8cb6e Don't resolve the Deprecation error handler mode until a deprecation is triggered 2019-02-16 19:50:26 +01:00
Nicolas Grekas
dee2fcb50d bug #30264 [Debug][ErrorHandler] Preserve next error handler (fancyweb)
This PR was merged into the 3.4 branch.

Discussion
----------

[Debug][ErrorHandler] Preserve next error handler

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | https://github.com/symfony/symfony/issues/30140
| License       | MIT
| Doc PR        | -

Thank you @cuchac

Getting the current error handler in the error handler itself actually works. If you try to see the content of the `$currentErrorHandler` var however, you will always see `null`. That's why I thought it was impossible. Because I did not test from end to end until today.

Commits
-------

a8b34348e7 [Debug][ErrorHandler] Preserve next error handler
2019-02-16 18:23:37 +01:00
Fabien Potencier
da325fc0e2 bug #30245 fix lost namespace in eval (fizzka)
This PR was squashed before being merged into the 4.2 branch (closes #30245).

Discussion
----------

fix lost namespace in eval

Bugfix:
phpunit8 tearDown() declaration

Commits
-------

8743a1ada8 fix lost namespace in eval
2019-02-16 18:13:04 +01:00
Fabien Potencier
5a154538c7 minor #30233 [Twig] removed usage of non-namespaced classes (fabpot)
This PR was merged into the 3.4 branch.

Discussion
----------

[Twig] removed usage of non-namespaced classes

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

Commits
-------

bd719cd7e1 [Twig] removed usage of non-namespaced classes
2019-02-16 12:52:47 +01:00
Fabien Potencier
bd719cd7e1 [Twig] removed usage of non-namespaced classes 2019-02-16 12:50:39 +01:00
Fabien Potencier
85c448e915 added missing dot 2019-02-16 12:46:43 +01:00
Fabien Potencier
de1f4c482b minor #30242 Update validators.lt.xlf (jlemesh)
This PR was squashed before being merged into the 3.4 branch (closes #30242).

Discussion
----------

Update validators.lt.xlf

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #30173
| License       | MIT

Commits
-------

f9772359b3 Update validators.lt.xlf
2019-02-16 12:46:20 +01:00
JL
f9772359b3 Update validators.lt.xlf 2019-02-16 12:46:14 +01:00
Fabien Potencier
8364fe42ca minor #30251 #30172 Add the missing validation translations for the Luxembourgish … (Evrard Boulou)
This PR was squashed before being merged into the 3.4 branch (closes #30251).

Discussion
----------

#30172 Add the missing validation translations for the Luxembourgish …

…locale

| Q             | A
| ------------- | ---
| Branch?       | master for features / 3.4 up to 4.2 for bug fixes <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #30172  <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

Add the missing validation translations for the Luxembourgish locale

Commits
-------

b0be36648f #30172 Add the missing validation translations for the Luxembourgish …
2019-02-16 12:43:59 +01:00
Evrard Boulou
b0be36648f #30172 Add the missing validation translations for the Luxembourgish … 2019-02-16 12:43:53 +01:00
Thomas Calvet
a8b34348e7 [Debug][ErrorHandler] Preserve next error handler
Co-authored-by: Joe <cuchac@email.cz>
2019-02-16 11:38:56 +01:00
Christian Flothmann
823ccf086d minor #30262 [TwigBridge] fix tests by adapting Twig namespace changes (xabbuh)
This PR was merged into the 3.4 branch.

Discussion
----------

[TwigBridge] fix tests by adapting Twig namespace changes

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

bbc2656619 fix tests by adapting Twig namespace changes
2019-02-15 19:54:00 +01:00
Christian Flothmann
bbc2656619 fix tests by adapting Twig namespace changes 2019-02-15 18:05:19 +01:00
Christian Flothmann
37b0eeb007 minor #30241 allow to skip tests based on the supported version (xabbuh)
This PR was merged into the 3.4 branch.

Discussion
----------

allow to skip tests based on the supported version

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Writing tests for Form related features in the Doctrine and Twig bridges
as well as the FrameworkBundle is a pain as soon as these tests are run
with more recent versions of the Form component. This is due to the fact
that our tests in the bridges and bundle extend test cases from the
component. The tests in the component are expanded with every feature
that gets added there. However, these new features are not present in
the other packages in older version and we thus need to be able to skip
them somehow.

Commits
-------

be23926bf8 allow to skip tests based on the supported version
2019-02-14 16:26:56 +01:00
Christian Flothmann
be23926bf8 allow to skip tests based on the supported version
Writing tests for Form related features in the Doctrine and Twig bridges
as well as the FrameworkBundle is a pain as soon as these tests are run
with more recent versions of the Form component. This is due to the fact
that our tests in the bridges and bundle extend test cases from the
component. The tests in the component are expanded with every feature
that gets added there. However, these new features are not present in
the other packages in older version and we thus need to be able to skip
them somehow.
2019-02-14 15:58:36 +01:00
Fabien Potencier
2f5b16fd4b minor #30227 Update validators.bg.xlf (LubenZA)
This PR was squashed before being merged into the 3.4 branch (closes #30227).

Discussion
----------

Update validators.bg.xlf

Translated 83, 84, & 85

| Q             | A
| ------------- | ---
| Branch?       | master for features / 3.4 up to 4.2 for bug fixes <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #30151
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

Commits
-------

4f3bc6bd47 Update validators.bg.xlf
2019-02-14 12:57:47 +01:00
LubenZA
4f3bc6bd47 Update validators.bg.xlf 2019-02-14 12:57:40 +01:00
Fabien Potencier
320c05f9f1 minor #30223 Updated validators.eu.xlf (ikerib)
This PR was merged into the 3.4 branch.

Discussion
----------

Updated validators.eu.xlf

with missing translations

Commits
-------

f496ab638e Updated validators.eu.xlf with missing translations
2019-02-13 10:39:43 +01:00
Fabien Potencier
45023acc86 minor #30224 Update validators.ca.xlf (rogerguasch)
This PR was squashed before being merged into the 3.4 branch (closes #30224).

Discussion
----------

Update validators.ca.xlf

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

Update validators.ca.xlf for Catalan language.

Commits
-------

077df27eca Update validators.ca.xlf
2019-02-13 10:38:01 +01:00
Roger Guasch
077df27eca Update validators.ca.xlf 2019-02-13 10:37:46 +01:00
Fabien Potencier
6c0190eee8 fixed CS 2019-02-13 10:35:08 +01:00
Iker Ibarguren
f496ab638e
Updated validators.eu.xlf with missing translations 2019-02-13 09:13:09 +01:00
Fabien Potencier
0887f62573 bug #30090 [FrameworkBundle] add constraint validators before optimizations (xabbuh)
This PR was merged into the 3.4 branch.

Discussion
----------

[FrameworkBundle] add constraint validators before optimizations

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #24222
| License       | MIT
| Doc PR        |

Commits
-------

05e0e162d3 add constraint validators before optimizations
2019-02-13 08:52:59 +01:00
Fabien Potencier
3b8893fd92 fixed typo 2019-02-13 08:40:41 +01:00
Fabien Potencier
3be75ccf82 minor #30220 [Validator] added missing translation for UK validator (Andrii Boiko)
This PR was merged into the 3.4 branch.

Discussion
----------

[Validator] added missing translation for UK validator

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  |no
| BC breaks?    | no
| Deprecations? |no
| Tests pass?   | yes
| Fixed tickets | #30194
| License       | MIT

Commits
-------

387295e6a4 [Validator] added missing translation for UK validator
2019-02-13 08:38:34 +01:00
Fabien Potencier
1873f32a80 backported a translation 2019-02-13 08:37:30 +01:00
Andrii Boiko
387295e6a4 [Validator] added missing translation for UK validator 2019-02-13 09:30:52 +02:00
Fabien Potencier
fd7875726b feature #30126 [Form] forward valid numeric values to transform() (xabbuh)
This PR was merged into the 3.4 branch.

Discussion
----------

[Form] forward valid numeric values to transform()

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #30114
| License       | MIT
| Doc PR        |

Commits
-------

3be0d35b17 forward valid numeric values to transform()
2019-02-13 08:28:22 +01:00
Fabien Potencier
491e87a1c4 minor #30219 Validator: add the Persian translations (behnoushnorouzi)
This PR was merged into the 3.4 branch.

Discussion
----------

Validator: add the Persian translations

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #30162
| License       | MIT
| Doc PR        | -

Add the missing translations for the Persian (fa) validator.

Commits
-------

32306d8795 Validator: add the Persian translations
2019-02-13 08:09:37 +01:00
Fabien Potencier
a1626699b9 minor #30217 Update validators.sq.xlf (fatonh)
This PR was merged into the 3.4 branch.

Discussion
----------

Update validators.sq.xlf

#30187 Added the missing translations for the Albanian language

| Q             | A
| ------------- | ---
| Branch?       |  3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #30187
| License       | MIT

This PR addresses the issue #30187, adding the missing translations for the Albanian (sq) locale.

Commits
-------

62b226e78e Update validators.sq.xlf
2019-02-13 08:07:43 +01:00
Behnoush
32306d8795 Validator: add the Persian translations 2019-02-12 22:50:28 +01:00
Faton
62b226e78e
Update validators.sq.xlf
#30187 Added the missing translations for the Albanian language
2019-02-12 22:10:37 +01:00
Fabien Potencier
c9c0d45d11 fixed CS 2019-02-12 21:06:43 +01:00
Fabien Potencier
a9353c2977 minor #30216 [Validator] Add the missing translations for the Dutch (nl) locale (reyostallenberg)
This PR was merged into the 3.4 branch.

Discussion
----------

[Validator] Add the missing translations for the Dutch (nl) locale

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #30177
| License       | MIT

This PR addresses the issue #30177, adding the missing translations for the Dutch (nl) locale.

Commits
-------

02662384c3 [Validator] Add the missing translations for the Dutch (nl) locale
2019-02-12 21:00:30 +01:00
Fabien Potencier
bc7ff55bf3 minor #30207 [Validator] Add the missing translations for the Russian (ru) locale (Anton Chernikov)
This PR was merged into the 3.4 branch.

Discussion
----------

 [Validator] Add the missing translations for the Russian (ru) locale

… (ru) locale (antonch1989)

| Q             | A
| ------------- | ---
| Branch?       |  3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #30184
| License       | MIT

Added missing ru translations for the validator component

Commits
-------

8d84cf916b minor #30184 [Validator] Add the missing translations for the Russian (ru) locale (antonch1989)
2019-02-12 20:58:53 +01:00
Fabien Potencier
82af8e7df4 minor #30157 [Validator] Add some missing contents to the English translation (javiereguiluz)
This PR was merged into the 3.4 branch.

Discussion
----------

[Validator] Add some missing contents to the English translation

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

To simplify things, translated files contains all the keys of the English file in `master` branch. That's why our translations in 3.4 branch contain the key `id = 85` even if that is not used in 3.4 branch.

I propose to also include that unused key in the English file to make it easier to keep things in sync.

Commits
-------

ce4ff50b41 [Validator] Add some missing contents to the English translation
2019-02-12 20:57:31 +01:00
Fabien Potencier
7548f9ce2b minor #30204 Add missing ID_id validators translation (ikhsan017)
This PR was squashed before being merged into the 3.4 branch (closes #30204).

Discussion
----------

Add missing ID_id validators translation

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #30170
| License       | MIT
| Doc PR        |

Add the missing translations for the Indonesian ("id") locale

Commits
-------

b645024f5d Add missing ID_id validators translation
2019-02-12 20:55:48 +01:00
Ikhsan Agustian
b645024f5d Add missing ID_id validators translation 2019-02-12 20:55:42 +01:00
Fabien Potencier
1885eac26a fixed CS 2019-02-12 20:54:51 +01:00
Fabien Potencier
6e269cf1be minor #30203 Added missing translations in validators.tr.xlf (mertingen)
This PR was squashed before being merged into the 3.4 branch (closes #30203).

Discussion
----------

Added missing translations in validators.tr.xlf

I referred the same tone and style in the new translations. I did not touch the abbreviation name such as IBAN or BIC. Because they have no counterparts.

| Q             | A
| ------------- | ---
| Branch?       | master for features / 3.4 up to 4.2 for bug fixes <!-- see below -->
| Bug fix?      | yes/no
| New feature?  | yes/no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | yes/no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

Commits
-------

48f1189879 Added missing translations in validators.tr.xlf
2019-02-12 20:53:59 +01:00
mertingen
48f1189879 Added missing translations in validators.tr.xlf 2019-02-12 20:53:50 +01:00
Fabien Potencier
59617eebc9 minor #30198 Update validators.es.xlf (davidpv)
This PR was squashed before being merged into the 3.4 branch (closes #30198).

Discussion
----------

Update validators.es.xlf

| Q             | A
| ------------- | ---
| Branch?       | master for features / 3.4 up to 4.2 for bug fixes <!-- see below -->
| Bug fix?      | yes/no
| New feature?  | yes/no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | yes/no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

Commits
-------

3197a5ff29 Update validators.es.xlf
2019-02-12 20:51:46 +01:00
David Perez Vicens
3197a5ff29 Update validators.es.xlf 2019-02-12 20:51:39 +01:00
Fabien Potencier
de2301b6c3 minor #30200 Update validators.hu.xlf (connorhu)
This PR was squashed before being merged into the 3.4 branch (closes #30200).

Discussion
----------

Update validators.hu.xlf

Translating message of DivisibleBy constraint.

| Q             | A
| ------------- | ---
| Branch?       | master for features / 3.4 up to 4.2 for bug fixes
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #30168
| License       | MIT

Commits
-------

4ab3af0036 Update validators.hu.xlf
2019-02-12 20:50:30 +01:00
Karoly Gossler
4ab3af0036 Update validators.hu.xlf 2019-02-12 20:50:23 +01:00
Fabien Potencier
b799c95fe9 minor #30208 [Validator] Add the missing translations for the Welsh (cy) locale (houdmont)
This PR was squashed before being merged into the 3.4 branch (closes #30208).

Discussion
----------

[Validator] Add the missing translations for the Welsh (cy) locale

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #30154
| License       | MIT

Addresses the missing translations listed in #30154

Commits
-------

8f701ce4e5 [Validator] Add the missing translations for the Welsh (cy) locale
2019-02-12 20:48:57 +01:00