This PR was merged into the 2.0 branch.
Commits
-------
22c7a91 [HttpKernel][Translator] Fixed type-hints
Discussion
----------
[HttpKernel][Translator] Fixed type-hints
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: -
Todo: -
License of the code: MIT
Documentation PR: -
---------------------------------------------------------------------------
by drak at 2012-10-04T15:18:55Z
This PR is ready - the travis build fail is not related to this PR which is just docblock changes.
---------------------------------------------------------------------------
by pborreli at 2012-10-04T15:37:57Z
the travis build fail is indeed not related to your PR but your branch. see https://github.com/drak/symfony/blob/docb/.travis.yml
You should fetch upstream remote, merge, rebase and push again.
---------------------------------------------------------------------------
by drak at 2012-10-04T16:50:28Z
Thanks for the info, but the branch is 100% up to date with `2.0`, the file you quoted is as it is in the main repo: https://github.com/symfony/symfony/blob/2.0/.travis.yml - in any case, it doesnt affect merging this changeset.
This PR was squashed before being merged into the 2.1 branch (closes#5677).
Commits
-------
cf422bf [Validator] Updated swedish translation
Discussion
----------
[Validator] Updated swedish translation
Updated existing strings with plural translations and added some new translations as well.
https://github.com/symfony/symfony/issues/5628
This PR was submitted for the master branch but it was merged into the 2.1 branch instead (closes#5675).
Commits
-------
b0e4d4d Update src/Symfony/Component/Validator/Resources/translations/validators.de.xlf
Discussion
----------
[Validator] Fix and update validators.de.xlf
Adding new localized strings and fixing pluralization for german validation.
This PR was merged into the 2.1 branch.
Commits
-------
6a6b4ae Updated lithuanian validation translation
Discussion
----------
Updated lithuanian validation translation
Updated Lithuanian translation and added all plural form to prevent exception.
This PR was squashed before being merged into the 2.1 branch (closes#5502).
Commits
-------
6200290 PSR-2 correct.
5c17388 Allows using multiselect through Form::setValues().
Discussion
----------
[DomCrawler] Allows using multiselect through Form::setValues().
Patch allows set multiple values in select using setValues() method, as it is used in Symfony\Component\BrowserKit\Client::submit().
This PR was merged into the 2.0 branch.
Commits
-------
6c59fbd [HttpFoundation] Fixed#5611 - Request::splitHttpAcceptHeader incorrect result order.
Discussion
----------
[HttpFoundation] Request::splitHttpAcceptHeader incorrect result order.
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: 5611
Makes items with equal q-values return in the original provided order. Fixes tests to reflect this behavior.
---------------------------------------------------------------------------
by kerihenare at 2012-10-02T20:59:11Z
To avoid confusion over the modified language test I have instead created new tests.
This PR was submitted for the master branch but it was merged into the 2.1 branch instead (closes#5657).
Commits
-------
939d387 Unit test for patched method OptionsResolver::validateOptionValues().
61d0f80 validateOptionValues throw a notice if an allowed value is set and the corresponding option isn't.
Discussion
----------
Patch method OptionsResover::validateOptionValues().
This PR was submitted on the symfony/OptionsResolver read-only repository and moved automatically to the main Symfony repository (closessymfony/OptionsResolver#1).
When we define allowed values for an optional option and the corresponding option was not set. On resolve, OptionsResover::validateOptionValues() was throwing a notice.
This PR was merged into the 2.1 branch.
Commits
-------
2568432 [Form] Hardened code of ViolationMapper against errors
Discussion
----------
[Form] Hardened code of ViolationMapper against errors
Bug fix: no
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: -
Todo: -
License of the code: MIT
Documentation PR: -
This ticket improves the code of ViolationMapper to reduce the risk of bugs and in order to make further bug fixing easier. It was implemented while trying to solve #5578 and is semantically equivalent to the previous version.
This PR was merged into the 2.1 branch.
Commits
-------
2d41229 [Form] Fixed negative index access in PropertyPathBuilder
Discussion
----------
[Form] Fixed negative index access in PropertyPathBuilder
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #5605
Todo: -
License of the code: MIT
Documentation PR: -
This PR was submitted for the master branch but it was merged into the 2.1 branch instead (closes#5646).
Commits
-------
4509c9e Update src/Symfony/Component/Validator/Resources/translations/validators.ro.xlf
Discussion
----------
[validator] Fixed error messages for Length validator, locale: "ro"
....ro.xlf
Pluralization of $minMessage, $maxMessage and $exactMessage is required in LengthValidator.
The English version is already updated.
This PR was merged into the 2.1 branch.
Commits
-------
47d7531 [2.1] Fix SessionHandlerInterface autoloading
Discussion
----------
[2.1] Fix SessionHandlerInterface autoloading
The path for 2.1 is also incorrect. For master, this was fixed in 3b47088c58. This patch adds the `target-dir` prefix to the autoloading base directory of the HttpFoundation stubs.
Note: Issue only affects 2.1, but it probably means `symfony/http-foundation` never worked on PHP 5.3.
---------------------------------------------------------------------------
by stof at 2012-10-01T14:33:18Z
@igorw Can you fix the Locale component too ?
---------------------------------------------------------------------------
by igorw at 2012-10-01T14:42:50Z
As per IRC, locale does not have autoloading for 2.1.
The path for 2.1 is also incorrect. For master, this was fixed in 3b4708. This patch adds the `target-dir` prefix to the autoloading base directory of the HttpFoundation stubs.
This PR was merged into the 2.1 branch.
Commits
-------
3cc3c67 [DoctrineBridge] Require class option for DoctrineType
Discussion
----------
[DoctrineBridge] Require class option for DoctrineType
This is a resubmission of #5289 against the 2.1 branch.
```
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: -
Todo: -
License of the code: MIT
Documentation PR: -
```
---------------------------------------------------------------------------
by stof at 2012-10-01T11:28:39Z
👍
This PR was merged into the 2.1 branch.
Commits
-------
315ffc7 Remove executable bit from HttpKernel/DependencyInjection/ConfigurableExtension.php
Discussion
----------
[HttpKernel] Remove executable bit from ConfigurableExtension.php
See #5636
This PR was squashed before being merged into the 2.0 branch (closes#5633).
Commits
-------
5c60a65 [2.0][http-foundation] Update phpdoc
c17462f [2.0][http-foundation] Fix response getDate method
Discussion
----------
[2.0][http-foundation] Fix Response::getDate method
Bug fix: no
Feature addition: yes
Backwards compatibility break: no
Symfony2 tests pass: yes
License of the code: MIT
Reference #5588, #5629
This PR was submitted for the master branch but it was merged into the 2.0 branch instead (closes#5622).
Commits
-------
538f8c7 fixed undefined variable
Discussion
----------
Undefined security http firewall context listener3
Updated minimal patch,
First patch from static code analysis, $value should be $token I guess. please check.
---------------------------------------------------------------------------
by h4ck3rm1k3 at 2012-09-27T18:00:18Z
I have reverted the admin, i could create a new branch if needed. you can just cherrypick e9bb5a8 that would be easier.
---------------------------------------------------------------------------
by h4ck3rm1k3 at 2012-09-27T18:29:36Z
I squashed it down to one commit. thanks for your patience and help.
This PR was merged into the 2.1 branch.
Commits
-------
c120c4d Added Base64 encoding, decoding to MongoDBProfilerStorage
Discussion
----------
[HttpKernel] Added UTF8 encoding, decoding to MongoDBProfilerStorage
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
It didn't take long for us to hit a non-utf8 error using the new `MongoDBProfilerStorage`. I'm pretty sure the culprit was the Switfmailer DataCollector serializing a message with a PDF attachment.
I thought this would be a good failsafe, although one could ask whether mail message attachments should be serialized at all...
---------------------------------------------------------------------------
by krmcbride at 2012-09-28T17:28:02Z
Switched encoding/decoding to base64
This PR was merged into the 2.1 branch.
Commits
-------
d7623ae [DomCrawler] Added test for supported encodings by mbstring
Discussion
----------
[2.1][DomCrawler] Added test for supported encodings by mbstring
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
License of the code: MIT
---------------------------------------------------------------------------
by fabpot at 2012-09-25T09:35:18Z
As this is a bug fix, it should be done on the 2.0 branch. Thanks.
---------------------------------------------------------------------------
by stof at 2012-09-25T09:41:59Z
@fabpot 2.0 does not contain the code trying to convert the encoding.
This PR was submitted for the master branch but it was merged into the 2.1 branch instead (closes#5602).
Commits
-------
a7d8a74 [Console] Fix duplicated code and a field name
Discussion
----------
[Console] Fix duplicated code and a field name
* Renamed a field name in CommandTesterTest
* Deleted duplicated code in testRenderException
---------------------------------------------------------------------------
by fabpot at 2012-09-27T12:16:40Z
Can you submit this PR on the 2.1 branch as this is where it should be fixed? Thanks.
This PR was submitted for the master branch but it was merged into the 2.1 branch instead (closes#5623).
Commits
-------
4a17053 refactor src/Symfony/Component/Translation/Loader/MoFileLoader.php
Discussion
----------
Refactor extract
proposed patch for what looked falsly as usage of undefined variables (#5620)
---------------------------------------------------------------------------
by stof at 2012-09-27T18:05:22Z
could you squash your commits ?
---------------------------------------------------------------------------
by pborreli at 2012-09-27T18:12:56Z
check http://symfony.com/doc/current/contributing/code/patches.html#step-3-submit-your-patch
---------------------------------------------------------------------------
by h4ck3rm1k3 at 2012-09-27T18:18:53Z
Wow, that is nice, thanks for taking the time to teach me these tricks.
