This PR was merged into the 2.3 branch.
Discussion
----------
[HttpFoundation] Added the ability of using BinaryFileResponse with stream wrappers
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #12990#13187
| License | MIT
| Doc PR | ~
Commits
-------
1da3d61 [HttpFoundation] Added the ability of mapping stream wrapper protocols when using X-Sendfile
dd129b7 [HttpFoundation] Add a test case for using BinaryFileResponse with stream wrappers
This PR was merged into the 2.8 branch.
Discussion
----------
[FrameworkBundle] minor: fix property_info service name in composer.json
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
Commits
-------
2680b5c [FrameworkBundle] minor: fix property_info service name in composer.json
This PR was merged into the 2.8 branch.
Discussion
----------
Upgrade information for the choice_value option
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Relates to #14825 and #14377. The behaviour was changed with #16681 so a not in the upgrade information makes sense to me.
Commits
-------
28675c9 Reflected the change of the choice_value option in the Upgrade information
This PR was merged into the 2.3 branch.
Discussion
----------
Fix the logout path when not using the router
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #17029
| License | MIT
| Doc PR | n/a
This needs to use the base url, not the base path, so that it goes through the front controller when not using url rewriting.
Commits
-------
1a2567e Fix the logout path when not using the router
This PR was merged into the 2.7 branch.
Discussion
----------
Fix the logout path when not using the router
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #17029
| License | MIT
| Doc PR | n/a
This needs to use the base url, not the base path, so that it goes through the front controller when not using url rewriting.
Similar to #17048, but in the new code location
Commits
-------
542b877 Fix the logout path when not using the router
This PR was squashed before being merged into the 2.3 branch (closes#17057).
Discussion
----------
[FrameworkBundle][HttpKernel] the finder is required to discover bundle commands
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #17038
| License | MIT
| Doc PR |
Commits
-------
17fcef5 [FrameworkBundle][HttpKernel] the finder is required to discover bundle commands
This PR was merged into the 2.3 branch.
Discussion
----------
[travis] Auto-conf deps=high matrix line
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
eb9f98e [travis] Auto-conf deps=high matrix line
This PR was merged into the 2.8 branch.
Discussion
----------
[PropertyInfo] Fix some namespaces in tests
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
Commits
-------
0660891 [PropertyInfo] Fix some namespaces in tests
This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes#16698).
Discussion
----------
[PropertyAccessor] A little refactor
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
- Remove obsolete code
- Remove excessive actions
- Fix phpdoc & comments
Commits
-------
457b3f0 [PropertyAccessor] A little refactor - Remove obsolete code - Remove excessive actions - Fix phpdoc & comments
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#16839).
Discussion
----------
[PropertyAccess] minor: constants as internal and removed unused var
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
Commits
-------
6c9bb86 [PropertyAccess] minor: constants as internal and removed unused var
This PR was squashed before being merged into the 2.8 branch (closes#16911).
Discussion
----------
[PropertyInfo] Update List Information from ReflectionExtractor
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #16889
| License | MIT
| Doc PR | symfony/symfony-docs#5974
Unless a property with the same casing exists, lowercase the first letter of a property name extracted from a method. From what I understand, we don't actually need to support `snake_case` at all in the PropertyInfo component.
I cannot think of any use-case where PropertyAccess would be used to get/set a property value *before* using PropertyInfo to find out information about the property and the values it supports.
Since PropertyInfo supports the discovery of property names, which can then be used as identifiers in PropertyAccess, there should be no need to support a naming strategy to map property identifiers from one naming convention to another.
---
Running `$reflectionExtractor->getProperties($class)` with the following classes:
```php
class X
{
public $a;
public $b;
public function getA() {}
}
// Result: array('a', 'b');
```
```php
class Y
{
public $A;
public $b;
public function setA() {}
}
// Result: array('A', 'b');
```
```php
class Y
{
public $username;
protected $emailAddress;
public $password;
public function getEmailAddress() {}
public function isActive() {}
}
// Result: array('username', 'emailAddress', 'password', 'active');
```
Commits
-------
b2da76c [PropertyInfo] Update List Information from ReflectionExtractor
This PR was submitted for the 3.0 branch but it was merged into the 2.7 branch instead (closes#17011).
Discussion
----------
[CONSOLE] Remove unnecessary test
Question interface 'quarantees' that $validator is null or callable
Commits
-------
5dc9bd9 Remove unnecessary test
This PR was merged into the 2.8 branch.
Discussion
----------
[FrameworkBundle] ContainerDebugCommand: pass the right object to the descriptors
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | c5067dacb3 (commitcomment-14884960)
| License | MIT
| Doc PR |
Commits
-------
8cf0022 pass the right object to the descriptors
This PR was merged into the 2.7 branch.
Discussion
----------
[2.7][Console] Table: fix some PhpDoc
| Q | A
| ------------- | ---
| Fixed tickets | n/a
| License | MIT
Commits
-------
1eaef57 [2.7][Console] Table: fix some PhpDoc
This PR was merged into the 2.8 branch.
Discussion
----------
[Form] Improve deprecation notice to mention the affected service id
| Q | A
| ------------- | ---
| Bug fix? |no
| New feature? |no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
This fix changes the deprecation notice to mention the affected service id. Without this update it is quite annoying to find the service with the deprecated definition.
Commits
-------
0b9ea95 Improve form deprecation notices to mention the affected service ids
This PR was merged into the 2.8 branch.
Discussion
----------
[Security][Guard] checkCredentials() should have a @return annotation
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | none
| License | MIT
| Doc PR | none
According to its documentation, an implementation of the `GuardAuthenticatorInterface::checkCredentials()` method should return `true` on success. I've added a `@return` annotation to the PHPDoc block to reflect the fact that this method should actually return something.
Commits
-------
4fd24a0 Added @return to checkCredentials()
This PR was merged into the 2.8 branch.
Discussion
----------
[PhpUnitBridge] Replace "weak-verbose" by "deprecations upper bound" mode
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #16789, #14475
| License | MIT
| Doc PR | -
This is a "new feature" that replaces a "new feature" not yet released but merged into 2.8.1. See #16789.
It is way more flexible to be able to specify the upper bound of remaining deprecation notices that you allow in your test suite. This allows lowering this number while deprecations are removed, step after step.
ping @WouterJ @Tobion @craue @fabpot @stof
Commits
-------
58cd3ee [PhpUnitBridge] Replace "weak-verbose" by "deprecations upper bound" mode
This PR was merged into the 2.3 branch.
Discussion
----------
Clean useless deprecation silencing
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
We added these when we triggered unsilenced notices. But we silence them now.
Commits
-------
9953550 Clean useless deprecation silencing
