Commit Graph

23536 Commits

Author SHA1 Message Date
Christian Flothmann
8cf00225f9 pass the right object to the descriptors 2015-12-10 20:25:40 +01:00
Nicolas Grekas
829c011b49 Merge branch '2.7' into 2.8
* 2.7:
  [Process] Enhance compatiblity with --enable-sigchild
  fix short array syntax for php 5.3
  [Serializer] Fixed  on array of objects in .
  [Process] Always call proc_close
  [Validator] Updated Luxembourgish translations for 2.8
  disable server commands without Process component
  list all server command names in suggestion
  Suggested Process dependency
  disable server:run cmd without Process component
  Suggested Process dependency
  [FrameworkBundle] prevent cache:clear creating too long paths
  [FrameworkBundle] [Translation] Fixed translations not written when no translations directory in update command

Conflicts:
	.travis.yml
	src/Symfony/Bundle/FrameworkBundle/Command/TranslationUpdateCommand.php
	src/Symfony/Bundle/FrameworkBundle/composer.json
2015-12-10 18:11:25 +01:00
Nicolas Grekas
f253d624a0 Merge branch '2.3' into 2.7
* 2.3:
  [Process] Enhance compatiblity with --enable-sigchild
  [Process] Always call proc_close
  [Validator] Updated Luxembourgish translations for 2.8
  [FrameworkBundle] prevent cache:clear creating too long paths

Conflicts:
	src/Symfony/Component/Process/Tests/ProcessTest.php
	src/Symfony/Component/Process/Tests/SigchildDisabledProcessTest.php
	src/Symfony/Component/Process/Tests/SigchildEnabledProcessTest.php
	src/Symfony/Component/Process/Tests/SimpleProcessTest.php
	src/Symfony/Component/Validator/Resources/translations/validators.lb.xlf
2015-12-10 17:58:22 +01:00
Nicolas Grekas
423f83f75e bug #16915 [Process] Enhance compatiblity with --enable-sigchild (nicolas-grekas)
This PR was merged into the 2.3 branch.

Discussion
----------

[Process] Enhance compatiblity with --enable-sigchild

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #16888
| License       | MIT
| Doc PR        | -

This is complete rewrite of the fallback `--enable-sigchild` handling in the Process class.
It removes most of the differences between this and a non-sigchild-enabled php.
Which means the test suite doesn't need anymore to be replayed 3 times (which is how I started this PR, looking for a way to test this component in less time).

I validated this with a locally compiled php, sigchild-enabled. Green.
Changes affect only this special-mode php.

Ping @romainneutron and @Seldaek (original writer of the sigchild support)

Submitted on 2.3 as bugfix, which it is to me.

Commits
-------

e7cc4aa [Process] Enhance compatiblity with --enable-sigchild
2015-12-10 17:39:45 +01:00
Nicolas Grekas
e7cc4aa715 [Process] Enhance compatiblity with --enable-sigchild 2015-12-10 16:01:44 +01:00
Nicolas Grekas
99535506e8 Clean useless deprecation silencing 2015-12-10 15:12:08 +01:00
Alexander M. Turek
4fd24a0fe9 Added @return to checkCredentials() 2015-12-10 14:17:48 +01:00
Tobias Schultze
7ed176f91c minor #16935 [Validator] removes unused variable in LengthValidator class. (hhamon)
This PR was merged into the 2.8 branch.

Discussion
----------

[Validator] removes unused variable in LengthValidator class.

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | ~
| License       | MIT
| Doc PR        | ~

Commits
-------

4d52493 [Validator] removes unused variable in LengthValidator class.
2015-12-10 11:37:25 +01:00
Hugo Hamon
cab6fd531e [Security] backported phpdoc from Guard component. 2015-12-10 09:14:03 +01:00
Hugo Hamon
4d52493b73 [Validator] removes unused variable in LengthValidator class. 2015-12-10 09:10:18 +01:00
Kévin Dunglas
0660891d16 [PropertyInfo] Fix some namespaces in tests 2015-12-10 07:55:42 +01:00
Tobias Schultze
4cde2d1e33 bug #16829 [FrameworkBundle] prevent cache:clear creating too long paths (Tobion)
This PR was merged into the 2.3 branch.

Discussion
----------

[FrameworkBundle] prevent cache:clear creating too long paths

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #15547 #16783
| License       | MIT
| Doc PR        | -

Commits
-------

6e279c5 [FrameworkBundle] prevent cache:clear creating too long paths
2015-12-10 01:42:36 +01:00
Tobias Schultze
e18a42af49 bug #16922 [FrameworkBundle] [Bug] Fixes new InputStyle bug #16920 (AlmogBaku)
This PR was squashed before being merged into the 2.8 branch (closes #16922).

Discussion
----------

[FrameworkBundle] [Bug] Fixes new InputStyle bug #16920

| Q             | A
| ------------- | ---
| Bug fix?      | **yes**
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | **yes**
| Fixed tickets | #16920
| License       | MIT

Commits
-------

d2b9a1d [FrameworkBundle] [Bug] Fixes new InputStyle bug #16920
2015-12-09 14:54:26 +01:00
Almog Baku
d2b9a1db88 [FrameworkBundle] [Bug] Fixes new InputStyle bug #16920 2015-12-09 14:54:22 +01:00
Kévin Dunglas
447ea791be bug #16921 Fix short array syntax for php 5.3 (ewgRa)
This PR was merged into the 2.7 branch.

Discussion
----------

Fix short array syntax for php 5.3

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

70afcc8 fix short array syntax for php 5.3
2015-12-09 13:35:21 +01:00
Evgeniy Sokolov
70afcc8023 fix short array syntax for php 5.3 2015-12-09 12:45:47 +01:00
Fabien Potencier
0b0070e81b bug #16450 [Serializer] Fixed array_unique on array of objects in getAllowedAttributes. (CornyPhoenix)
This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #16450).

Discussion
----------

[Serializer] Fixed `array_unique` on array of objects in `getAllowedAttributes`.

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #16445
| License       | MIT
| Doc PR        | symfony/symfony-docs#16445

Commits
-------

6110bd9 [Serializer] Fixed  on array of objects in .
2015-12-08 21:34:13 +01:00
Konstantin Simon Maria Möllers
6110bd9c60 [Serializer] Fixed on array of objects in . 2015-12-08 21:34:12 +01:00
Fabien Potencier
bbe72f90a0 minor #16905 [Form] Add missing tests for StringUtil::fqcnToBlockPrefix() (jakzal)
This PR was merged into the 2.8 branch.

Discussion
----------

[Form] Add missing tests for StringUtil::fqcnToBlockPrefix()

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #16762
| License       | MIT
| Doc PR        | -

Commits
-------

862b460 [Form] Add missing tests for StringUtil::fqcnToBlockPrefix()
2015-12-08 19:15:12 +01:00
Fabien Potencier
420da14156 bug #16757 [FrameworkBundle] [Translation] Fixed translations not written when no translations directory in update command (jeremyFreeAgent)
This PR was merged into the 2.7 branch.

Discussion
----------

[FrameworkBundle] [Translation] Fixed translations not written when no translations directory in update command

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Currently when you run the TranslationUpdateCommand and want to write the translation in the domain file without a `translations` directory the output is `[OK] Success` but the file is not created.

This PR fix the creation of the directory.

Commits
-------

8c45107 [FrameworkBundle] [Translation] Fixed translations not written when no translations directory in update command
2015-12-08 19:14:24 +01:00
Fabien Potencier
d6dd9a48dd minor #16894 Backport: [Validator] Updated Luxembourgish translations for 2.8 (mweimerskirch)
This PR was merged into the 2.3 branch.

Discussion
----------

Backport: [Validator] Updated Luxembourgish translations for 2.8

| Q             | A
| ------------- | ---
| Fixed tickets | https://github.com/symfony/symfony/pull/16847#discussion-diff-46756549
| License       | MIT

Commits
-------

f9a811b [Validator] Updated Luxembourgish translations for 2.8
2015-12-08 19:06:43 +01:00
Nicolas Grekas
ed226961ab minor #16875 [Process] Always call proc_close (nicolas-grekas)
This PR was merged into the 2.3 branch.

Discussion
----------

[Process] Always call proc_close

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #15617
| License       | MIT
| Doc PR        | -

This should fix one more transient test, and a wrong behavior.

Commits
-------

ccb67d7 [Process] Always call proc_close
2015-12-08 18:10:57 +01:00
Nicolas Grekas
ccb67d7bd2 [Process] Always call proc_close 2015-12-08 18:02:07 +01:00
Nicolas Grekas
afc6ee42ca bug #16902 [2.8][Security] Fix a Polyfill import statement in StringUtils (magnetik)
This PR was merged into the 2.8 branch.

Discussion
----------

[2.8][Security] Fix a Polyfill import statement in StringUtils

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

2a9fa81 [Security] Fix a Polyfill import statement in StringUtils
2015-12-08 13:30:53 +01:00
Jakub Zalas
862b46077d [Form] Add missing tests for StringUtil::fqcnToBlockPrefix() 2015-12-08 12:13:22 +00:00
Marek Pietrzak
27650885ff Fix wrong method name mapping in UPGRADE-3.0.md
| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -
2015-12-08 11:43:15 +00:00
Baptiste Lafontaine
2a9fa81a3c [Security] Fix a Polyfill import statement in StringUtils 2015-12-08 12:07:53 +01:00
Michel Weimerskirch
f9a811b4de [Validator] Updated Luxembourgish translations for 2.8
| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
Conflicts:
	src/Symfony/Component/Validator/Resources/translations/validators.lb.xlf
2015-12-08 00:21:08 +01:00
Wouter J
1a9c0bc174 Use correct height for clearer 2015-12-07 23:56:20 +01:00
Fabien Potencier
c658539d3e minor #16881 Improved the code of the commands that use the new SymfonyStyle class (javiereguiluz)
This PR was squashed before being merged into the 2.8 branch (closes #16881).

Discussion
----------

Improved the code of the commands that use the new SymfonyStyle class

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #16000
| License       | MIT
| Doc PR        | -

When we updated the commands to use the new SymfonyStyle, I did the mistake of overriding the `$output` variable. Now we use the `$io` variable to wrap the SymfonyStyle and to perform input and output operations.

Commits
-------

c5067da Improved the code of the commands that use the new SymfonyStyle class
2015-12-07 22:56:40 +01:00
Javier Eguiluz
c5067dacb3 Improved the code of the commands that use the new SymfonyStyle class 2015-12-07 22:56:39 +01:00
Fabien Potencier
b8fbe69bb8 bug #16871 [FrameworkBundle] Disable built-in server commands when Process component is missing (gnugat, xabbuh)
This PR was merged into the 2.7 branch.

Discussion
----------

[FrameworkBundle] Disable built-in server commands when Process component is missing

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

This also backports the improvement for the `suggest` section from #16650 to the `2.7` branch and improves it by also mentioning the other built-in server commands.

Commits
-------

972c4ca disable server commands without Process component
dd82b64 list all server command names in suggestion
d18fb9b Suggested Process dependency
2015-12-07 22:55:06 +01:00
Fabien Potencier
52915ede0f Merge branch '2.3' into 2.7
* 2.3:
  disable server:run cmd without Process component
  Suggested Process dependency
2015-12-07 22:53:02 +01:00
Fabien Potencier
e5dda019ae bug #16870 [FrameworkBundle] Disable the server:run command when Process component is missing (gnugat, xabbuh)
This PR was merged into the 2.3 branch.

Discussion
----------

[FrameworkBundle] Disable the server:run command when Process component is missing

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

This also backports the improvement for the `suggest` section from #16650 to the `2.3` branch.

Commits
-------

99d1741 disable server:run cmd without Process component
604174c Suggested Process dependency
2015-12-07 22:51:02 +01:00
Christian Flothmann
972c4caae8 disable server commands without Process component 2015-12-06 23:34:46 +01:00
Christian Flothmann
dd82b6459d list all server command names in suggestion 2015-12-06 23:34:45 +01:00
Loïc Faugeron
d18fb9bbbe Suggested Process dependency
The `server:run` command requires the Process component.
2015-12-06 23:33:58 +01:00
Christian Flothmann
99d174176a disable server:run cmd without Process component 2015-12-06 23:31:12 +01:00
Loïc Faugeron
604174c963 Suggested Process dependency
The `server:run` command requires the Process component.
2015-12-06 23:31:09 +01:00
Nicolas Grekas
a4aafca33d Fix DeprecationErrorHandler on PHP 5.3 2015-12-06 16:19:18 +01:00
Christophe Coevoet
27ba4b29f0 Merge branch '2.7' into 2.8
* 2.7:
  Fix the exception message expectation
2015-12-05 19:11:45 +01:00
Christophe Coevoet
0cef1ef54c Fix the exception message expectation
The message was changed between 2.3 and 2.7.
2015-12-05 19:10:05 +01:00
Christophe Coevoet
dbb0ba8f11 Merge branch '2.7' into 2.8
* 2.7:
  [Process] Fix stopping a process on Windows
  Added a test case for the Logger class.
  CS: general fixes
2015-12-05 18:37:59 +01:00
Christophe Coevoet
237b13c56c Merge branch '2.3' into 2.7
* 2.3:
  [Process] Fix stopping a process on Windows
  Added a test case for the Logger class.
  CS: general fixes
2015-12-05 18:37:09 +01:00
Christophe Coevoet
b6e13f8861 minor #16650 Suggested Process dependency (gnugat)
This PR was merged into the 2.8 branch.

Discussion
----------

Suggested Process dependency

The `server:run` command requires the Process component.

Commits
-------

7c1231a Suggested Process dependency
2015-12-05 16:18:14 +01:00
Christophe Coevoet
800232c3d6 minor #16813 [Process] Fix stopping a process on Windows (nicolas-grekas)
This PR was merged into the 2.3 branch.

Discussion
----------

[Process] Fix stopping a process on Windows

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #15617
| License       | MIT
| Doc PR        | -

Commits
-------

80fb51c [Process] Fix stopping a process on Windows
2015-12-05 16:09:16 +01:00
Christophe Coevoet
e49b766037 feature #16789 [PhpUnitBridge] Add weak-verbose mode and match against message instead of test name (nicolas-grekas)
This PR was merged into the 2.8 branch.

Discussion
----------

[PhpUnitBridge] Add weak-verbose mode and match against message instead of test name

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #14475
| License       | MIT
| Doc PR        | -

This is double a DX bug fix:
- the weak-verbose allows showing messages but exit with 0 (see #14475)
- matching against $class::$method was a mistake of mine: you can already `--filter` in phpunit to get by-test filtering but you can't select which message should be traced without this change. I stumbled upon this limitation while doing a Symfony 3 migration workshop...

Commits
-------

a670ff1 [PhpUnitBridge] Add weak-verbose mode and match against message instead of test name
2015-12-05 15:33:16 +01:00
Tobias Schultze
58e3b02ec2 minor #16856 [2.8] Added a note about the new requirement iconv (derrabus)
This PR was merged into the 2.8 branch.

Discussion
----------

[2.8] Added a note about the new requirement iconv

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #16778
| License       | MIT
| Doc PR        | none

When upgrading from 2.7 to 2.8, we need to ensure that `ext-iconv` is present. This PR adds a note about this to the UPGRADE-2.8 file.

Commits
-------

af4f5c5 Added a note about the new requirement iconv.
2015-12-05 14:51:42 +01:00
Christophe Coevoet
1e532b3cbd minor #16748 [DX][YAML] Improved Deprecation Notices (peterrehm)
This PR was merged into the 2.8 branch.

Discussion
----------

[DX][YAML] Improved Deprecation Notices

Show the actual invalid string for the Yaml deprecations to ease the upgrade as you can grep the strings.

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Related #16745

Commits
-------

3179407 Improved error messages for Yaml Deprecations
2015-12-05 14:47:06 +01:00
Christian Flothmann
3c72fccc1b [Yaml] do not remove "comments" in scalar blocks
Inside scalar blocks, lines starting with a `#` character must be
treated like every other strings and must not be ignored as comments.
2015-12-05 14:17:16 +01:00