This PR was merged into the 5.3-dev branch.
Discussion
----------
[Console] Support binary / negatable options
| Q | A
| ------------- | ---
| Branch? | 5.x
| Bug fix? | no
| New feature? | yes
| Deprecations? | no
| Tickets | Fix#24314
| License | MIT
| Doc PR | TODO
This PR take over #26292 to introduce a new option mode `NEGATABLE` that ease creation of option and their negation (ie. `--foo`, `--no-foo`)
Negated options applies only to flag options (`VALUE_NONE`)
```
./cli.php --foo
var_dump(getOption('foo')); // true
./cli.php --no-foo
var_dump(getOption('foo')); // false
```
Commits
-------
1a9a3c34c9 Implement negatable option
8d455dbd0c [WIP] Implements #24314: Support binary / negatable options, e.g. --foo and --no-foo.
This PR was squashed before being merged into the 5.3-dev branch.
Discussion
----------
[WebProfilerBundle] Possibility to dynamically set mode
| Q | A
| ------------- | ---
| Branch? | 5.x
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| License | MIT
Sometimes it is necessary to dynamically decide whether the debug toolbar should be injected or not.
Commits
-------
7c5cf579bb [WebProfilerBundle] Possibility to dynamically set mode
* 5.2:
Cleanup CI scripts
use the clock mock to make test more resilient
fix code style
fix code style
take query and request parameters into account when matching routes
mistake
throw type error when incompatible types are passed
fix tests to run assertions on returned Crawler instances
[FrameworkBundle] Fix UidNormalizer priority
propagate groups to nested constraints
This PR was merged into the 5.2 branch.
Discussion
----------
[FrameworkBundle] Fix UidNormalizer priority
| Q | A
| ------------- | ---
| Branch? | 5.2
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
`AbstractUid` implements `\JsonSerializable`. `JsonSerializableNormalizer` has a priority of `-900`, so it's actually this normalizer that is used instead of the good one. It does not change the result but it adds an extra layer.
Commits
-------
1c652a7649 [FrameworkBundle] Fix UidNormalizer priority
This PR was merged into the 5.2 branch.
Discussion
----------
[PropertyAccess] throw type error when incompatible types are passed
| Q | A
| ------------- | ---
| Branch? | 5.2
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets |
| License | MIT
| Doc PR |
Commits
-------
4c5cff6558 throw type error when incompatible types are passed
* 5.1:
Cleanup CI scripts
fix code style
fix code style
take query and request parameters into account when matching routes
mistake
fix tests to run assertions on returned Crawler instances
propagate groups to nested constraints
This PR was merged into the 5.1 branch.
Discussion
----------
[Validator] propagate groups to nested constraints
| Q | A
| ------------- | ---
| Branch? | 5.1
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix#39386
| License | MIT
| Doc PR |
Commits
-------
13a4610824 propagate groups to nested constraints
* 4.4:
Cleanup CI scripts
fix code style
fix code style
take query and request parameters into account when matching routes
mistake
fix tests to run assertions on returned Crawler instances
This PR was merged into the 4.4 branch.
Discussion
----------
[DomCrawler] fix tests to run assertions on returned Crawler instances
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets |
| License | MIT
| Doc PR |
Commits
-------
1d0c91629a fix tests to run assertions on returned Crawler instances
This PR was merged into the 4.4 branch.
Discussion
----------
[WebProfilerBundle] take query and request parameters into account when matching routes
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix#25206
| License | MIT
| Doc PR |
Commits
-------
28b6051f53 take query and request parameters into account when matching routes
This PR was merged into the 4.4 branch.
Discussion
----------
Cleanup CI scripts
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
Commits
-------
09e51d6b42 Cleanup CI scripts
This PR was merged into the 5.2 branch.
Discussion
----------
[Cache] use the clock mock to make test more resilient
| Q | A
| ------------- | ---
| Branch? | 5.2
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets |
| License | MIT
| Doc PR |
see for example https://ci.appveyor.com/project/fabpot/symfony/builds/37097868#L1534
Commits
-------
35f836a66d use the clock mock to make test more resilient
This PR was merged into the 4.4 branch.
Discussion
----------
fix code style
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets |
| License | MIT
| Doc PR |
I ran the CS fixer and checked all test methods to not make use of `void`.
Commits
-------
689e3039fc fix code style
* 5.2:
harden test to not depend on the actual time
[ProxyManager] fix tests
actually compare the order of entries when any sorting is applied
Dump abstract arguments
* 5.1:
harden test to not depend on the actual time
[ProxyManager] fix tests
actually compare the order of entries when any sorting is applied
Dump abstract arguments
This PR was merged into the 4.4 branch.
Discussion
----------
[Finder] actually compare the order of entries when any sorting is applied
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets |
| License | MIT
| Doc PR |
Without this change the tests where still passing if the sorting didn't work as expected. There are three more tests that sort by file times. I do not really know how to make them more stable though.
Commits
-------
f1ed653eee actually compare the order of entries when any sorting is applied
This PR was merged into the 4.4 branch.
Discussion
----------
[HttpKernel] harden test to not depend on the actual time
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets |
| License | MIT
| Doc PR |
From time to time this test fails (e.g. https://travis-ci.com/github/symfony/symfony/jobs/468014427#L7092). We can fix that by not depending on the system clock which is actually not needed in this test.
Commits
-------
28a956baa9 harden test to not depend on the actual time
This PR was squashed before being merged into the 5.3-dev branch.
Discussion
----------
[DoctrineBridge] Deprecate internal test helpers in Test namespace
| Q | A
| ------------- | ---
| Branch? | 5.x
| Bug fix? | no
| New feature? | no
| Deprecations? | yes
| Tickets | -
| License | MIT
| Doc PR | -
These helper classes are only used internally in the DoctrineBridge and, as far as I can see, only make sense within the test suite of the DoctrineBridge. Having them in `Test` means they are covered by the BC promise, I think we can make our lives more easy by moving them to `Tests`.
Commits
-------
a174e6b4de [DoctrineBridge] Deprecate internal test helpers in Test namespace
