This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes#9714).
Discussion
----------
[HttpFoundation] BinaryFileResponse should also return 416 or 200 on some range-requets
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
I read around in the docs and tried something with BinaryFileResponse ... There are two things I missed in the implementation here:
* If the range, provided in the query, does exceed the file-position, return an 416 (or 200 - I decided to take 416 here)
* If the range is logical invalid (f.e. to request from byte 50 to byte 30 ..) return 200 - OK
One decision I took in addition, is to provide a 200 code if the full file is requested. For me, it doesn't make sense here to return a 206 for just the complete file.
What I'm quite unsure about: Do we need some additional fields for these two options? I can remember reading something about a Content-Range for 416 but I was quite unsure what it should be ...
Commits
-------
d5dc317 [HttpFoundation] BinaryFileResponse should also return 416 or 200 on some range-requets
This PR was merged into the 2.3 branch.
Discussion
----------
[Routing] Remove usage of deprecated _scheme requirement
**This is exact the same commit as it was in #9585, which was not merged due to my fault. Sorry for the noise.**
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #8898, #8176
| License | MIT
| Doc PR |
I removed all usages of the deprecated _scheme requirement inside the Routing Component.
Most parts were pretty easy and after multiple refactorings I came up with the solution to have a Route::hasScheme() method and check against this method.
I also checked for performance and after trying in_array, arra_flip+isset and foreach, the last one was clearly the winner.
https://gist.github.com/Danez/7609898#file-test_performance-php
I also adjusted all tests that test '_scheme' to also check the new schemes-requirement.
Commits
-------
557dfaa Remove usage of deprecated _scheme in Routing Component
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes#9489).
Discussion
----------
[DependencyInjection] Add normalization to tag options
Currently, when using tags in XML, the options aren't normalized. This means that the following code is wrong:
<tag name="sonata_admin" manager-type="doctrine_phpcr" ... />
It should be `manager_name` to remove errors, but that's not following the XML rules. The solution is to use the same normalization as the configuration: replacing - with _.
To be BC, both options (with and without normalization) are kept
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
06d64d8 Do normalization on tag options
This PR was merged into the 2.3 branch.
Discussion
----------
[Filesystem] Changed the mode for a target file in copy() to be write only
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #9789
| License | MIT
| Doc PR | -
Stream wrappers like S3 [do not support w+](http://docs.aws.amazon.com/aws-sdk-php/latest/class-Aws.S3.StreamWrapper.html) and we don't read here anyway (as pointed out in #9789).
Commits
-------
10e43b7 [Filesystem] Changed the mode for a target file in copy() to be write only.
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes#9758).
Discussion
----------
[Console] fixed TableHelper when cell value has new line
#9757
Commits
-------
2e14ba6 [Console] fixed TableHelper when cell value has new line
This PR was merged into the 2.3 branch.
Discussion
----------
[Routing] Fix router matching pattern against multiple hosts
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #8811, #6744
| License | MIT
| Doc PR |
When you had a pattern that matched on multiple host then only the first one was displayed as "almost matching". Fixed router matching against the same pattern on multiple hosts so now it shows every "almost match" on different hosts.
Commits
-------
f727b22 [Routing] Fix router matching pattern against multiple hosts
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes#9763).
Discussion
----------
Update validators.cs.xlf
fixed CZ translation.
there is not such a word as "null" in czech
Commits
-------
eac9032 Update validators.cs.xlf
This PR was merged into the 2.3 branch.
Discussion
----------
[Validator] updated the Spanish translation of the validator strings
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Commits
-------
c9c21a5 [Validator] updated the Spanish translation of the validator strings
This PR was merged into the 2.3 branch.
Discussion
----------
[Validator] Fix mistype in lithuanian validator translations
Fix mistype which slipped through initial proof reading.
| Q | A
| ------------- | ---
| Fixed tickets | #9749
| License | MIT
Commits
-------
e2ef38c Fix mistype which slipped through initial proof reading.
Instead correctly use the array of schemes from the Route.
Also adjusted the dumpers to dump the correct data.
I extended the tests to not only test the deprecated behavior, but also
the new schemes-requirement.
This PR was submitted for the 2.2 branch but it was merged into the 2.3 branch instead (closes#9674).
Discussion
----------
[2.2][Form] rename validators.ua.xlf to validators.uk.xlf
| Q | A
| ------------- | ---
| Fixed tickets | --
| License | MIT
The ISO 639-1 code for Ukrainian is "uk".
Shall I open separate PRs for newer branches as well, or can this be merged into them?
Commits
-------
fe6995d renamed validators.ua.xlf to validators.uk.xlf
This PR was merged into the 2.3 branch.
Discussion
----------
[Validator]Fixed getting wrong msg when value is an object in Exception
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
Commits
-------
cdb5ae0 [Validator]Fixed getting wrong msg when value is an object in UnexpectedTypeException
This PR was merged into the 2.3 branch.
Discussion
----------
allow TraceableEventDispatcher to reuse event instance in nested events
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #9710, #9727
| License | MIT
Commits
-------
454ce16 allow TraceableEventDispatcher to reuse event instance in nested events
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes#9749).
Discussion
----------
[Validator] Add missing lithuanian validator translations
| Q | A
| ------------- | ---
| Fixed tickets |
| License | MIT
Commits
-------
bebb55c Add missing lithuanian validator translations
This PR was squashed before being merged into the 2.3 branch (closes#9718).
Discussion
----------
[validator] throw an exception if isn't an instance of ConstraintValidatorInterface.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #9264
| License | MIT
Commits
-------
fc232a5 [validator] throw an exception if isn't an instance of ConstraintValidatorInterface.
This PR was merged into the 2.3 branch.
Discussion
----------
Reset the box model to content-box in the web debug toolbar
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
This makes the styles compatible with CSS frameworks changing the box model to box-sizing using a universal selector (Bootstrap 3 for instance).
Commits
-------
ae95a71 Reset the box model to content-box in the web debug toolbar
This PR was merged into the 2.3 branch.
Discussion
----------
[FrameworkBundle] Allowed "0" as a checkbox value in php templates
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #8251
| License | MIT
| Doc PR |
Commits
-------
955e8cf [FrameworkBundle] Allowed "0" as a checkbox value in the php template.
This PR was submitted for the 2.2 branch but it was merged into the 2.3 branch instead (closes#9678).
Discussion
----------
[HttpKernel] use static late binding when dumping out container
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no?
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #9649
| License | MIT
| Doc PR |
This PR gives the ability to override the stripComments method in descendants (and to disable the memory-eater container whitespace stripping)
Commits
-------
2e241cc [HttpKernel] use static late binding when dumping out container
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#9698).
Discussion
----------
[Stopwatch] raising delta on stopwatch as travis really breaks with less than 35
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | well many failing so far because of travis
| License | MIT
| Doc PR | no way
Commits
-------
3348c6a raising delta on stopwatch as travis really breaks with less than 35
This PR was submitted for the 2.2 branch but it was merged into the 2.3 branch instead (closes#9686).
Discussion
----------
[Form] Switched to correct gender of "Token"
The neutral gender "das Token" is used in science to describe an array of bits or chars, where as the masculin "der Token" is commenly used for keys in communications and authentication in the network.
I guess the a CSRF-Token is more a key for authentication then a bit array.
Cheers,
Christian
| Q | A
| ------------- | ---
| Bug fix? | yes/kinda
| New feature? | not really
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | ~
| Doc PR | none
Commits
-------
c2bc9ae Switched to correct gender of "Token"
The neutral gender "das Token" is used in science to describe an array of bits or chars, where as the masculin "der Token" is commenly used for keys in communications and authentication in the network.
I guess the a CSRF-Token is more a key for authentication then a bit array.