This PR was merged into the 5.2-dev branch.
Discussion
----------
[HttpFoundation] Deprecate not passing a `Closure` together with `FILTER_CALLBACK` to `ParameterBag::filter()`
| Q | A
| ------------- | ---
| Branch? | 5.2
| Bug fix? | no
| New feature? | no
| Deprecations? | yes
| Tickets | -
| License | MIT
| Doc PR | -
Using `filter_var()` with a configurable flag is risky, because of the `FILTER_CALLBACK` flag.
Restricting the type of callable that is accepted here mitigates the risk.
We did the same in Twig: https://github.com/twigphp/Twig/pull/3308
Commits
-------
d6aea288e7 [HttpFoundation] Deprecate not passing a `Closure` together with `FILTER_CALLBACK` to `ParameterBag::filter()`
This PR was merged into the 4.4 branch.
Discussion
----------
[HttpKernel] Remove Symfony 3 compatibility code
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix#38892
| License | MIT
| Doc PR | N/A
This PR removes dead code that checks for the presence of the `Request::setSessionFactory()` method.
That method was added with #25836 in HttpFoundation 4.1. Since HttpKernel requires at least HttpFoundation 4.4, we can assume that the method is always present and thus simplify some code here.
Additionally, I also fix the doc block as described in #38892. 😉
Commits
-------
b9ca866bdd Remove Symfony 3 compatibility code.
This PR was squashed before being merged into the 5.2-dev branch.
Discussion
----------
remove reflection-docblock from mime requirements
| Q | A
| ------------- | ---
| Branch? | 5.x
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix#38886
| License | MIT
| Doc PR | not needed
See related issue
Commits
-------
f33d16f0b9 remove reflection-docblock from mime requirements
This PR was merged into the 4.4 branch.
Discussion
----------
Fixed translations for Norwegian
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets |
| License | MIT
| Doc PR |
This will fix Travis build on 4.4
Norwegian has two dialects. "old" or "written" (Bokmål) and "new" (Nynorsk). The "new" one is the one everybody* speaks. The locales for these languages are:
- Norwegian: no
- "old": nb
- "new": nn
It does not make sense, sure. However, Symfony have tests that make sure that `no` and `nb` are the same. This PR just copies the `no` translations to `nb`.
----------
\* By "everybody" I mean the younger half of the population, especially in Olso. I am generalising partly because Im ignorant and partly because I wish more people spoke Nynork because that is the dialect I understand.
Commits
-------
b28505abd5 Fixed translations for Norwegian
This PR was merged into the 4.4 branch.
Discussion
----------
[PhpUnitBridge] Fix wrong check for exporter in ConstraintTrait
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| License | MIT
I'll just go hide in the corner after messing up this check. 🤦♂️
Commits
-------
ecb477952a Fix wrong check for exporter in ConstraintTrait
This PR was squashed before being merged into the 4.4 branch.
Discussion
----------
Missing translations for Greek (el)
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | Fix#38743. <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License | MIT
| Doc PR | N/A
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.
Additionally (see https://symfony.com/releases):
- Always add tests and ensure they pass.
- Never break backward compatibility (see https://symfony.com/bc).
- Bug fixes must be submitted against the lowest maintained branch where they apply
(lowest branches are regularly merged to upper ones so they get the fixes too.)
- Features and deprecations must be submitted against branch 5.x.
-->
Commits
-------
02d5985a31 Missing translations for Greek (el)
This PR was squashed before being merged into the 4.4 branch.
Discussion
----------
Form, Security and Validator mn translation
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | Fix#38753
| License | MIT
Adding Form, Security and validator Mongolian[mn] translation
Commits
-------
656d7b8df5 Form, Security and Validator mn translation
This PR was merged into the 4.4 branch.
Discussion
----------
[Cache] Fixed expiry could be int in ChainAdapter due to race conditions
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix#38635
| License | MIT
| Doc PR | no
This bug is hard to re-produce and seems only happen with ArrayAdapter only.
Steps to reproduce:
cache.yaml
```
simple.cache:
adapters:
- cache.adapter.array
- cache.adapter.redis
```
```php
if (isset($item->metadata[CacheItem::METADATA_EXPIRY])) {
$logger->debug($item->key, $item->metadata);
$format = is_int($item->metadata[CacheItem::METADATA_EXPIRY]) ? 'U' : 'U.u';
$item->expiresAt(\DateTime::createFromFormat($format, $item->metadata[CacheItem::METADATA_EXPIRY]));
}
```
Refresh webpage multiple time to make web server busy and logs:
```
[2020-10-29T17:04:51.119653+07:00] application.DEBUG: item-key {"expiry":1603965892.118222,"ctime":4} []
[2020-10-29T17:04:54.322937+07:00] application.DEBUG: item-key {"expiry":1603965895.308393,"ctime":17} []
[2020-10-29T17:04:54.745923+07:00] application.DEBUG: item-key {"expiry":1603965895,"ctime":16} []
```
Commits
-------
268816f26c [Cache] Fixed expiry maybe int due too race conditions
This PR was merged into the 4.4 branch.
Discussion
----------
Complete the Language for Hungarian and Norwegian
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | Fix#38745 and fix#38754
| License | MIT
| Doc PR | -
Hi there, i have complete the translation for this 2 language. Mostly i translate that using google translate and some of the language i define by my self.
Commits
-------
9e4859c87b Complete the Language for Hungarian and Norwegian
This PR was merged into the 4.4 branch.
Discussion
----------
Add FI Form validation translations
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | Fix#38876
| License | MIT
Finnish translations for the Form validators.
Commits
-------
7608142ced Add FI Form validation translations
This PR was merged into the 4.4 branch.
Discussion
----------
Simplify phpunit script
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | N/A
| License | MIT
| Doc PR | N/A
This PR simplifies the `phpunit` script we use for our CI.
* Detection for Symfony 3 has been removed.
* PHPUnit 6 was dropped.
* PHPUnit 7.5 is now used on the PHP 7.1 run.
Commits
-------
447d9c22f6 Simplify phpunit script.
This PR was squashed before being merged into the 5.2-dev branch.
Discussion
----------
[Console] Test degraded true colors
| Q | A
| ------------- | ---
| Branch? | 5.x
| Bug fix? | no
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License | MIT
| Doc PR | symfony/symfony-docs#14494 <!-- required for new features -->
Testing hidden feature of hex colors degraded to ANSI named colors for terminals without true color support.
Commits
-------
a26dc0931b [Console] Test degraded true colors