This PR was merged into the 4.4 branch.
Discussion
----------
[Validator] Fix some typos in Greek language
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| License | MIT
Fix some typos in Greek language
Commits
-------
8df2ea12d3 Fix some typos in Greek language
This PR was submitted for the 5.4 branch but it was squashed and merged into the 4.4 branch instead.
Discussion
----------
[Process] Fix incorrect parameter type
In the affected line of code, fclose() should ONLY be passed a parameter of type resource, but fopen() can return a value of type bool (if the fopen() fails). This results in a fatal error under PHP 8: Fatal error: Uncaught TypeError: fclose(): Argument #1 ($stream) must be of type resource, bool given.
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets |
| License | MIT
| Doc PR |
Commits
-------
d1579a2922 [Process] Fix incorrect parameter type
This PR was merged into the 4.4 branch.
Discussion
----------
[Config] Backport type declarations
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | N/A
| License | MIT
| Doc PR | N/A
This PR backports type declarations from #41575 where it's safe to do so.
Commits
-------
46e18aff9b [Config] Backport type declarations
This PR was merged into the 4.4 branch.
Discussion
----------
[VarExporter] Fix test on PHP 8.1
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Part of #41552
| License | MIT
| Doc PR | N/A
On PHP 8.1, when dumping the properties of an object (either through serialization, `var_dump` or an array cast), those properties might appear in a different order than on PHP 8.0 and earlier.
Because of that, the test I'm fixing here fails. Since the order of the properties is not really important, I'm sorting the dumped array by key in order to get a stable order.
Commits
-------
56359cb999 [VarExporter] Fix test on PHP 8.1
This PR was merged into the 4.4 branch.
Discussion
----------
[Mime] Fix CSV file mime type guess test for PHP 8.1
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | Part of #41552 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License | MIT
| Doc PR | N/A
I had the same result as `@derrabus` on my computer: `application/csv`. The CI returns `text/csv`. These two seem possible, although `text/csv` is described in [RFC 7111](https://datatracker.ietf.org/doc/html/rfc7111#page-3).
(Oops little typo in title, thanks Alexander for the fix 🙏 )
Commits
-------
117cb8f085 [DependencyInjection] Fix CSV file mime type guess test for PHP 8.1
This PR was merged into the 4.4 branch.
Discussion
----------
[HttpClient] Revert bindto workaround for unaffected PHP versions
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix#41622
| License | MIT
| Doc PR | N/A
This PR reverts the changes of #38086 for PHP versions that don't need that workaround.
Commits
-------
e9afce3334 [HttpClient] Revert bindto workaround
This PR was merged into the 4.4 branch.
Discussion
----------
[DependencyInjection] Fix testServiceSubscriber for PHP 8.1
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | Fix#41592 and part of #41552 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License | MIT
| Doc PR | N/A
Commits
-------
a5be196827 [DependencyInjection] Fix testServiceSubscriber for PHP 8.1
This PR was merged into the 4.4 branch.
Discussion
----------
Optimize travis file a bit
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
Commits
-------
fe51b80903 Optimize travis file a bit
This PR was merged into the 4.4 branch.
Discussion
----------
Add missing translations for Swedish
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | Fix#41483
| License | MIT
Add missing Swedish translations to Security component.
Commits
-------
65e96dd13f Add missing translations for Swedish
This PR was merged into the 4.4 branch.
Discussion
----------
Add missing translations for Thai
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | Fix#41086
| License | MIT
Add missing Thai translations to Security component.
Commits
-------
d3249baa06 Add missing translations for Thai
This PR was merged into the 4.4 branch.
Discussion
----------
[FrameworkBundle] Remove duplicate catch block
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License | MIT
| Doc PR | symfony/symfony-docs#... <!-- required for new features -->
Spottet while reviewing https://github.com/symfony/symfony/pull/41576 by `@derrabus`
Commits
-------
32cac1c6f2 Remove duplicate catch block
This PR was merged into the 4.4 branch.
Discussion
----------
[FrameworkBundle][WebProfilerBundle] Don't pass null to string parameters
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Part of #41552
| License | MIT
| Doc PR | N/A
This should fix the remaining issues from our bundle tests
Commits
-------
5af6edae62 [FrameworkBundle][WebProfilerBundle] Don't pass null to string parameters
This PR was merged into the 4.4 branch.
Discussion
----------
[Translation] Don't pass null to strtoupper()
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Part of #41552
| License | MIT
| Doc PR | N/A
This error popped up on 5.3, but not on 4.4. That's why I missed it when fixing the other occurrence with #41240.
Commits
-------
3c8cf9a3d4 [Translation] Don't pass null to strtoupper()
This PR was merged into the 4.4 branch.
Discussion
----------
Fix incompatible implicit float-to-int conversions
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Part of #41552
| License | MIT
| Doc PR | N/A
PHP 8.1 is picky about implicit float-to-int casts if we lose precision because of that cast. This PR should fix all cases that bubbled up in our test suite.
Commits
-------
fc7447681c Fix incompatible implicit float-to-int conversions
This PR was merged into the 4.4 branch.
Discussion
----------
[Security] Added missing translations for Croatian (hr)
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | Fix#41039
| License | MIT
| Doc PR | -
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.
Additionally (see https://symfony.com/releases):
- Always add tests and ensure they pass.
- Never break backward compatibility (see https://symfony.com/bc).
- Bug fixes must be submitted against the lowest maintained branch where they apply
(lowest branches are regularly merged to upper ones so they get the fixes too.)
- Features and deprecations must be submitted against branch 5.x.
- Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
-->
Commits
-------
0bce1f6de1 Add missing security translations
This PR was merged into the 4.4 branch.
Discussion
----------
Fix Serializable deprecations triggered by token mocks
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Part of #41552
| License | MIT
| Doc PR | N/A
On 4.4, `TokenInterface` extends `Serializable` but does not enforce implementations to implement `__serialize()` as well. When creating a mock from this interface, PHPUnit will emit code that triggers a deprecation warning on PHP 8.1.
This PR introduces stricter versions of `TokenInterface` to work around that problem.
My goal was to keep the diff small and mergable. We can probably drop most of the changes when merging to 5.2 because the two methods have been added there.
Commits
-------
48e76fafc6 Fix Serializable deprecations triggered by token mocks
Alexandre Daubois
Nyholm
George Yiannoulopoulos
Alexander M. Turek
David Maicher
Nicolas Grekas
bch36
Maxime Steinhausser
Oskar Stark
Kien Nguyen