This PR was submitted for the 5.4 branch but it was merged into the 4.4 branch instead.
Discussion
----------
[Translation] Missing translations from traits
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix#40528 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License | MIT
| Doc PR | symfony/symfony-docs#... <!-- required for new features -->
If you use ->trans() in traits, your translations will be cleaned with translation:update --clean command
Affected all Symfony versions
Please write some tests for me, I took me long time to debug and repair this :(
Commits
-------
0d8737ff16 Missing translations from traits
This PR was merged into the 4.4 branch.
Discussion
----------
Fix SkippedTestSuite
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
Throwing a TestSkipped in a `setUpBeforeClass` si handled by PHP unit as a standard exception, leading to a generic exception `Test skipped because of an error in hook method` (see https://github.com/symfony/symfony/pull/41380/checks?check_run_id=2645369759#step:14:165)
However phpunit is able to catch `SkippedTestSuiteError` in such situation.(https://github.com/sebastianbergmann/phpunit/blob/master/src/Framework/TestSuite.php#L438-L448)
This PR replaces `self::markTestSkipped` by `throw new SkippedTestSuiteError` (we don't have static method helper for this exception) in our `setUpBeforeClass` methods.
Commits
-------
6f2aa6d245 Fix SkippedTestSuite
This PR was merged into the 4.4 branch.
Discussion
----------
[Console] Revert "bug #41952 fix handling positional arguments"
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
Reverts #41952 as it breaks tests on 5.3 due to an implicit string cast:
We added the `string` typehint to the `$name` argument in 5.x, removing it now to allow for `string|int` would be a BC break which I don't think is worth it.
Commits
-------
6ac2776c47 [Console] Fix type annotation on InputInterface::hasArgument()
9928be05fe Revert "minor #41949 [Console] fix type annotations on InputInterface (nicolas-grekas)"
8fc58aaa45 Revert "bug #41952 [Console] fix handling positional arguments (nicolas-grekas)"
This PR was submitted for the 5.4 branch but it was squashed and merged into the 4.4 branch instead.
Discussion
----------
[EventDispatcher] Correct the called event listener method case
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | none
| Tickets | none
| License | MIT
| Doc PR | none
when define an event listener, if you don't specify a method, then the word case of the actual method maybe wrong, for example :
```yaml
services:
my_kernel_envent_listeners:
class: App\EventListener\KernelListener
tags:
- { name: kernel.event_listener, event: kernel.controller_arguments }
```
no `method` key at this tag, then actual method called is `onKernelControllerarguments`, actually it should be `onKernelControllerArguments`, the case of word 'arguments' should be upper.
ps: only event name that has dash(`_`) will be affected.
Commits
-------
29b4b76416 [EventDispatcher] Correct the called event listener method case
This PR was merged into the 4.4 branch.
Discussion
----------
[Validator] Add missing translations for Japanese.
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | Fix#41823
| License | MIT
| Doc PR | N/A
This PR adds missing Japanese translations.
Commits
-------
603ea6af14 Add missing translations for Japanese.
This PR was merged into the 4.4 branch.
Discussion
----------
Add Bulgarian translation for the validator
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | Fix#38710
| License | MIT
| Doc PR | N/A
Commits
-------
a812cea58a Add Bulgarian translation for the validator
This PR was merged into the 4.4 branch.
Discussion
----------
[Console] fix type annotations on InputInterface
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
`hasArgument` already accepts `string|int`.
Makes sense?
Commits
-------
ab76477012 [Console] fix type annotations on InputInterface
This PR was merged into the 4.4 branch.
Discussion
----------
[PhpUnitBridge] Avoid triggering the autoloader in Deprecation::isLegacy()
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | N/A
| License | MIT
| Doc PR | N/A
The low-deps tests are currently failing because Deprecation::isLegacy() keeps triggering the autoloader and might even do so while `DebugClassLoader` considers a failed autoload attempt as an error.
Commits
-------
b95dfede5f Avoid triggering the autoloader in Deprecation::isLegacy()
This PR was merged into the 4.4 branch.
Discussion
----------
[4.4] Backport type fixes
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
And other changes made while preparing 6.0.
Commits
-------
e1afcb6de1 Backport type fixes
This PR was merged into the 4.4 branch.
Discussion
----------
[Form] better form doc types to support static analysis
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License | MIT
| Doc PR |
otherwise phpstan will complain in custom FormTypes like
```
class RegistrationFormType extends AbstractType
{
public function buildForm(FormBuilderInterface $builder, array $options): void
`````
that it does not know what the iterable $builder and $options are about.
Commits
-------
56900d2b24 [Form] better form doc types to support static analysis
This PR was merged into the 4.4 branch.
Discussion
----------
[DependencyInjection] Turn $defaultDeprecationTemplate into a constant
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | https://github.com/symfony/symfony/pull/41928#discussion_r662277447
| License | MIT
| Doc PR | N/A
Commits
-------
936e399ff9 [DependencyInjection] Turn $defaultDeprecationTemplate into a constant
This PR was merged into the 4.4 branch.
Discussion
----------
uzb translation 4.4 version
| Q | A
| ------------- | ---
| Branch? | 5.4 for features / 4.4, 5.2 or 5.3 for bug fixes <!-- see below -->
| Bug fix? | no
| New feature? | yes <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License | MIT
| Doc PR | symfony/symfony-docs#... <!-- required for new features -->
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.
Additionally (see https://symfony.com/releases):
- Always add tests and ensure they pass.
- Never break backward compatibility (see https://symfony.com/bc).
- Bug fixes must be submitted against the lowest maintained branch where they apply
(lowest branches are regularly merged to upper ones so they get the fixes too.)
- Features and deprecations must be submitted against branch 5.x.
- Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
-->
Commits
-------
d73cd5071e uzb translation
This PR was merged into the 4.4 branch.
Discussion
----------
[PhpUnitBridge] Fix deprecation handler with PHPUnit 10
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix#41580
| License | MIT
| Doc PR |
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.
Additionally (see https://symfony.com/releases):
- Always add tests and ensure they pass.
- Never break backward compatibility (see https://symfony.com/bc).
- Bug fixes must be submitted against the lowest maintained branch where they apply
(lowest branches are regularly merged to upper ones so they get the fixes too.)
- Features and deprecations must be submitted against branch 5.x.
- Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
-->
With PHPUnit 10, a lot of classes and methods were refactored. This PR adds the support of PHPUnit 10 into the deprecation handler.
Commits
-------
5f90fb0fd6 [PhpUnitBridge] Fix deprecation handler with PHPUnit 10
This PR was merged into the 4.4 branch.
Discussion
----------
Revert CI workaround for masterminds/html5
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Masterminds/html5-php#209
| License | MIT
| Doc PR | N/A
The branches of `masterminds/html5` have been fixed, so we can revert our workaround.
Commits
-------
44ca13ef40 Revert CI workaround for masterminds/html5
This PR was merged into the 4.4 branch.
Discussion
----------
CS fixes
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
With a rule hinted by `@julienfalque` in https://github.com/FriendsOfPHP/PHP-CS-Fixer/issues/5785
Commits
-------
31e1a978f5 CS fixes
Nicolas Grekas
Fabien Potencier
Exploit.cz
Jérémy Derussé
jaggle
Ippei Sumida
Robin Chalas
Adrian Nguyen
Ivo Valchev
Alexander M. Turek
shakhobiddin
YaFou
