Commit Graph

12186 Commits

Author SHA1 Message Date
Vitaliy Tverdokhlib
742cdb35be Update validators.ru.xlf
[Validator] russian language update
2013-05-16 11:46:22 +02:00
Christian Flothmann
95f356b8d0 remove check for PHP bug #50731 2013-05-16 11:44:24 +02:00
Hossein Zolfi (Ocean)
204e23e2db adding missing Farsi translations 2013-05-16 11:42:49 +02:00
Fabien Potencier
1231d47acf Revert "merged branch armetiz/master (PR #8045)"
This reverts commit a6dd5db60d, reversing
changes made to da6f190a6b.
2013-05-16 10:06:37 +02:00
Dmitrii Chekaliuk
91b84903b7 Fix Crawler::children() to not trigger a notice for childless node 2013-05-16 03:06:15 +03:00
Lukas Kahwe Smith
6d2135b65c force the Content-Type to html in the web profiler controllers 2013-05-15 19:16:40 +02:00
Fabien Potencier
a6dd5db60d merged branch armetiz/master (PR #8045)
This PR was squashed before being merged into the master branch (closes #8045).

Discussion
----------

[Form] Add missing type hint

Commits
-------

4dccee6 [Form] Add missing type hint
2013-05-15 17:40:41 +02:00
Thomas Tourlourat
4dccee61c7 [Form] Add missing type hint 2013-05-15 17:40:40 +02:00
Fabien Potencier
da6f190a6b merged branch tiraeth/master-browserkit-redirect (PR #8025)
This PR was squashed before being merged into the master branch (closes #8025).

Discussion
----------

[BrowserKit] should not follow redirects if status code is not 30x

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Currently, BrowserKit operates incorrectly. It follows "redirect" when `Location` header is present, but having just the header is not enough to perform redirection. [RFC-2616](http://tools.ietf.org/html/rfc2616#section-14.30) precisely says that the redirection should be performed only with `30x` status codes.

This PR fixes the incorrect behaviour of BrowserKit and make it consist with both the RFC document and with other clients, used for example with Behat.

I've found the issue while testing my application with Behat. I was returning `Location` header with `HTTP 201/Created` status code and was surprised that BrowserKit follows the redirection.

This PR is for 2.3 version (master) of Symfony.

Commits
-------

8f54da7 [BrowserKit] should not follow redirects if status code is not 30x
2013-05-15 17:16:47 +02:00
m.chwedziak
8f54da73dd [BrowserKit] should not follow redirects if status code is not 30x 2013-05-15 17:16:46 +02:00
Fabien Potencier
1f8a1b7125 tweaked previous merge (refs #8029) 2013-05-15 17:12:03 +02:00
Fabien Potencier
4edbf3cd2e merged branch ramonornela/master (PR #8029)
This PR was merged into the master branch.

Discussion
----------

Improvement composer.json Console

Added suggest to composer.json.

Commits
-------

5e6245f [ADD] Component_Console -add suggest in the composer.json to event-dispatcher
2013-05-15 17:11:32 +02:00
Fabien Potencier
d61ca1be07 merged branch jakzal/bugfix/segfaulting-tests (PR #8032)
This PR was merged into the master branch.

Discussion
----------

Fixed the tests on PHP 5.3.3

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #7754
| License       | MIT
| Doc PR        | -

PHPUnit with PHP 5.3.3 couldn't handle garbage collecting properly.

Commits
-------

0617ed1 [Console] Removed the descriptor from data set providers.
2013-05-15 17:09:31 +02:00
Fabien Potencier
d656be01cf merged branch paradoxe/master (PR #8043)
This PR was merged into the master branch.

Discussion
----------

[Form][Twig] Removed an extra table column in the "button_row" block template

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

6d5bc7a [Twig][Form] Removed extra table colunm in the button_row block template
2013-05-15 17:07:12 +02:00
paradoxe
6d5bc7ad0f [Twig][Form] Removed extra table colunm in the button_row block template 2013-05-15 00:05:41 +02:00
Tobias Schultze
940b7888ac [Console] use inheritdoc for Output classes 2013-05-14 18:52:49 +02:00
Tobias Schultze
bd61b925a1 [Console] fix phpdoc of Output classes (esp. regarding the new verbosities)
also add missing information
2013-05-14 18:51:31 +02:00
Tobias Schultze
9dcc9facf0 [Console] fix abstract Output class that fasly claims to support guessing of decorated variable.
Also we don't need to typecast to boolean as its already done by the formatter and its his responsibility
2013-05-14 18:18:10 +02:00
Tobias Schultze
2628d889a7 [Console] the default type value should use the constant in OutputInterface::write 2013-05-14 18:09:22 +02:00
Tobias Schultze
ee0cc40c87 [Console] fix NullOutput
It should not extend from abstract Output class because than it inherits the useless constructor arguments and applies formatting in write() needlessly.
2013-05-14 17:58:06 +02:00
Tobias Schultze
a290f87123 [Console] fix test for NullOutput that does not print anything and add a failing test for verbosity 2013-05-14 17:31:22 +02:00
Jakub Zalas
0617ed16ce [Console] Removed the descriptor from data set providers. 2013-05-14 08:19:41 +01:00
ramonornela
5e6245ffe1 [ADD] Component_Console -add suggest in the composer.json to event-dispatcher 2013-05-13 14:36:19 -03:00
Fabien Potencier
b1c9fd20a1 removed versions in composer.json files 2013-05-13 16:36:40 +02:00
Fabien Potencier
f41ac06531 changed all version deps to accepts all upcoming Symfony versions 2013-05-13 09:33:35 +02:00
Fabien Potencier
6d64c9a990 merged branch jakzal/bugfix/domcrawler-savehtml (PR #8013)
This PR was merged into the master branch.

Discussion
----------

[DomCrawler] Fixed the Crawler::html() method for early PHP versions

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes, but not on travis (segfault)
| Fixed tickets | #7963
| License       | MIT
| Doc PR        | -

Node argument was added to the [`DOMDocument::saveHTML()`](http://php.net/manual/en/domdocument.savehtml.php) in PHP 5.3.6. See http://php.net/manual/en/domdocument.savehtml.php.

It's not a nice looking solution, but seems to be the only option. Condition should be removed once PHP dependency goes over 5.3.6.

Commits
-------

a4e3ebf [DomCrawler] Fixed the Crawler::html() method for PHP versions earlier than 5.3.6.
2013-05-13 09:00:26 +02:00
Kristen Gilden
fd2b2602ab [Validator] added missing Estonian translations
Estonian translations for the following validators:

-  Currency;
-  EqualTo;
-  IdenticalTo;
-  NotEqualTo;
-  NotIdenticalTo;
-  GreaterThan;
-  GreaterThanOrEqual;
-  LessThan;
-  LessThanOrEqual;
2013-05-13 03:35:41 +03:00
Jakub Zalas
a4e3ebf385 [DomCrawler] Fixed the Crawler::html() method for PHP versions earlier than 5.3.6.
Node argument was added to the DOMDocument::saveHTML() in PHP 5.3.6. See http://php.net/manual/en/domdocument.savehtml.php.
2013-05-11 21:34:40 +01:00
Hoffmann András
8ac4844b04 Update validators.hu.xlf 2013-05-11 11:58:58 +02:00
Jakub Zalas
3beaf52ef7 [Security] Disabled the BCryptPasswordEncoder tests for PHP versions lower than 5.3.7.
See https://github.com/ircmaxell/password_compat/issues/10#issuecomment-11203833.
2013-05-10 22:34:58 +01:00
Fabien Potencier
1c61996a5b bumped Symfony version to 2.3.0-DEV-DEV 2013-05-10 21:19:19 +02:00
Fabien Potencier
5c73a4ce77 updated VERSION for 2.3.0-BETA2 2013-05-10 20:28:48 +02:00
Fabien Potencier
498bfa33fa Merge branch '2.2'
* 2.2:
  fixed CS
  Fixed XML syntax.
  Fixed parsing of leading blank lines in folded scalars. Closes #7989.
  [Form] Fixed a method name.
  Added a test case for Loader::import().
  Fixed Loader import
  [Console] Added dedicated testcase for HelperSet class
  [Serializer] fixed CS (refs #7971)
  Fixed fatal error in normalize/denormalizeObject.
  Fixed 2 namespaces

Conflicts:
	src/Symfony/Component/HttpKernel/Debug/ErrorHandler.php
	src/Symfony/Component/HttpKernel/Tests/Fragment/InlineFragmentRendererTest.php
2013-05-10 20:12:13 +02:00
Fabien Potencier
70ea5a61c5 Merge branch '2.1' into 2.2
* 2.1:
  Fixed XML syntax.
  Fixed parsing of leading blank lines in folded scalars. Closes #7989.
  Added a test case for Loader::import().
  Fixed Loader import
  [Console] Added dedicated testcase for HelperSet class
2013-05-10 20:08:31 +02:00
Fabien Potencier
a00abf6cda fixed CS 2013-05-10 18:49:00 +02:00
Andreas Forsblom
0a4837dee2 Fixed XML syntax. 2013-05-10 19:13:09 +03:00
Fabien Potencier
bbdd516e63 [DomCrawler] fixed tests for previous merge 2013-05-10 17:43:46 +02:00
Fabien Potencier
cbfab7ab06 merged branch spil-giacomo/patch-1 (PR #7963)
This PR was merged into the master branch.

Discussion
----------

Update Crawler.php

If HTML is not well-formed XML parsing goes wrong.
Could be useful create another method returning XML and XHTML in a `well-formed` standard?

Commits
-------

0a26641 Update Crawler.php
2013-05-10 17:42:47 +02:00
77web
798a5b9bf4 [Validator] added Japanese translation for comparison validators 2013-05-10 22:32:59 +09:00
Fabien Potencier
31138f4474 merged branch webfactory/pass-excpetions-to-monolog (PR #8000)
This PR was squashed before being merged into the master branch (closes #8000).

Discussion
----------

Pass exceptions from the ExceptionListener to Monolog

| Q             | A
| ------------- | ---
| Bug fix?      | rather yes
| New feature?  | rather no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #7973, #7976
| License       | MIT
| Doc PR        | n/a

Pass exceptions caught by the ExceptionListener to Monolog, using the log message context. As of Monolog 1.5, exceptions passed that way will at least be logged with the line they were thrown in, also including any previous exceptions.

Getting full stack traces (as suggested in #7976) becomes a possible change at the Monolog level (see seldaek/monolog#192) or users can add their own Monolog Formatter for that.

This PR is based on master. I'd be glad to provide similar ones for 2.1/2.2 if you'd pick them. Due to recent changes in the ExceptionListener I don't think a single patch on the older branches can easily be pulled to master anyway.

Commits
-------

97bee20 Pass exceptions from the ExceptionListener to Monolog
2013-05-10 11:42:13 +02:00
Matthias Pigulla
97bee2050c Pass exceptions from the ExceptionListener to Monolog 2013-05-10 11:42:12 +02:00
Fabien Potencier
1003c39a10 uncommented a commented test 2013-05-10 11:39:39 +02:00
alexpods
be42dbc82a [HttpFoundation][File][UploadedFile] Fix guessClientExtension() method 2013-05-10 08:00:03 +02:00
Erin Millard
a5441b2d57 Fixed parsing of leading blank lines in folded scalars. Closes #7989. 2013-05-10 10:09:46 +10:00
Jakub Zalas
ef87ba7913 [Form] Fixed a method name.
1858b96b7d introduced a mocked context and therefore getExecutionContext() is now called getMockExectionContext().
2013-05-10 00:02:36 +01:00
Jakub Zalas
c93b9f72e5 Added a test case for Loader::import(). 2013-05-09 17:22:40 +02:00
Myke79
e8d5d16a13 Fixed Loader import 2013-05-09 17:22:40 +02:00
Fabien Potencier
7fc0768b48 merged branch fabpot/console-fix (PR #7982)
This PR was merged into the master branch.

Discussion
----------

Console fix

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | yes (possibly)
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | symfony/symfony-standard#256
| License       | MIT
| Doc PR        | n/a

Everything is explained in the commits.

Commits
-------

bd0c48c [Console] moved the IO configuration to its own method
fdb4b1f [Console] moved --help support to allow proper behavior with other passed options
2013-05-09 15:01:06 +02:00
Jakub Zalas
d5e7bdf5ee [HttpKernel] Fixed ContainerAwareHttpKernelTest. 2013-05-09 11:31:24 +01:00
Fabien Potencier
bd0c48cc00 [Console] moved the IO configuration to its own method
The IO configuration was also moved earlier in the process so that
options are taken into account as early as possible.

That's useful for instance in Symfony FrameworkBundle, where
commands are registered in the doRun() method. If an exception
occurs during registration, the -q, -v, ... options would not
have any effect.
2013-05-09 11:00:31 +02:00
Fabien Potencier
fdb4b1fd75 [Console] moved --help support to allow proper behavior with other passed options 2013-05-09 10:42:56 +02:00
Tugdual Saunier
dd0e138f8c Eased translationNodeVisitor overriding in TranslationExtension 2013-05-09 10:16:05 +02:00
Stefan Warman
37af7714af [Console] Added dedicated testcase for HelperSet class 2013-05-09 10:10:50 +02:00
Fabien Potencier
eceec63402 merged branch dlsniper/translation-update (PR #7980)
This PR was merged into the master branch.

Discussion
----------

[Validator] Updated translation

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

This updates the Romanian translations to match the latest changes.

Commits
-------

3532f2d Updated translation
2013-05-09 10:09:53 +02:00
Fabien Potencier
853f681957 fixed request scope issues (refs #7457) 2013-05-09 09:53:36 +02:00
Florin Patan
3532f2de28 Updated translation 2013-05-09 10:15:42 +03:00
ikerib
971f5511e0 Basque translations for new validators from #790 2013-05-08 12:34:44 +02:00
Fabien Potencier
e3187590c0 [Serializer] fixed CS (refs #7971) 2013-05-08 10:39:40 +02:00
Lin Clark
60edc58325 Fixed fatal error in normalize/denormalizeObject. 2013-05-08 10:37:01 +02:00
Fabien Potencier
11b0758fbb merged branch hason/czech_validator (PR #7970)
This PR was merged into the master branch.

Discussion
----------

[Validator] Updated czech translation of comparison validators

Commits
-------

1416595 [Validator] Updated czech translation of comparison validators
2013-05-07 21:21:26 +02:00
Martin Hasoň
141659588a [Validator] Updated czech translation of comparison validators 2013-05-07 21:07:22 +02:00
WouterJ
1788c6bd32 Fixed 2 namespaces 2013-05-07 18:20:13 +02:00
Ricardo Oliveira
759ed17b25 [Validator] Added Portuguese translation for the comparison validators 2013-05-07 15:16:53 +01:00
Giacomo Gallico
0a266419b8 Update Crawler.php
If HTML is not well-formed XML parsing goes wrong.
2013-05-07 14:27:06 +03:00
Fabien Potencier
758e886267 merged branch vitaliytv/patch-1 (PR #7949)
This PR was merged into the master branch.

Discussion
----------

[Validator] Update validators.uk.xlf

append translation

Commits
-------

7bc9e09 Update validators.uk.xlf
2013-05-07 12:06:41 +02:00
Fabien Potencier
14cb1fa3d0 Merge branch '2.2'
* 2.2:
  bumped Symfony version to 2.1.11-DEV
  updated VERSION for 2.1.10
  update CONTRIBUTORS for 2.1.10
  updated CHANGELOG for 2.1.10
  fixed CS
  [Process] Cleanup tests & prevent assertion that kills randomly Travis-CI
  [Filesystem] Fix regression introduced in 10dea948

Conflicts:
	src/Symfony/Component/Process/Tests/AbstractProcessTest.php
2013-05-06 22:03:44 +02:00
Fabien Potencier
66433c5626 Merge branch '2.1' into 2.2
* 2.1:
  bumped Symfony version to 2.1.11-DEV
  updated VERSION for 2.1.10
  update CONTRIBUTORS for 2.1.10
  updated CHANGELOG for 2.1.10
  fixed CS
  [Process] Cleanup tests & prevent assertion that kills randomly Travis-CI
  [Filesystem] Fix regression introduced in 10dea948

Conflicts:
	src/Symfony/Component/Form/Extension/Core/DataTransformer/DataTransformerChain.php
	src/Symfony/Component/HttpKernel/Kernel.php
	src/Symfony/Component/HttpKernel/Profiler/RedisProfilerStorage.php
	src/Symfony/Component/Routing/Tests/Loader/XmlFileLoaderTest.php
2013-05-06 22:02:13 +02:00
Fabien Potencier
17a214a1c7 bumped Symfony version to 2.1.11-DEV 2013-05-06 21:45:53 +02:00
Vitaliy Tverdokhlib
7bc9e09b35 Update validators.uk.xlf
append translation
2013-05-06 15:29:08 +03:00
Fabien Potencier
7cced0a0e8 updated VERSION for 2.1.10 2013-05-06 13:01:51 +02:00
Fabien Potencier
9f522de0d5 fixed CS 2013-05-06 12:48:41 +02:00
Fabien Potencier
de98954016 merged branch stloyd/bugfix/process_tests (PR #7947)
This PR was merged into the 2.1 branch.

Discussion
----------

[Process] Cleanup tests & prevent assertion that kills randomly Travis-CI

Commits
-------

05b987f [Process] Cleanup tests & prevent assertion that kills randomly Travis-CI
2013-05-06 12:36:22 +02:00
Joseph Bielawski
05b987f381 [Process] Cleanup tests & prevent assertion that kills randomly Travis-CI 2013-05-06 12:21:56 +02:00
Joseph Bielawski
e4913f8f04 [Filesystem] Fix regression introduced in 10dea948 2013-05-06 12:06:16 +02:00
Marco Pivetta
0aeed90e9a Dependency check should be on ProxyManager directly - fixes #7945 2013-05-06 11:51:21 +02:00
Fabien Potencier
f1c227be22 Merge branch '2.2'
* 2.2:
  added additional tests to cover invalid argument exceptions in OutputFormatterStyle component
  added a missing check for the provider key
  [Validator] fixed wrong URL for XSD
  [Validator] Fixed: $traverse and $deep is passed to the visitor from Validator::validate()
  [Form] Fixed transform()/reverseTransform() to always throw TransformationFailedExceptions
  [Form] Fixed: String validation groups are never interpreted as callbacks
  if the repository method returns an array ensure that it's internal poin...
  [Form] Improved multi-byte handling of NumberToLocalizedStringTransformer
  Fix wrong method in findTaggedServiceIds(), add example to docblock.

Conflicts:
	src/Symfony/Component/Form/Extension/Core/DataTransformer/ChoicesToBooleanArrayTransformer.php
	src/Symfony/Component/Form/Extension/Validator/Constraints/FormValidator.php
2013-05-06 10:44:35 +02:00
Fabien Potencier
b9bc5b4770 Merge branch '2.1' into 2.2
* 2.1:
  added additional tests to cover invalid argument exceptions in OutputFormatterStyle component
  added a missing check for the provider key
  [Validator] fixed wrong URL for XSD
  [Form] Fixed transform()/reverseTransform() to always throw TransformationFailedExceptions
  [Form] Fixed: String validation groups are never interpreted as callbacks
  if the repository method returns an array ensure that it's internal poin...
  Fix wrong method in findTaggedServiceIds(), add example to docblock.

Conflicts:
	src/Symfony/Bridge/Doctrine/Form/DataTransformer/CollectionToArrayTransformer.php
	src/Symfony/Component/Form/Extension/Core/DataTransformer/DataTransformerChain.php
	src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/ArrayToPartsTransformerTest.php
	src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/ChoiceToValueTransformerTest.php
	src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/ChoicesToValuesTransformerTest.php
	src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/DateTimeToArrayTransformerTest.php
	src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/DateTimeToRfc3339TransformerTest.php
	src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/IntegerToLocalizedStringTransformerTest.php
	src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/ValueToDuplicatesTransformerTest.php
2013-05-06 10:37:50 +02:00
Fabien Potencier
59867f921e merged branch fabpot/yaml-optim (PR #7935)
This PR was merged into the master branch.

Discussion
----------

made some optimization when parsing YAML files

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

This change makes a small speed optimization when loading a YAML file, but more important, it allows to use local stream wrappers instead of regular files on the filesystem.

Commits
-------

0586c7e made some optimization when parsing YAML files
2013-05-06 10:32:05 +02:00
Fabien Potencier
6604ff8719 merged branch pborreli/patch-9 (PR #7943)
This PR was merged into the master branch.

Discussion
----------

[HttpFoundation] Reverted a part of #7931

refs: #7931

Commits
-------

09c2114 Reverted a part of f5e7f24819
2013-05-06 10:31:17 +02:00
Fabien Potencier
31a35aa8a6 tweaked previous merge 2013-05-06 10:30:13 +02:00
Pascal Borreli
09c21148be Reverted a part of f5e7f24819 2013-05-06 10:11:45 +02:00
Fabien Potencier
dfd605fc1b merged branch Ocramius/feature/proxy-manager-bridge (PR #7890)
This PR was squashed before being merged into the master branch (closes #7890).

Discussion
----------

ProxyManager Bridge

As of @beberlei's suggestion, I re-implemented #7527 as a new bridge to avoid possible hidden dependencies.

Everything is like #7527 except that the new namespace (and possibly package/subtree split) `Symfony\Bridge\ProxyManager` is introduced

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #6140 (supersedes) #5012 #6102 (maybe) #7527 (supersedes)
| License       | MIT (attached code) - BSD-3-Clause (transitive dependency)
| Doc PR        | Please pester me to death so I do it

This PR introduces lazy services along the lines of zendframework/zf2#4146

It introduces an **OPTIONAL** dependency to [ProxyManager](https://github.com/Ocramius/ProxyManager) and transitively to [`"zendframework/zend-code": "2.*"`](https://github.com/zendframework/zf2/tree/master/library/Zend/Code).

## Lazy services: why? A comprehensive example

For those who don't know what this is about, here's an example.

Assuming you have a service class like following:

```php
class MySuperSlowClass
{
    public function __construct()
    {
        // inject large object graph or do heavy computation
        sleep(10);
    }

    public function doFoo()
    {
        echo 'Foo!';
    }
}
```

The DIC will hang for 10 seconds when calling:

```php
$container->get('my_super_slow_class');
```

With this PR, this can be avoided, and the following call will return a proxy immediately.

```php
$container->getDefinitions('my_super_slow_class')->setLazy(true);
$service = $container->get('my_super_slow_class');
```

The 10 seconds wait time will be delayed until the object is actually used:

```php
$service->doFoo(); // wait 10 seconds, then 'Foo!'
```

A more extensive description of the functionality can be found [here](https://github.com/Ocramius/ProxyManager/blob/master/docs/lazy-loading-value-holder.md).

## When do we need it?

Lazy services can be used to optimize the dependency graph in cases like:

 * Webservice endpoints
 * Db connections
 * Objects that cause I/O in general
 * Large dependency graphs that are not always used

This could also help in reducing excessive service location usage as I've explained [here](http://ocramius.github.com/blog/zf2-and-symfony-service-proxies-with-doctrine-proxies/).

## Implementation quirks of this PR

There's a couple of quirks in the implementation:

 * `Symfony\Component\DependencyInjection\CompilerBuilder#createService` is now public because of the limitations of PHP 5.3
 * `Symfony\Component\DependencyInjection\Dumper\PhpDumper` now with extra mess!
 * The proxies are dumped at the end of compiled containers, therefore the container class is not PSR compliant anymore

Commits
-------

78e3710 ProxyManager Bridge
2013-05-06 08:38:39 +02:00
Marco Pivetta
78e3710de8 ProxyManager Bridge 2013-05-06 08:38:39 +02:00
Stefan Warman
7deb923236 added additional tests to cover invalid argument exceptions in OutputFormatterStyle component 2013-05-06 08:31:43 +02:00
Fabien Potencier
e0d2065344 fixed CS 2013-05-06 08:26:30 +02:00
Fabien Potencier
616e0ac2f9 merged branch entering/crawler-add-node-argument (PR #7924)
This PR was squashed before being merged into the master branch (closes #7924).

Discussion
----------

[Crawler] Add proper validation of node argument of method add

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Crawler method add, fix PHPdoc and

Commits
-------

41805c0 [Crawler] Add proper validation of node argument of method add
2013-05-06 08:24:44 +02:00
entering
41805c042d [Crawler] Add proper validation of node argument of method add 2013-05-06 08:24:44 +02:00
Fabien Potencier
87cc7dc2a8 merged branch Seldaek/methodmap (PR #7933)
This PR was merged into the master branch.

Discussion
----------

[DependencyInjection] Add a method map to avoid computing method names from service names

/cc @schmittjoh @stof

The diff is a bit messy because of indenting, but all this adds really is an `if(isset($this->methodMap[$id])) { $method = $this->methodMap[$id]; }` that bypasses the method_exists + strtr calls. It's not a huge improvements but saves some cycles on something that's typically called a few hundred times per request.

Commits
-------

f1c2ab7 [DependencyInjection] Add a method map to avoid computing method names from service names
2013-05-06 08:21:51 +02:00
Fabien Potencier
c8525862f5 merged branch Seldaek/optim (PR #7931)
This PR was merged into the master branch.

Discussion
----------

A few optimizations

Commits
-------

ea633f5 [HttpKernel] Avoid updating the context if the request did not change
997d549 [HttpFoundation] Avoid a few unnecessary str_replace() calls
f5e7f24 [HttpFoundation] Optimize ServerBag::getHeaders()
2013-05-06 08:18:48 +02:00
Fabien Potencier
e2a2b588b3 merged branch Aitboudad/patch-3 (PR #7941)
This PR was merged into the master branch.

Discussion
----------

fixed DocBlock

Commits
-------

aecc495 fixed DocBlock
2013-05-06 08:16:12 +02:00
Fabien Potencier
aa5a2e97c1 fixed CS 2013-05-06 08:14:04 +02:00
Fabien Potencier
a3492e65f9 merged branch bschussek/issue3154 (PR #7939)
This PR was merged into the master branch.

Discussion
----------

[Form] Added radio button for empty value to expanded single-choice fields

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #3154
| License       | MIT
| Doc PR        | symfony/symfony-docs#2605

Commits
-------

7933971 [Form] Added radio button for empty value to expanded single-choice fields
2013-05-06 08:12:23 +02:00
Abdellatif AitBoudad
aecc495ffd fixed DocBlock 2013-05-06 01:35:31 +02:00
Fabien Potencier
674b30fafe merged branch fabpot/require-previous-session (PR #7938)
This PR was merged into the master branch.

Discussion
----------

[Security] fixed wrong merge (refs #4776)

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

This fixes a bad conflict resolution when #4776 was merged.

Commits
-------

1856df3 [Security] fixed wrong merge (refs #4776)
2013-05-05 21:59:18 +02:00
Bernhard Schussek
793397198a [Form] Added radio button for empty value to expanded single-choice fields 2013-05-05 20:32:52 +02:00
Fabien Potencier
0586c7eb16 made some optimization when parsing YAML files 2013-05-05 19:11:25 +02:00
Fabien Potencier
1856df30c8 [Security] fixed wrong merge (refs #4776) 2013-05-05 18:48:12 +02:00
Fabien Potencier
5b7e1e6f68 added a missing check for the provider key 2013-05-05 18:38:27 +02:00
Jordi Boggiano
f1c2ab78af [DependencyInjection] Add a method map to avoid computing method names from service names 2013-05-05 12:11:01 +02:00
Jordi Boggiano
ea633f5787 [HttpKernel] Avoid updating the context if the request did not change
Due to the BC $this->setRequest() call in the onKernelRequest method, the
request is set twice every time in Symfony, and RequestContext::fromRequest
takes 1ms to run here so if we can skip one call it is a win.
2013-05-05 10:01:52 +02:00
Jordi Boggiano
997d549846 [HttpFoundation] Avoid a few unnecessary str_replace() calls 2013-05-05 10:01:43 +02:00
Jordi Boggiano
f5e7f24819 [HttpFoundation] Optimize ServerBag::getHeaders()
isset() vs in_array makes it take half the time (1ms/req here)
substr() does not have to scan the whole string so it's a wee bit faster
2013-05-04 20:09:58 +02:00
Fabien Potencier
c8f95b5dab merged branch Tobion/deprecated-form-exception (PR #7927)
This PR was merged into the master branch.

Discussion
----------

[Form] removed deprecated exceptions

Removed deprecated exceptions for 2.3.

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

82ff360 [Form] removed deprecated exceptions
2013-05-04 14:33:51 +02:00
Bernhard Schussek
a2df1cfce3 [Form] Fixed failing test 2013-05-04 13:21:24 +02:00
Tobias Schultze
82ff36055c [Form] removed deprecated exceptions 2013-05-04 13:06:57 +02:00
Fabien Potencier
b0e3ea5f5f [Validator] fixed wrong URL for XSD 2013-05-04 10:54:37 +02:00
Bernhard Schussek
59b78c7c16 [Validator] Fixed: $traverse and $deep is passed to the visitor from Validator::validate() 2013-05-03 15:20:58 +02:00
Fabien Potencier
0a8c2ddd4b merged branch bschussek/issue7558 (PR #7917)
This PR was merged into the 2.1 branch.

Discussion
----------

[Form] Fixed transform()/reverseTransform() to always throw TransformationFailedExceptions

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #7558
| License       | MIT
| Doc PR        | -

Commits
-------

bcb5400 [Form] Fixed transform()/reverseTransform() to always throw TransformationFailedExceptions
2013-05-03 13:10:52 +02:00
Fabien Potencier
1510faa96a merged branch bschussek/issue7371 (PR #7918)
This PR was merged into the 2.1 branch.

Discussion
----------

[Form] Fixed: String validation groups are never interpreted as callbacks

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #7371
| License       | MIT
| Doc PR        | -

Commits
-------

7b2ebbf [Form] Fixed: String validation groups are never interpreted as callbacks
2013-05-03 13:08:49 +02:00
Bernhard Schussek
bcb540021a [Form] Fixed transform()/reverseTransform() to always throw TransformationFailedExceptions 2013-05-03 12:15:17 +02:00
Bernhard Schussek
7b2ebbfa41 [Form] Fixed: String validation groups are never interpreted as callbacks 2013-05-03 12:12:06 +02:00
Fabien Potencier
a7608d9115 merged branch bschussek/issue7642 (PR #7903)
This PR was merged into the master branch.

Discussion
----------

[Form] Fixed CSRF error messages to be translated and added "csrf_message" option

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #7642
| License       | MIT
| Doc PR        | TODO

Commits
-------

549a308 [Form] Fixed CSRF error messages to be translated and added "csrf_message" option
2013-05-03 11:06:00 +02:00
Fabien Potencier
795e828140 merged branch xabbuh/issue6651 (PR #7906)
This PR was squashed before being merged into the 2.1 branch (closes #7906).

Discussion
----------

if the repository method returns an array ensure that it's internal poin...

...ter is resetted

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #6651
| License       | MIT
| Doc PR        |

Commits
-------

0610750 if the repository method returns an array ensure that it's internal poin...
2013-05-03 10:59:56 +02:00
Christian Flothmann
0610750378 if the repository method returns an array ensure that it's internal poin... 2013-05-03 10:59:56 +02:00
Bernhard Schussek
dcced01fd5 [Form] Improved multi-byte handling of NumberToLocalizedStringTransformer 2013-05-03 08:56:21 +02:00
Bernhard Schussek
90a20d7835 [Translation] Made translation domain defaults in Translator consistent with TranslatorInterface 2013-05-03 08:41:16 +02:00
Bernhard Schussek
549a308a37 [Form] Fixed CSRF error messages to be translated and added "csrf_message" option 2013-05-03 08:38:36 +02:00
Benjamin Eberlei
cfebe47000 Fix wrong method in findTaggedServiceIds(), add example to docblock. 2013-05-03 07:08:13 +02:00
Fabien Potencier
6a4100c615 merged branch 1ed/hungarian-validator-messages (PR #7914)
This PR was merged into the master branch.

Discussion
----------

[Validator] added hungarian translation for comparison constraints

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | -
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Contains the dots added in #7911

Commits
-------

08708ca [Validator] added hungarian translation for comparison constraints
2013-05-03 07:07:18 +02:00
Fabien Potencier
1ef115aebf merged branch WouterJ/patch-3 (PR #7913)
This PR was merged into the master branch.

Discussion
----------

[Validation] Add dutch translation for new validators

This PR already uses the dots added in #7911

Commits
-------

84a0618 Add translation for new validators from #790
2013-05-03 07:06:19 +02:00
Gábor Egyed
08708caaba [Validator] added hungarian translation for comparison constraints 2013-05-03 01:23:57 +02:00
Wouter J
84a0618af1 Add translation for new validators from #790 2013-05-03 01:24:58 +03:00
Joseph Bielawski
90a7e86349 [Validator] Add missing translation for new validators from #790 2013-05-02 22:58:07 +02:00
Bernhard Schussek
1939dfc5fc [Form] Fixed stofs from #7878 2013-05-02 09:53:57 +02:00
Fabien Potencier
36a8194c95 merged branch alexpods/patch-1 (PR #7891)
This PR was merged into the master branch.

Discussion
----------

[FrameworkBundle] Place initialization of $bundlesDir out of the foreach loop.

Code enhancement. $bundlesDir variable doesn't need any bundle information for initialization. So it must be placed out of the loop to not process unnecessary operations.

Commits
-------

9cca065 [FrameworkBundle] Place initialization of $bundlesDir out of foreach loop
2013-05-01 19:20:49 +02:00
Bilal Amarni
7d67b5b2d4 [Debug] tweak for #6474 2013-05-01 20:15:41 +03:00
Fabien Potencier
457e6abf77 bumped Symfony version to 2.3.0-DEV-DEV 2013-05-01 18:29:33 +02:00
Fabien Potencier
462b05847e updated VERSION for 2.3.0-BETA1 2013-05-01 17:41:17 +02:00
Fabien Potencier
6982f4b452 Merge branch '2.2'
* 2.2:
  [Swiftmailer] bumped allowed versions
  remove validation related headers when needed
  use while loop for iterating
  [Filesystem] copy() is not working when open_basedir is set
2013-05-01 09:15:46 +02:00
Fabien Potencier
9f02b05997 Merge branch '2.1' into 2.2
* 2.1:
  remove validation related headers when needed
  use while loop for iterating
  [Filesystem] copy() is not working when open_basedir is set

Conflicts:
	src/Symfony/Component/HttpKernel/Profiler/FileProfilerStorage.php
2013-05-01 09:15:36 +02:00
Fabien Potencier
609df321aa [Swiftmailer] bumped allowed versions 2013-05-01 09:13:20 +02:00
Alex Pods
9cca065d85 [FrameworkBundle] Place initialization of $bundlesDir out of foreach loop
Code enhancement. $bundlesDir variable doesnt't need any bundle information for initialization. So it must be placed out of the loop to not process unnecessary operations.
2013-05-01 10:39:32 +04:00
Fabien Potencier
2dc012ed01 [DependencyInjection] fixed ? position in some exception messages (refs #7861) 2013-05-01 06:24:56 +02:00
Bilal Amarni
2b554d77fa remove validation related headers when needed 2013-05-01 06:14:15 +02:00
Henrik Bjørnskov
fbe039bfca use while loop for iterating
The other method limits the number of results without taking the
constraints into account.

Fixes GH-7883
2013-05-01 05:56:28 +02:00
Grégoire Pineau
e989d8bd0b [DependencyInjection] Added some check before guessing similar parameters 2013-04-30 20:00:41 +02:00
Grégoire Pineau
9300157a61 [DependencyInjection] Made tests more accurate 2013-04-30 19:56:47 +02:00
Grégoire Pineau
729db0fde7 [DependencyInjection] Add suggestion on ServiceNotFoundException 2013-04-30 19:55:25 +02:00
Grégoire Pineau
f44db48ebe [DependencyInjection] Add suggestion on ParameterNotFoundException 2013-04-30 19:35:42 +02:00
Fabien Potencier
4dcee0a528 tweaked previous merge (refs #6474) 2013-04-30 19:23:11 +02:00
Fabien Potencier
9d5f10ce6f merged branch Koc/fatal-errors-logging (PR #6474)
This PR was squashed before being merged into the master branch (closes #6474).

Discussion
----------

[BC Break][Debug] #2042 implementation of fatal error logging

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #2042
| License       | MIT
| Doc PR        | -

Commits
-------

7671e5c [BC Break][Debug] #2042 implementation of fatal error logging
2013-04-30 19:18:45 +02:00
Konstantin.Myakshin
7671e5c85d [BC Break][Debug] #2042 implementation of fatal error logging 2013-04-30 19:18:44 +02:00
Fabien Potencier
ca4fb5530e merged branch stloyd/patch-3 (PR #7869)
This PR was merged into the 2.1 branch.

Discussion
----------

[Filesystem] copy() is not working when open_basedir is set

More details: https://bugs.php.net/bug.php?id=64634

Commits
-------

10dea94 [Filesystem] copy() is not working when open_basedir is set
2013-04-30 19:08:19 +02:00
Fabien Potencier
f43a0eef9d Merge branch '2.2'
* 2.2:
  Fix getPort() returning 80 instead of 443 when X-FORWARDED-PROTO is set to https
  [Translation] fixed a unit test

Conflicts:
	src/Symfony/Component/HttpFoundation/Request.php
2013-04-30 19:05:37 +02:00
Fabien Potencier
01ff0765b2 Merge branch '2.1' into 2.2
* 2.1:
  Fix getPort() returning 80 instead of 443 when X-FORWARDED-PROTO is set to https
2013-04-30 19:05:10 +02:00
Philipp Strube
2a531d78be Fix getPort() returning 80 instead of 443 when X-FORWARDED-PROTO is set to https 2013-04-30 19:01:33 +02:00
Fabien Potencier
f7d8c98851 merged branch danielholmes/comparison_validators (PR #790)
This PR was merged into the master branch.

Discussion
----------

[2.3] [Validator] added comparison constraints and validators

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

They work on a class level and you specify a list of properties. Included are the standard GreaterThan, GreaterThanOrEqual, LessThan, LessThanOrEqual and Equal. e.g.:

```php
<?php
/**
 * @assert:GreaterThan({"diedDate", "bornDate"})
 * @assert:LessThanOrEqual({"bornDate", "firstSchoolDayDate", "diedDate"})
 */
class Person
{
    private $bornDate;
    private $firstSchoolDayDate;
    private $diedDate;
}
```

I think it would also be useful if they worked on a property level rather than just class. I'm not sure what the default option should be though. e.g. is there a reliable way to determine what's a raw value and what's a property name:

```php
<?php
/** @assert:GreaterThan(80) */
private $iq;
/** @assert:LessThan('dateDied') */
private $bornDate;
/** @assert:LessThanOrEqual('C') */
private $grade;
/** @assert:GreaterThanOrEqual({50, 'ageStartedSchool'}) */
private $age;
```

Commits
-------

0bffdff [Validator] Added comparison validators.
2013-04-30 18:44:58 +02:00
Fabien Potencier
be335d0ca4 merged branch danielholmes/prop_access_additions (PR #7876)
This PR was merged into the master branch.

Discussion
----------

Added negative path replaces and optional string arguments for PropertyPathBuilder.

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

7c729f5 [PropertyAccess] Added negative path replaces and optional string arguments for PropertyPathBuilder.
2013-04-30 18:43:32 +02:00
Fabien Potencier
d1cad7e243 [Translation] fixed a unit test 2013-04-30 11:53:49 +02:00
Fabien Potencier
258ca07545 [HttpKernel] moved symfony/debug to be a requirement (to maintain BC as the code was part of HttpKernel before) 2013-04-30 09:25:51 +02:00
Fabien Potencier
e4b580ea62 merged branch bschussek/fix-property-access-naming (PR #7854)
This PR was merged into the master branch.

Discussion
----------

[PropertyAccess] Made naming consistent with Form and Validator

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

8817e70 [PropertyAccess] Made naming consistent with Form and Validator
2013-04-30 09:23:35 +02:00
Fabien Potencier
7258e85fea merged branch bschussek/issue7873 (PR #7878)
This PR was merged into the master branch.

Discussion
----------

[Form] *_SET_DATA events are now guaranteed to be fired *after* the initial children were added

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #7873
| License       | MIT
| Doc PR        | -

Commits
-------

441222e [Form] *_SET_DATA events are now guaranteed to be fired *after* the initial children were added
2013-04-30 09:22:01 +02:00
Fabien Potencier
40b9b44548 fixed previous merge 2013-04-30 09:21:49 +02:00
Fabien Potencier
9869b3af88 merged branch romainneutron/termsig-tests (PR #7874)
This PR was merged into the master branch.

Discussion
----------

[Process] Add unit tests for #7865

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | |no
| Tests pass?   | yes when 2.1 will be merged in master
| License       | MIT

This PR adds test for #7865. It's currently failing, but will pass once 2.1 will be merged in master.

Commits
-------

421c354 [Process] Add unit tests for #7865
2013-04-30 09:18:11 +02:00
Fabien Potencier
5f889525f6 Merge branch '2.2'
* 2.2:
  [BrowserKit] fixed BC break done recently
  [Process] Fix #5594 : `termsig` must be used instead of `stopsig` in exceptions when a process is signaled
  [Console] find command even if its name is a namespace too (closes #7860)
  Rename misprint property (from warmer to finder)
  Reset all catalogues when adding resource to fallback locale (#7715, #7819)
  Added reloading of fallback catalogues when calling addResource() (#7715)
  Re-added context information to log list
  Add This field is missing RU translation

Conflicts:
	src/Symfony/Component/Console/Tests/ApplicationTest.php
2013-04-30 09:16:44 +02:00
Fabien Potencier
d29bf50dc8 Merge branch '2.1' into 2.2
* 2.1:
  [BrowserKit] fixed BC break done recently
  [Process] Fix #5594 : `termsig` must be used instead of `stopsig` in exceptions when a process is signaled
  Rename misprint property (from warmer to finder)
  Add This field is missing RU translation

Conflicts:
	src/Symfony/Component/Process/Process.php
	src/Symfony/Component/Validator/Resources/translations/validators.ru.xlf
2013-04-30 09:15:50 +02:00
Fabien Potencier
25b8b84f65 [BrowserKit] fixed BC break done recently 2013-04-29 22:22:06 +02:00
Bernhard Schussek
441222eda7 [Form] *_SET_DATA events are now guaranteed to be fired *after* the initial children were added 2013-04-29 17:31:30 +02:00
Romain Neutron
421c354ac9 [Process] Add unit tests for #7865 2013-04-29 15:25:58 +02:00
=
7c729f54b1 [PropertyAccess] Added negative path replaces and optional string arguments for PropertyPathBuilder. 2013-04-29 22:50:06 +10:00
=
0bffdff56f [Validator] Added comparison validators. 2013-04-29 22:43:20 +10:00
Fabien Potencier
84d759d3d5 [SecurityBundle] fixed deps on the security component 2013-04-29 09:37:21 +02:00
Fabien Potencier
1459cfb948 merged branch igorw/security-constraint (PR #7866)
This PR was merged into the master branch.

Discussion
----------

Fix http-kernel dep in symfony/security

The current constraint will not match 2.3.x-dev and cause edge cases
where either:

* composer falls back to symfony/symfony because it cannot find a match
* composer installs 2.2 versions of http-kernel and http-foundation

Commits
-------

01016be Fix http-kernel dep in symfony/security
2013-04-29 09:36:07 +02:00
Fabien Potencier
2dfcc8d8aa merged branch alexpods/patch-1 (PR #7864)
This PR was merged into the master branch.

Discussion
----------

Place hasArgument() check at the beginning of getArgument() method

If input definition doesn't have specified argument, then unnecessary operations will be executed ($arguments = is_int($name) ? array_values($this->arguments) : $this->arguments;)

Commits
-------

992c218 Place hasArgument() check at the beginning of getArgument() method
2013-04-29 09:12:08 +02:00
Antonio J. García Lagar
57c724a37f [Validator] Rename issn constraint message option to be consistent with all constraints having a single message option 2013-04-28 18:50:39 +02:00
Joseph Bielawski
10dea948f3 [Filesystem] copy() is not working when open_basedir is set
More details: https://bugs.php.net/bug.php?id=64634
2013-04-28 18:43:05 +02:00
Igor Wiedler
01016be99e Fix http-kernel dep in symfony/security
The current constraint will not match 2.3.x-dev and cause edge cases
where either:

* composer falls back to symfony/symfony because it cannot find a match
* composer installs 2.2 versions of http-kernel and http-foundation
2013-04-27 22:06:15 +02:00
Romain Neutron
8757ad45a8 [Process] Fix #5594 : termsig must be used instead of stopsig in exceptions when a process is signaled 2013-04-27 20:40:50 +02:00
alexpods
992c218913 Place hasArgument() check at the beginning of getArgument() method
If input definition doesn't have specified argument, then unnecessary operations will be executed ($arguments = is_int($name) ? array_values($this->arguments) : $this->arguments;)
2013-04-27 06:13:33 +04:00
Pascal Borreli
be34917448 [Console] find command even if its name is a namespace too (closes #7860) 2013-04-26 22:56:13 +00:00
Fabien Potencier
88ebd62e1c fixed the registration of the web profiler when the profiler is disabled 2013-04-26 16:27:29 +02:00
Fabien Potencier
a11f9017aa [FrameworkBundle] added a way to disable the profiler
Before:

  enabled: true  # the profiler is enabled and data are collected

  enabled: false # the profiler is enabled but data are not collected (data can be collected on demand)

  No way to disable the profiler

After:

  enabled: true  # the profiler is enabled and data are collected
  collect: true

  enabled: true  # the profiler is enabled but data are not collected (data can be collected on demand)
  collect: false

  enabled: false # the profiler is disabled
2013-04-26 16:14:55 +02:00
Florin Patan
f675dd8faa Truly disabled profiler in prod 2013-04-26 16:14:55 +02:00
Bilal Amarni
6f7e35ea95 fixed a test on windows 2013-04-26 14:08:31 +02:00
Fabien Potencier
aae9afb6d8 [Security] added an exception when the BCrypt encoder cannot be used (refs #7853) 2013-04-26 11:43:25 +02:00
Fabien Potencier
d59ffc9aa2 [Security] added more info about the BCrypt change (refs #7853) 2013-04-26 11:39:57 +02:00
Fabien Potencier
a1031f6422 Revert "merged branch mvrhov/patch-1 (PR #4975)"
This reverts commit 407246a1da, reversing
changes made to 3841d1c6d7.
2013-04-26 10:12:31 +02:00
Fabien Potencier
604aaa2e1e merged branch fabpot/twig-url-escaping (PR #7850)
This PR was merged into the master branch.

Discussion
----------

[2.3] [TwigBridge] save auto-escaping of generated URLs when possible

| Q             | A
| ------------- | ---
| Bug fix?      | [no]
| New feature?  | [yes: optimization]
| BC breaks?    | [no]
| Deprecations? | [no]
| Tests pass?   | [yes]
| Fixed tickets | #7088
| License       | MIT
| Doc PR        | [-]

Determines at compile time whether the generated URL will be safe and thus
saving the unneeded automatic escaping for performance reasons.

The URL generation process percent encodes non-alphanumeric characters. So there is no risk
that malicious/invalid characters are part of the URL. The only character within an URL that
must be escaped in html is the ampersand ("&") which separates query params. So we cannot mark
the URL generation as always safe, but only when we are sure there won't be multiple query
params. This is the case when there are none or only one constant parameter given.
E.g. we know beforehand this will be safe:
- path('route')
- path('route', {'param': 'value'})

But the following may not:
- path('route', var)
- path('route', {'param': ['val1', 'val2'] }) // a sub-array
- path('route', {'param1': 'value1', 'param2': 'value2'})

If param1 and param2 reference placeholder in the route, it would still be safe. But we don't know.

Commits
-------

725568b [TwigBridge] added some unit test for the previous commit
0721ff8 save auto-escaping of generated URLs when possible for performance reasons
2013-04-25 18:30:34 +02:00
Bernhard Schussek
8817e70042 [PropertyAccess] Made naming consistent with Form and Validator 2013-04-25 18:28:27 +02:00
Fabien Potencier
ccc52a4e4b merged branch fabpot/bcrypt (PR #7853)
This PR was merged into the master branch.

Discussion
----------

[Security] Outsource all the BCrypt heavy lifting to a library

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

The [BCrypt bundle](https://github.com/elnur/ElnurBlowfishPasswordEncoderBundle) is already using the library.

This is a working implementation of #7247

Commits
-------

c83546d [Security] tweaked previous commit
b2e553a Outsource all the BCrypt heavy lifting to a library
2013-04-25 18:23:35 +02:00
Fabien Potencier
725568b66d [TwigBridge] added some unit test for the previous commit 2013-04-25 18:21:39 +02:00
Fabien Potencier
c83546d268 [Security] tweaked previous commit 2013-04-25 17:52:07 +02:00
Jakub Zalas
0600d833ac Fixed typo 2013-04-25 17:43:02 +02:00
Elnur Abdurrakhimov
b2e553ae1d Outsource all the BCrypt heavy lifting to a library 2013-04-25 17:38:27 +02:00
Tobias Schultze
0721ff8843 save auto-escaping of generated URLs when possible for performance reasons 2013-04-25 17:00:48 +02:00
Fabien Potencier
1099858678 merged branch bschussek/issue1341 (PR #7849)
This PR was merged into the master branch.

Discussion
----------

[Form] Added support for PATCH requests

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #1341
| License       | MIT
| Doc PR        | not needed

Commits
-------

eabb7a1 [Form] Added support for PATCH requests
2013-04-25 16:47:21 +02:00
Bernhard Schussek
eabb7a17ed [Form] Added support for PATCH requests 2013-04-25 16:09:14 +02:00
Fabien Potencier
5047227489 moved the kernel listener compiler pass to HttpKernel to make it reusable (refs #6643) 2013-04-25 16:01:08 +02:00
alexandresalome
45f1a16b93 make RegisterKernelListenersPass reusable 2013-04-25 15:40:01 +02:00
Fabien Potencier
e9b6c7c2a4 merged branch Seldaek/windows-tests (PR #7847)
This PR was merged into the master branch.

Discussion
----------

Windows test fixes

I checked all components/bundles/bridges.. Now everything is green except a few things still in Process that I wasn't sure what to do with yet.

Commits
-------

ae1624f [Process] Fix tests on windows
08e95db [Finder] Fix tests on windows
e8b07a0 [Filesystem] Fix tests on windows
7b83b72 [Console] Fix tests on windows
2013-04-25 15:33:44 +02:00
Fabien Potencier
1362b388df merged branch fabpot/json-response (PR #7846)
This PR was merged into the master branch.

Discussion
----------

[HttpFoundation] added a note about JSON responses as arrays (refs #6970)

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #6970
| License       | MIT
| Doc PR        | symfony/symfony-docs#2555

Commits
-------

abb32a1 [HttpFoundation] added a note about JSON responses as arrays (refs #6970)
2013-04-25 15:24:03 +02:00
Jordi Boggiano
ae1624fe02 [Process] Fix tests on windows 2013-04-25 15:23:11 +02:00
Fabien Potencier
e04ed3b9c2 merged branch fabpot/create-controller-names (PR #7843)
This PR was merged into the master branch.

Discussion
----------

Add a way to create a short controller name (a🅱️c) from a fully qualify one (controller::action)

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #5865
| License       | MIT
| Doc PR        | n/a

Working implementation of #5865

Commits
-------

0795ea8 [FrameworkBundle] fixed implementation of previous merge (refs #5865)
91ebba4 new method to create shorthand name from full Controller name
2013-04-25 14:59:40 +02:00
Fabien Potencier
abb32a188e [HttpFoundation] added a note about JSON responses as arrays (refs #6970) 2013-04-25 14:33:17 +02:00
Jordi Boggiano
08e95dbbf4 [Finder] Fix tests on windows 2013-04-25 14:12:10 +02:00
Jordi Boggiano
e8b07a0787 [Filesystem] Fix tests on windows 2013-04-25 14:07:50 +02:00
Jordi Boggiano
3bb971e57a [Console] Allow arrays to be used for lists of shortcuts 2013-04-25 14:00:12 +02:00
Jordi Boggiano
7b83b7221a [Console] Fix tests on windows 2013-04-25 13:56:40 +02:00
Fabien Potencier
7d0b30d579 merged branch Seldaek/verbosityflags (PR #7841)
This PR was merged into the master branch.

Discussion
----------

[Console] Add more verbosity levels

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #6066
| License       | MIT
| Doc PR        | symfony/symfony-docs#2554

This adds new verbosity levels.

Replaces #7626 /cc @dlsniper

Commits
-------

02c2038 Fix tests
5327ec4 Add notes in UPGRADE and CHANGELOG
77c9791 [Console] Add tests and support for more types of inputs
54c1377 [Console] Handle new verbosity levels
e639686 Revert invalid changes
8f4d376 Removed unused options
5bb4163 Fixed tests
b62d35f Fix handling of --verbose=... and BC break
16cdb61 Added more verbosity levels
2013-04-25 13:51:06 +02:00
Fabien Potencier
0795ea8663 [FrameworkBundle] fixed implementation of previous merge (refs #5865) 2013-04-25 13:41:28 +02:00