Commit Graph

24114 Commits

Author SHA1 Message Date
Jannik Zschiesche
0b9ea95fd4 Improve form deprecation notices to mention the affected service ids 2015-12-12 02:23:05 +01:00
Tobias Schultze
605e13310b bug #16970 [HttpKernel] HttpCache: remove an ESI instance checking (voronkovich)
This PR was merged into the 3.0 branch.

Discussion
----------

[HttpKernel] HttpCache: remove an ESI instance checking

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | no
| License       | MIT
| Doc PR        | no

This checking was added by this commit 32d964ba39, but now it's not needed

Commits
-------

7528134 Removed ESI instance check
2015-12-12 01:04:47 +01:00
Tobias Schultze
499b8160fd feature #16760 Show silenced errors in separate tab (peterrehm)
This PR was merged into the 2.8 branch.

Discussion
----------

Show silenced errors in separate tab

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #16740
| License       | MIT
| Doc PR        | -

Show the silenced errors in a separate tab other than the debug information to reflect also the counts of the toolbar. Also related to @javiereguiluz's comment here https://github.com/symfony/symfony/pull/10466#issuecomment-37808597.

<img width="1119" alt="bildschirmfoto 2015-11-30 um 16 46 09" src="https://cloud.githubusercontent.com/assets/2010989/11476234/e7fc71a4-9781-11e5-8c2c-0bee587699de.png">

<img width="180" alt="bildschirmfoto 2015-11-30 um 16 47 05" src="https://cloud.githubusercontent.com/assets/2010989/11476256/04957eb4-9782-11e5-8a04-8513f076489c.png">

Commits
-------

81d9b9d Show silenced errors in separate tab
2015-12-11 23:42:09 +01:00
Peter Rehm
81d9b9d5f5 Show silenced errors in separate tab 2015-12-11 21:32:48 +01:00
Maxime Steinhausser
3efe535dad [2.8][Console] Table: fix some PhpDoc 2015-12-11 19:22:43 +01:00
Maxime Steinhausser
1eaef57c13 [2.7][Console] Table: fix some PhpDoc 2015-12-11 19:18:28 +01:00
Jakub Zalas
dd129b71e3 [HttpFoundation] Add a test case for using BinaryFileResponse with stream wrappers 2015-12-11 17:13:59 +00:00
Oleg Voronkovich
7528134b8e Removed ESI instance check 2015-12-11 19:11:08 +03:00
Christophe Coevoet
04cbc1034e minor #16944 [Security][Guard] checkCredentials() should have a @return annotation (derrabus)
This PR was merged into the 2.8 branch.

Discussion
----------

[Security][Guard] checkCredentials() should have a @return annotation

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | none
| License       | MIT
| Doc PR        | none

According to its documentation, an implementation of the `GuardAuthenticatorInterface::checkCredentials()` method should return `true` on success. I've added a `@return` annotation to the PHPDoc block to reflect the fact that this method should actually return something.

Commits
-------

4fd24a0 Added @return to checkCredentials()
2015-12-11 15:26:32 +01:00
Andreas Schempp
107c44a367 CSS min-height and min-width should not be "auto" 2015-12-11 11:02:22 +01:00
Nicolas Grekas
b782cf97cb feature #16937 [PhpUnitBridge] Replace "weak-verbose" by "deprecations upper bound" mode (nicolas-grekas)
This PR was merged into the 2.8 branch.

Discussion
----------

[PhpUnitBridge] Replace "weak-verbose" by "deprecations upper bound" mode

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #16789, #14475
| License       | MIT
| Doc PR        | -

This is a "new feature" that replaces a "new feature" not yet released but merged into 2.8.1. See #16789.
It is way more flexible to be able to specify the upper bound of remaining deprecation notices that you allow in your test suite. This allows lowering this number while deprecations are removed, step after step.

ping @WouterJ @Tobion @craue @fabpot @stof

Commits
-------

58cd3ee [PhpUnitBridge] Replace "weak-verbose" by "deprecations upper bound" mode
2015-12-11 09:59:43 +01:00
Nicolas Grekas
58cd3ee4bc [PhpUnitBridge] Replace "weak-verbose" by "deprecations upper bound" mode 2015-12-11 09:57:52 +01:00
Nicolas Grekas
c7f7a9a569 minor #16946 Clean useless deprecation silencing (nicolas-grekas)
This PR was merged into the 2.3 branch.

Discussion
----------

Clean useless deprecation silencing

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

We added these when we triggered unsilenced notices. But we silence them now.

Commits
-------

9953550 Clean useless deprecation silencing
2015-12-11 08:22:19 +01:00
Christophe Coevoet
bb1c6f60e9 bug #16953 return ajax collector to collectors.php (NothingWeAre)
This PR was merged into the 3.0 branch.

Discussion
----------

return ajax collector to collectors.php

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | no
| Fixed tickets | #16880
| License       | MIT
| Doc PR        |

in symfony 3.0 there is no ajax collector declared. Because of that debug toolbar do not display ajax calls

Commits
-------

8a2c757 return ajax collector to collectors.php
2015-12-10 21:37:26 +01:00
Christian Flothmann
8cf00225f9 pass the right object to the descriptors 2015-12-10 20:25:40 +01:00
NothingWeAre
8a2c75791c return ajax collector to collectors.php
in symfony 3.0 there is no ajax collector declared. Because of that debug toolbar do not display ajac calls
2015-12-10 20:31:29 +02:00
Nicolas Grekas
c1bfa46feb Merge branch '2.8' into 3.0
* 2.8:
  [Process] Enhance compatiblity with --enable-sigchild
  [Validator] removes unused variable in LengthValidator class.
  [FrameworkBundle] [Bug] Fixes new InputStyle bug #16920
  fix short array syntax for php 5.3
  [Serializer] Fixed  on array of objects in .
  [Process] Always call proc_close
  [Form] Add missing tests for StringUtil::fqcnToBlockPrefix()
  [Security] Fix a Polyfill import statement in StringUtils
  [Validator] Updated Luxembourgish translations for 2.8
  Improved the code of the commands that use the new SymfonyStyle class
  disable server commands without Process component
  list all server command names in suggestion
  Suggested Process dependency
  disable server:run cmd without Process component
  Suggested Process dependency
  [FrameworkBundle] prevent cache:clear creating too long paths
  [FrameworkBundle] [Translation] Fixed translations not written when no translations directory in update command

Conflicts:
	.travis.yml
	src/Symfony/Bridge/Twig/Command/LintCommand.php
	src/Symfony/Bundle/FrameworkBundle/Command/ConfigDebugCommand.php
	src/Symfony/Bundle/FrameworkBundle/Command/ContainerDebugCommand.php
	src/Symfony/Bundle/FrameworkBundle/Command/RouterApacheDumperCommand.php
	src/Symfony/Bundle/FrameworkBundle/Command/RouterDebugCommand.php
	src/Symfony/Bundle/FrameworkBundle/Command/ServerRunCommand.php
	src/Symfony/Bundle/FrameworkBundle/Command/TranslationDebugCommand.php
	src/Symfony/Bundle/FrameworkBundle/Command/YamlLintCommand.php
	src/Symfony/Bundle/TwigBundle/Command/DebugCommand.php
	src/Symfony/Component/Security/Core/Util/StringUtils.php
2015-12-10 18:31:09 +01:00
Nicolas Grekas
829c011b49 Merge branch '2.7' into 2.8
* 2.7:
  [Process] Enhance compatiblity with --enable-sigchild
  fix short array syntax for php 5.3
  [Serializer] Fixed  on array of objects in .
  [Process] Always call proc_close
  [Validator] Updated Luxembourgish translations for 2.8
  disable server commands without Process component
  list all server command names in suggestion
  Suggested Process dependency
  disable server:run cmd without Process component
  Suggested Process dependency
  [FrameworkBundle] prevent cache:clear creating too long paths
  [FrameworkBundle] [Translation] Fixed translations not written when no translations directory in update command

Conflicts:
	.travis.yml
	src/Symfony/Bundle/FrameworkBundle/Command/TranslationUpdateCommand.php
	src/Symfony/Bundle/FrameworkBundle/composer.json
2015-12-10 18:11:25 +01:00
Nicolas Grekas
f253d624a0 Merge branch '2.3' into 2.7
* 2.3:
  [Process] Enhance compatiblity with --enable-sigchild
  [Process] Always call proc_close
  [Validator] Updated Luxembourgish translations for 2.8
  [FrameworkBundle] prevent cache:clear creating too long paths

Conflicts:
	src/Symfony/Component/Process/Tests/ProcessTest.php
	src/Symfony/Component/Process/Tests/SigchildDisabledProcessTest.php
	src/Symfony/Component/Process/Tests/SigchildEnabledProcessTest.php
	src/Symfony/Component/Process/Tests/SimpleProcessTest.php
	src/Symfony/Component/Validator/Resources/translations/validators.lb.xlf
2015-12-10 17:58:22 +01:00
Nicolas Grekas
423f83f75e bug #16915 [Process] Enhance compatiblity with --enable-sigchild (nicolas-grekas)
This PR was merged into the 2.3 branch.

Discussion
----------

[Process] Enhance compatiblity with --enable-sigchild

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #16888
| License       | MIT
| Doc PR        | -

This is complete rewrite of the fallback `--enable-sigchild` handling in the Process class.
It removes most of the differences between this and a non-sigchild-enabled php.
Which means the test suite doesn't need anymore to be replayed 3 times (which is how I started this PR, looking for a way to test this component in less time).

I validated this with a locally compiled php, sigchild-enabled. Green.
Changes affect only this special-mode php.

Ping @romainneutron and @Seldaek (original writer of the sigchild support)

Submitted on 2.3 as bugfix, which it is to me.

Commits
-------

e7cc4aa [Process] Enhance compatiblity with --enable-sigchild
2015-12-10 17:39:45 +01:00
Nicolas Grekas
e7cc4aa715 [Process] Enhance compatiblity with --enable-sigchild 2015-12-10 16:01:44 +01:00
Nicolas Grekas
99535506e8 Clean useless deprecation silencing 2015-12-10 15:12:08 +01:00
Alexander M. Turek
4fd24a0fe9 Added @return to checkCredentials() 2015-12-10 14:17:48 +01:00
Tobias Schultze
7ed176f91c minor #16935 [Validator] removes unused variable in LengthValidator class. (hhamon)
This PR was merged into the 2.8 branch.

Discussion
----------

[Validator] removes unused variable in LengthValidator class.

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | ~
| License       | MIT
| Doc PR        | ~

Commits
-------

4d52493 [Validator] removes unused variable in LengthValidator class.
2015-12-10 11:37:25 +01:00
Hugo Hamon
cab6fd531e [Security] backported phpdoc from Guard component. 2015-12-10 09:14:03 +01:00
Hugo Hamon
4d52493b73 [Validator] removes unused variable in LengthValidator class. 2015-12-10 09:10:18 +01:00
Kévin Dunglas
0660891d16 [PropertyInfo] Fix some namespaces in tests 2015-12-10 07:55:42 +01:00
Tobias Schultze
4cde2d1e33 bug #16829 [FrameworkBundle] prevent cache:clear creating too long paths (Tobion)
This PR was merged into the 2.3 branch.

Discussion
----------

[FrameworkBundle] prevent cache:clear creating too long paths

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #15547 #16783
| License       | MIT
| Doc PR        | -

Commits
-------

6e279c5 [FrameworkBundle] prevent cache:clear creating too long paths
2015-12-10 01:42:36 +01:00
Tobias Schultze
e18a42af49 bug #16922 [FrameworkBundle] [Bug] Fixes new InputStyle bug #16920 (AlmogBaku)
This PR was squashed before being merged into the 2.8 branch (closes #16922).

Discussion
----------

[FrameworkBundle] [Bug] Fixes new InputStyle bug #16920

| Q             | A
| ------------- | ---
| Bug fix?      | **yes**
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | **yes**
| Fixed tickets | #16920
| License       | MIT

Commits
-------

d2b9a1d [FrameworkBundle] [Bug] Fixes new InputStyle bug #16920
2015-12-09 14:54:26 +01:00
Almog Baku
d2b9a1db88 [FrameworkBundle] [Bug] Fixes new InputStyle bug #16920 2015-12-09 14:54:22 +01:00
Kévin Dunglas
447ea791be bug #16921 Fix short array syntax for php 5.3 (ewgRa)
This PR was merged into the 2.7 branch.

Discussion
----------

Fix short array syntax for php 5.3

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

70afcc8 fix short array syntax for php 5.3
2015-12-09 13:35:21 +01:00
Evgeniy Sokolov
70afcc8023 fix short array syntax for php 5.3 2015-12-09 12:45:47 +01:00
Tobias Schultze
b1c774f0f2 simplify debug error_reporting levels given php version > 5.3 2015-12-09 01:47:17 +01:00
Fabien Potencier
0b0070e81b bug #16450 [Serializer] Fixed array_unique on array of objects in getAllowedAttributes. (CornyPhoenix)
This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #16450).

Discussion
----------

[Serializer] Fixed `array_unique` on array of objects in `getAllowedAttributes`.

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #16445
| License       | MIT
| Doc PR        | symfony/symfony-docs#16445

Commits
-------

6110bd9 [Serializer] Fixed  on array of objects in .
2015-12-08 21:34:13 +01:00
Konstantin Simon Maria Möllers
6110bd9c60 [Serializer] Fixed on array of objects in . 2015-12-08 21:34:12 +01:00
Fabien Potencier
bbe72f90a0 minor #16905 [Form] Add missing tests for StringUtil::fqcnToBlockPrefix() (jakzal)
This PR was merged into the 2.8 branch.

Discussion
----------

[Form] Add missing tests for StringUtil::fqcnToBlockPrefix()

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #16762
| License       | MIT
| Doc PR        | -

Commits
-------

862b460 [Form] Add missing tests for StringUtil::fqcnToBlockPrefix()
2015-12-08 19:15:12 +01:00
Fabien Potencier
420da14156 bug #16757 [FrameworkBundle] [Translation] Fixed translations not written when no translations directory in update command (jeremyFreeAgent)
This PR was merged into the 2.7 branch.

Discussion
----------

[FrameworkBundle] [Translation] Fixed translations not written when no translations directory in update command

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Currently when you run the TranslationUpdateCommand and want to write the translation in the domain file without a `translations` directory the output is `[OK] Success` but the file is not created.

This PR fix the creation of the directory.

Commits
-------

8c45107 [FrameworkBundle] [Translation] Fixed translations not written when no translations directory in update command
2015-12-08 19:14:24 +01:00
Fabien Potencier
d6dd9a48dd minor #16894 Backport: [Validator] Updated Luxembourgish translations for 2.8 (mweimerskirch)
This PR was merged into the 2.3 branch.

Discussion
----------

Backport: [Validator] Updated Luxembourgish translations for 2.8

| Q             | A
| ------------- | ---
| Fixed tickets | https://github.com/symfony/symfony/pull/16847#discussion-diff-46756549
| License       | MIT

Commits
-------

f9a811b [Validator] Updated Luxembourgish translations for 2.8
2015-12-08 19:06:43 +01:00
Nicolas Grekas
ed226961ab minor #16875 [Process] Always call proc_close (nicolas-grekas)
This PR was merged into the 2.3 branch.

Discussion
----------

[Process] Always call proc_close

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #15617
| License       | MIT
| Doc PR        | -

This should fix one more transient test, and a wrong behavior.

Commits
-------

ccb67d7 [Process] Always call proc_close
2015-12-08 18:10:57 +01:00
Nicolas Grekas
ccb67d7bd2 [Process] Always call proc_close 2015-12-08 18:02:07 +01:00
Nicolas Grekas
afc6ee42ca bug #16902 [2.8][Security] Fix a Polyfill import statement in StringUtils (magnetik)
This PR was merged into the 2.8 branch.

Discussion
----------

[2.8][Security] Fix a Polyfill import statement in StringUtils

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

2a9fa81 [Security] Fix a Polyfill import statement in StringUtils
2015-12-08 13:30:53 +01:00
Jakub Zalas
862b46077d [Form] Add missing tests for StringUtil::fqcnToBlockPrefix() 2015-12-08 12:13:22 +00:00
Marek Pietrzak
27650885ff Fix wrong method name mapping in UPGRADE-3.0.md
| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -
2015-12-08 11:43:15 +00:00
Baptiste Lafontaine
2a9fa81a3c [Security] Fix a Polyfill import statement in StringUtils 2015-12-08 12:07:53 +01:00
Michel Weimerskirch
f9a811b4de [Validator] Updated Luxembourgish translations for 2.8
| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
Conflicts:
	src/Symfony/Component/Validator/Resources/translations/validators.lb.xlf
2015-12-08 00:21:08 +01:00
Wouter J
1a9c0bc174 Use correct height for clearer 2015-12-07 23:56:20 +01:00
Fabien Potencier
c658539d3e minor #16881 Improved the code of the commands that use the new SymfonyStyle class (javiereguiluz)
This PR was squashed before being merged into the 2.8 branch (closes #16881).

Discussion
----------

Improved the code of the commands that use the new SymfonyStyle class

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #16000
| License       | MIT
| Doc PR        | -

When we updated the commands to use the new SymfonyStyle, I did the mistake of overriding the `$output` variable. Now we use the `$io` variable to wrap the SymfonyStyle and to perform input and output operations.

Commits
-------

c5067da Improved the code of the commands that use the new SymfonyStyle class
2015-12-07 22:56:40 +01:00
Javier Eguiluz
c5067dacb3 Improved the code of the commands that use the new SymfonyStyle class 2015-12-07 22:56:39 +01:00
Fabien Potencier
b8fbe69bb8 bug #16871 [FrameworkBundle] Disable built-in server commands when Process component is missing (gnugat, xabbuh)
This PR was merged into the 2.7 branch.

Discussion
----------

[FrameworkBundle] Disable built-in server commands when Process component is missing

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

This also backports the improvement for the `suggest` section from #16650 to the `2.7` branch and improves it by also mentioning the other built-in server commands.

Commits
-------

972c4ca disable server commands without Process component
dd82b64 list all server command names in suggestion
d18fb9b Suggested Process dependency
2015-12-07 22:55:06 +01:00
Fabien Potencier
52915ede0f Merge branch '2.3' into 2.7
* 2.3:
  disable server:run cmd without Process component
  Suggested Process dependency
2015-12-07 22:53:02 +01:00