Commit Graph

14039 Commits

Author SHA1 Message Date
Jordi Boggiano
7b83b7221a [Console] Fix tests on windows 2013-04-25 13:56:40 +02:00
Fabien Potencier
7d0b30d579 merged branch Seldaek/verbosityflags (PR #7841)
This PR was merged into the master branch.

Discussion
----------

[Console] Add more verbosity levels

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #6066
| License       | MIT
| Doc PR        | symfony/symfony-docs#2554

This adds new verbosity levels.

Replaces #7626 /cc @dlsniper

Commits
-------

02c2038 Fix tests
5327ec4 Add notes in UPGRADE and CHANGELOG
77c9791 [Console] Add tests and support for more types of inputs
54c1377 [Console] Handle new verbosity levels
e639686 Revert invalid changes
8f4d376 Removed unused options
5bb4163 Fixed tests
b62d35f Fix handling of --verbose=... and BC break
16cdb61 Added more verbosity levels
2013-04-25 13:51:06 +02:00
Jordi Boggiano
02c20381c5 Fix tests 2013-04-25 13:40:04 +02:00
Fabien Potencier
6a18bfc130 merged branch timaschew/patch-1 (PR #7842)
This PR was merged into the master branch.

Discussion
----------

add german translation for currency validator

| Q             | A
| ------------- | ---
| Fixed tickets | N/A
| License       | MIT

Commits
-------

e99b430 update german translation for validators
2013-04-25 13:16:11 +02:00
Jordi Boggiano
5327ec44e6 Add notes in UPGRADE and CHANGELOG 2013-04-25 12:51:56 +02:00
Jordi Boggiano
77c97913c8 [Console] Add tests and support for more types of inputs 2013-04-25 12:46:25 +02:00
Jordi Boggiano
54c1377a33 [Console] Handle new verbosity levels 2013-04-25 12:42:34 +02:00
Jordi Boggiano
e639686ad5 Revert invalid changes 2013-04-25 12:42:25 +02:00
Florin Patan
8f4d376bce Removed unused options 2013-04-25 12:42:10 +02:00
Florin Patan
5bb41636bc Fixed tests 2013-04-25 12:42:02 +02:00
Jordi Boggiano
b62d35feb9 Fix handling of --verbose=... and BC break 2013-04-25 12:41:54 +02:00
Florin Patan
16cdb6128e Added more verbosity levels 2013-04-25 12:41:44 +02:00
Fabien Potencier
5f9a24d0fa merged branch fabpot/browserkit-redirections (PR #7840)
This PR was merged into the master branch.

Discussion
----------

Browserkit redirections

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #7811, #7731
| License       | MIT
| Doc PR        | n/a

Commits
-------

b60290a [BrowserKit] isolated the max redirect count to a given main request (refs #7811)
c8bc953 Add max redirections limit
2013-04-25 12:40:10 +02:00
Fabien Potencier
9a3f415de5 merged branch Seldaek/multishortcuts (PR #7839)
This PR was merged into the master branch.

Discussion
----------

[Console] Add support for multiple InputOption shortcuts

IDEs and others parsing the xml output of command helps should take note that there is a new shortcuts attribute listing all shortcuts, the shortcut one will only list the first for BC.

Commits
-------

a6421a0 [Console] Add support for multiple InputOption shortcuts
2013-04-25 12:39:22 +02:00
Fabien Potencier
b60290a7c8 [BrowserKit] isolated the max redirect count to a given main request (refs #7811) 2013-04-25 12:35:08 +02:00
Jordi Boggiano
a6421a0f23 [Console] Add support for multiple InputOption shortcuts 2013-04-25 12:32:10 +02:00
Joseph Bielawski
c8bc9533e5 Add max redirections limit 2013-04-25 12:21:41 +02:00
Fabien Potencier
6bbcb21fc9 merged branch ricoli/master (PR #7836)
This PR was merged into the master branch.

Discussion
----------

[Validator] Added Portuguese translation for the currency validator

| Q             | A
| ------------- | ---
| Fixed tickets | N/A
| License       | MIT

Commits
-------

a14eee3 [Validator] Added Portuguese translation for the currency validator
2013-04-25 11:58:38 +02:00
Ricardo Oliveira
a14eee3f81 [Validator] Added Portuguese translation for the currency validator 2013-04-25 10:35:53 +01:00
Fabien Potencier
e48e234c45 [PropertyAccess] removed an interface as discussion in the previous merge (refs #7263) 2013-04-25 10:58:14 +02:00
Fabien Potencier
d8ac478b19 merged branch jaugustin/property-access-add-magic-call (PR #7263)
This PR was merged into the master branch.

Discussion
----------

[PropertyAccess] add support for magic call

Hi,

I add support for magic call with the `PropertyAccess`

the is basic implementation, if no `getter`, `isser`, or `hasser` or `_get` is found and there is `__call` then the PropertyAccess call the getter

the same for setter.

This functionality is disable by default

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | seems OK (failure/errors are the same on master)
| Fixed tickets | #4683, #6413, #5309
| License       | MIT
| Doc PR        | https://github.com/symfony/symfony-docs/pull/2472

- [x] submit changes to the documentation

@bschussek is this ok ?

Commits
-------

a785baa [PropertyAccess] add support for magic call, related to #4683
2013-04-25 10:51:04 +02:00
timaschew
e99b430bd5 update german translation for validators 2013-04-25 10:58:30 +03:00
Fabien Potencier
7ceb6e5c99 merged branch fabpot/browserkit-client (PR #7835)
This PR was merged into the master branch.

Discussion
----------

fixed Client implementation to return the right Response (closes #4475)

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #4475
| License       | MIT
| Doc PR        | symfony/symfony-docs#2549

This PR addresses #4475 by trying to minimize the BC break impact.

Commits
-------

31cefc6 made some small tweaks
84ca34b alternate fix where we had accessor for the BrowerKit request/response instances
1005fd1 fixed Client implementation to return the right Response (closes #4475)
2013-04-25 08:32:27 +02:00
Fabien Potencier
31cefc642b made some small tweaks 2013-04-25 08:21:47 +02:00
Fabien Potencier
84ca34b45e alternate fix where we had accessor for the BrowerKit request/response instances 2013-04-24 22:00:56 +02:00
Fabien Potencier
1005fd1f79 fixed Client implementation to return the right Response (closes #4475) 2013-04-24 20:50:59 +02:00
Fabien Potencier
5fa10ad704 merged branch 77web/validator-currency-translation-ja (PR #7829)
This PR was merged into the master branch.

Discussion
----------

[Validator] Japanese translation for currency constraints

| Q             | A
| ------------- | ---
| Fixed tickets | N/A
| License       | MIT

Commits
-------

1b06190 [Validator] added Japanese translation of the message for currency
2013-04-24 15:34:45 +02:00
77web
1b061901ea [Validator] added Japanese translation of the message for currency 2013-04-24 22:16:50 +09:00
Fabien Potencier
756d51929e merged branch jakzal/filesystem-dump-file (PR #7820)
This PR was merged into the master branch.

Discussion
----------

[Filesystem] Made sure Filesystem::dumpFile() overwrites an existing file

#7753 introduced a change in behaviour. Before, ConfigCache simply used the ``rename()`` function to save a file. It was replaced by ``Filesystem::dumpFile()`` which internally uses ``Filesystem::rename()``. The later checks if file already exists and throws an exception if it exists.

This PR makes sure that ``Filesystem::dumpFile()`` removes the file before creating a new one.

Alternatively, we could introduce a third parameter to the ``Filesystem::rename()`` which would allow to overwrite the target file.

Before #7752:
* [CompilerDebugDumpPass](d100ffaf76/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Compiler/CompilerDebugDumpPass.php (L23)) uses ConfigCache
* [ConfigCache](d100ffaf76/src/Symfony/Component/Config/ConfigCache.php (L103)) uses the [rename()](http://uk1.php.net/rename) function (which overwrites a file if it exists)

After #7752:
* [CompilerDebugDumpPass](ad47bc4738/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Compiler/CompilerDebugDumpPass.php (L23)) uses the ``Filesystem::dumpFile()``
* [Filesystem::dumpFile()](ad47bc4738/src/Symfony/Component/Filesystem/Filesystem.php (L458)) uses the [Filesystem::rename()](ad47bc4738/src/Symfony/Component/Filesystem/Filesystem.php (L239)) (which throws an exception if file exists)

| Q | 	A
| ------------- | ---
| Bug fix?	| yes
| New feature?	| no
| BC breaks?	| no
| Deprecations?	| no
| Tests pass?	| yes
| Fixed tickets	| #7816
| License | 	MIT
| Doc PR	| ~

Commits
-------

4f4ec76 [Filesystem] Made sure Filesystem::dumpFile() overwrites an existing file.
2013-04-24 11:28:15 +02:00
Fabien Potencier
ae88c02236 merged branch romainneutron/process-builder (PR #7821)
This PR was merged into the master branch.

Discussion
----------

[Process] Fix two process-builder minor bugs

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

Everything is in the commit messages :

 - Use new ProcessUtils::escapeArgument to escape ProcessBuillder prefix
 - Do not throw LogicException in ProcessBuilder::getProcess if no arguments are set but a prefix is

Commits
-------

1de29b9 [Process] Do not throw LogicException in ProcessBuilder::getProcess if no arguments are set but a prefix is
209799b [Process] Use new ProcessUtils::escapeArgument to escape ProcessBuilder prefix
2013-04-24 10:37:01 +02:00
Jakub Zalas
4f4ec76ba4 [Filesystem] Made sure Filesystem::dumpFile() overwrites an existing file. 2013-04-24 09:04:45 +01:00
Fabien Potencier
f5a6d4df88 merged branch kepten/master (PR #7823)
This PR was merged into the master branch.

Discussion
----------

[Validator] updated Hungarian translation

updated and extended Hungarian translation

Commits
-------

cf36126 [Validator] updated Hungarian translation
2013-04-24 07:10:11 +02:00
Fabien Potencier
9b2527a35e merged branch ikerib/basque-trans (PR #7822)
This PR was merged into the master branch.

Discussion
----------

[Validator] Added Basque translations of currency

Commits
-------

d50f488 Currency translation
2013-04-24 07:09:52 +02:00
Robert Kiss
cf36126cea [Validator] updated Hungarian translation
updated and extended Hungarian translation
2013-04-24 00:07:14 +03:00
ikerib
d50f4880bc Currency translation 2013-04-23 23:02:03 +02:00
Romain Neutron
1de29b9a7b [Process] Do not throw LogicException in ProcessBuilder::getProcess if no arguments are set but a prefix is 2013-04-23 22:53:10 +02:00
Romain Neutron
209799b18e [Process] Use new ProcessUtils::escapeArgument to escape ProcessBuilder prefix 2013-04-23 22:48:37 +02:00
Fabien Potencier
61c56fc54a merged branch jfsimon/console-descriptor (PR #7454)
This PR was squashed before being merged into the master branch (closes #7454).

Discussion
----------

[Console] application/command as text/xml/whatever decoupling

This PR removes description generation from `Command`, `Application` and `InputDefinition` classes and delegate it to specialized descriptor classes, making it dead simple to add new output formats.

**Maybe this could include other commands, like `router:debug` or `container:debug` (see #5740)?**

- [x] Add a `DescriptorProvider` which uses `DescriptorInterface` objects to describe things.
- [x] Add `txt` descriptors.
- [x] Add `xml` descriptors.
- [x] Add `json` descriptors.
- [x] Add `md` descriptors.
- [x] Remove obsolete methods.
- [x] Repair tests.

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #6339

Commits
-------

51512e6 [Console] application/command as text/xml/whatever decoupling
2013-04-23 18:54:01 +02:00
Jean-François Simon
51512e633b [Console] application/command as text/xml/whatever decoupling 2013-04-23 18:54:00 +02:00
Fabien Potencier
bdc073430e merged branch micheleorselli/update_it_validators (PR #7817)
This PR was merged into the master branch.

Discussion
----------

[Validator] Added missing Italian translation

Commits
-------

a2e1e25 updated it translation for validators
2013-04-23 16:30:11 +02:00
Fabien Potencier
61d3be0d6d merged branch bschussek/rename-bind (PR #7736)
This PR was merged into the master branch.

Discussion
----------

[Form] Deprecated bind() and isBound() in favor of submit() and isSubmitted()

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes (*)
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | #5493
| License       | MIT
| Doc PR        | TODO

This change was discussed for a while in #5493. **(*)** It breaks BC *only for people who implemented* `FormInterface` *manually* (not a lot, so I hope). These can fix the problem by simply renaming `bind()` and `isBound()` in their implementation to `submit()` and `isSubmitted()`.

The main rationale is that with the request handlers introduced in #6522, people won't be confronted with the term "binding" anymore. As such, `isBound()` will be a very strange name to new users that have never used `bind()` manually.

See this code sample as example:

```php
$form = $this->createForm(...);
$form->handleRequest($request);

// Imagine you have never heard about bind() or binding. What does this mean?
if ($form->isBound()) {
    // ...
}
```

In reality, `bind()` submits a form. Where-ever I renamed "bind" to "submit" in the comments, "submit" made actually much more sense. So it does in the code sample above:

```php
$form = $this->createForm(...);
$form->handleRequest($request);

// Aha!
if ($form->isSubmitted()) {
    // ...
}
```

Also when using `submit()` directly, the code makes much more sense now:

```php
$text = $this->createForm('text');
$text->submit('New Value');
```

For current users, the current naming will be supported until 3.0.

Commits
-------

41b0127 [Form] Deprecated bind() and isBound() in favor of submit() and isSubmitted()
2013-04-23 16:30:03 +02:00
Michele Orselli
a2e1e25f8f updated it translation for validators 2013-04-23 15:34:10 +02:00
Fabien Potencier
81f37ba3a3 merged branch XWB/currency-translation (PR #7814)
This PR was merged into the master branch.

Discussion
----------

[Validator] Added Dutch currency translation

The previous translation was not entirely correct, sorry!

Commits
-------

dc40a29 [Validator] Added Dutch currency translation
aa795ed Revert "[Validator] Added Dutch currency translation"
2013-04-23 15:01:49 +02:00
Fabien Potencier
dc26df007f merged branch toin0u/patch-1 (PR #7815)
This PR was merged into the master branch.

Discussion
----------

[Validator] Added Danish translation for the currency validator

Commits
-------

f801f22 [Validator] Added Danish translation for the currency validator
2013-04-23 15:01:04 +02:00
Antoine Corcy
f801f22a39 [Validator] Added Danish translation for the currency validator 2013-04-23 14:59:16 +02:00
Fabien Potencier
14ae4ecfd7 merged branch bschussek/improve-name-parser (PR #7812)
This PR was merged into the master branch.

Discussion
----------

[FrameworkBundle] Improved TemplateNameParser performance

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Performance test in symfony-standard:
```php
<?php

use Symfony\Bundle\FrameworkBundle\Templating\TemplateNameParser;

require __DIR__.'/vendor/autoload.php';
require __DIR__.'/app/AppKernel.php';

$kernel = new AppKernel('dev', true);
$kernel->boot();
$parser = new TemplateNameParser($kernel);

$time = microtime(true);

for ($i = 0; $i < 50; ++$i) {
    $parser->parse("AcmeDemoBundle:Foo:bar$i.html.twig");
}

echo "Time:   " . (microtime(true) - $time)*1000 . "ms\n";
echo "Memory: " . memory_get_peak_usage(true)/(1024*1024) . "MB\n";
```

Before:
```
Time:   3.80706787109ms
Memory: 1.5MB
```

After:
```
Time:   3.13401222229ms
Memory: 1.5MB
```

Commits
-------

f092c7f [FrameworkBundle] Improved TemplateNameParser performance
2013-04-23 14:40:40 +02:00
Bernhard Schussek
f092c7f704 [FrameworkBundle] Improved TemplateNameParser performance 2013-04-23 14:20:34 +02:00
Karel Souffriau
dc40a29b74 [Validator] Added Dutch currency translation 2013-04-23 14:16:54 +02:00
Karel Souffriau
aa795edad4 Revert "[Validator] Added Dutch currency translation"
This reverts commit d26d1ba467.
2013-04-23 14:16:17 +02:00
Fabien Potencier
d474ebd7e1 merged branch XWB/currency-translation (PR #7813)
This PR was merged into the master branch.

Discussion
----------

[Validator] Added Dutch currency translation

Commits
-------

d26d1ba [Validator] Added Dutch currency translation
2013-04-23 14:04:05 +02:00