Commit Graph

53274 Commits

Author SHA1 Message Date
Nicolas Grekas
106c693c48 Merge branch '5.1' into 5.2
* 5.1:
  µCS fix
  CS fix
  CS fix
  [travis] use PHP 8.0 to patch return types and run deps=low
  Add me as a Notifier code owner
  Update sl_SI translations
  Don't trigger deprecation for deprecated aliases pointing to deprecated definitions
  [HttpFoundation] use atomic writes in MockFileSessionStorage
  Make EmailMessage & SmsMessage transport nullable
  remove unused argument
  [DI] fix param annotation
  [Config] Add \Symfony\Component\Config\Loader::load() return type
  Simplify PHP CS Fixer config
  Rename normalize param
2021-01-14 16:42:36 +01:00
Nicolas Grekas
07431bbbab Merge branch '4.4' into 5.1
* 4.4:
  µCS fix
2021-01-14 16:33:09 +01:00
Nicolas Grekas
1d7c3f6d6e µCS fix 2021-01-14 16:32:58 +01:00
Nicolas Grekas
134695cace CS fix 2021-01-14 16:32:37 +01:00
Nicolas Grekas
41a7eaa654 Merge branch '4.4' into 5.1
* 4.4:
  CS fix
  [travis] use PHP 8.0 to patch return types and run deps=low
  Update sl_SI translations
  Don't trigger deprecation for deprecated aliases pointing to deprecated definitions
  [HttpFoundation] use atomic writes in MockFileSessionStorage
  [DI] fix param annotation
  [Config] Add \Symfony\Component\Config\Loader::load() return type
  Simplify PHP CS Fixer config
  Rename normalize param
2021-01-14 16:25:38 +01:00
Nicolas Grekas
617c835b84 CS fix 2021-01-14 16:08:15 +01:00
Nicolas Grekas
9a04b00e69 minor #39823 [travis] use PHP 8.0 to patch return types and run deps=low (nicolas-grekas)
This PR was merged into the 4.4 branch.

Discussion
----------

 [travis] use PHP 8.0 to patch return types and run deps=low

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

(I need to verify that DebugClassLoader works as expected before merging)

Commits
-------

7f5ea78fb8 [travis] use PHP 8.0 to patch return types and run deps=low
2021-01-14 16:02:41 +01:00
Nicolas Grekas
0e25f405a9 bug #39821 [DependencyInjection] Don't trigger notice for deprecated aliases pointing to deprecated definitions (chalasr)
This PR was merged into the 4.4 branch.

Discussion
----------

[DependencyInjection] Don't trigger notice for deprecated aliases pointing to deprecated definitions

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Defining an alias that points to a deprecated definition should trigger a deprecation notice, but when the alias itself is deprecated, it should not trigger.

Commits
-------

38f98a1165 Don't trigger deprecation for deprecated aliases pointing to deprecated definitions
2021-01-14 16:01:47 +01:00
Nicolas Grekas
8d4dcd262a minor #39792 [Config] Add \Symfony\Component\Config\Loader::load() return type (zerkms)
This PR was merged into the 4.4 branch.

Discussion
----------

[Config] Add \Symfony\Component\Config\Loader::load() return type

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Fix https://github.com/symfony/symfony/issues/39761 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        |
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/releases):
 - Always add tests and ensure they pass.
 - Never break backward compatibility (see https://symfony.com/bc).
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too.)
 - Features and deprecations must be submitted against branch 5.x.
-->

`Symfony\Component\Config\Loader::load()` is missing return type, added it for consistency and static analysis purposes.

Commits
-------

fec66e61c8 [Config] Add \Symfony\Component\Config\Loader::load() return type
2021-01-14 16:00:21 +01:00
Nicolas Grekas
6fbfaf67b1 minor #39772 Simplify PHP CS Fixer config (keradus)
This PR was merged into the 4.4 branch.

Discussion
----------

Simplify PHP CS Fixer config

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | n/a
| License       | MIT
| Doc PR        |

same rules, just written in easier way

Commits
-------

95e33edc1c Simplify PHP CS Fixer config
2021-01-14 15:59:26 +01:00
Nicolas Grekas
9c6381c405 bug #39816 [HttpFoundation] use atomic writes in MockFileSessionStorage (nicolas-grekas)
This PR was merged into the 4.4 branch.

Discussion
----------

[HttpFoundation] use atomic writes in MockFileSessionStorage

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #39167
| License       | MIT
| Doc PR        | -

Instead of #39808

Commits
-------

5290e978bd [HttpFoundation] use atomic writes in MockFileSessionStorage
2021-01-14 15:43:10 +01:00
Nicolas Grekas
f021d6f5be minor #39822 Update sl_SI translations (petk)
This PR was merged into the 4.4 branch.

Discussion
----------

Update sl_SI translations

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #38763
| License       | MIT
| Doc PR        | N/A

Hello, this is an update for the Slovenian (sl_SI translations).

Commits
-------

b236aae766 Update sl_SI translations
2021-01-14 15:40:47 +01:00
Nicolas Grekas
7f5ea78fb8 [travis] use PHP 8.0 to patch return types and run deps=low 2021-01-14 15:31:07 +01:00
Oskar Stark
0764380f90 feature #39617 [Notifier] Add AllMySms Bridge (qdequippe)
This PR was squashed before being merged into the 5.3-dev branch.

Discussion
----------

[Notifier] Add AllMySms Bridge

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| License       | MIT
| Doc PR        | https://github.com/symfony/symfony-docs/pull/14739
| Recipe | https://github.com/symfony/recipes/pull/865

Add AllMySms bridge to Symfony Notifier

Commits
-------

4a71c36174 [Notifier] Add AllMySms Bridge
2021-01-14 14:16:46 +01:00
Quentin Dequippe
4a71c36174 [Notifier] Add AllMySms Bridge 2021-01-14 14:16:31 +01:00
Oskar Stark
9ecef3bfa1 [Notifier] [Octopush] Use the correct provider 2021-01-14 14:10:21 +01:00
Oskar Stark
f2ba2038ab feature #39702 [Notifier] Add Octopush notifier transport (aurelienheyliot)
This PR was merged into the 5.3-dev branch.

Discussion
----------

[Notifier] Add Octopush notifier transport

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | no
| New feature?  | yes <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no
| License       | MIT
| Doc PR        | symfony/symfony-docs#14779 <!-- required for new features -->
| Recipe PR| symfony/recipes#870

Commits
-------

93dde15dd2 Add Octopush notifier transport
2021-01-14 13:58:31 +01:00
Aurélien MARTIN
93dde15dd2 Add Octopush notifier transport 2021-01-14 13:58:10 +01:00
Oskar Stark
e55762dbdd feature #39568 [Notifier] Add GatewayApi bridge (Piergiuseppe Longo)
This PR was merged into the 5.3-dev branch.

Discussion
----------

[Notifier] Add GatewayApi bridge

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Replaces #38685
| License       | MIT
| Doc PR        | https://github.com/symfony/symfony-docs/pull/14463
| Recipe PR        | https://github.com/symfony/recipes/pull/864

Initial PR by @PGLongo

Commits
-------

6b9f721780 [Notifier] Add GatewayApi bridge
2021-01-14 13:48:09 +01:00
Piergiuseppe Longo
6b9f721780 [Notifier] Add GatewayApi bridge 2021-01-14 13:35:37 +01:00
Fabien Potencier
c01b032d7a minor #39824 No patch version in CHANGELOG (OskarStark)
This PR was merged into the 5.3-dev branch.

Discussion
----------

No patch version in CHANGELOG

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | ---
| License       | MIT
| Doc PR        | ---

Based on https://github.com/symfony/symfony-docs/pull/14830

cc @fabpot, feel free to close, as we discussed this already via Slack

Commits
-------

575d9b04b4 No patch version in CHANGELOG
2021-01-14 08:59:27 +01:00
Fabien Potencier
1eb849dfb4 feature #39585 [Notifier] Change Dsn api (OskarStark)
This PR was squashed before being merged into the 5.3-dev branch.

Discussion
----------

[Notifier] Change Dsn api

| Q             | A
| ------------- | ---
| Branch?       | 5.x, BC BREAK, but experimental
| Bug fix?      | yes
| New feature?  | yes
| Deprecations? | no
| Tickets       | Fix #39533
| License       | MIT
| Doc PR        | ---

This PR

* [x] adds a new `getOptions()` method, which could be helpful and also improves testability instead of dealing with reflections
* [x] makes the `__construct()` method accept only a dsn as string
* [x] removes `fromString()` method
* [x] afterwards you can always rely on `getOriginalDsn()` method, like described by its return type, before it returned null when Dsn class was instantiated via the constructor and a `TypeError` was thrown
* [x] refactored the tests

This should be done for the Mailer Dsn class too, but this class is not experimental anymore... 🤔

Commits
-------

44e8ca164f [Notifier] Change Dsn api
2021-01-14 08:54:42 +01:00
Oskar Stark
44e8ca164f [Notifier] Change Dsn api 2021-01-14 08:54:37 +01:00
Fabien Potencier
6510b047e6 minor #39825 [Notifier] Add me as a Notifier code owner (OskarStark)
This PR was merged into the 5.1 branch.

Discussion
----------

[Notifier] Add me as a Notifier code owner

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | ---
| License       | MIT
| Doc PR        | ---

To get notifications about everything which happens

Commits
-------

8c2b71d30e Add me as a Notifier code owner
2021-01-14 08:53:34 +01:00
Oskar Stark
8c2b71d30e Add me as a Notifier code owner
To get notifications about everything which happens
2021-01-14 08:41:22 +01:00
Oskar Stark
575d9b04b4 No patch version in CHANGELOG 2021-01-14 08:18:56 +01:00
Fabien Potencier
41697467bc bug #39812 Make EmailMessage & SmsMessage transport nullable (odolbeau)
This PR was merged into the 5.1 branch.

Discussion
----------

Make EmailMessage & SmsMessage transport nullable

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| License       | MIT

Ideally, this should have been done in #38361 as it's exactly the same problem: the `transport` method can be called with `null` with deserializing a message from json (for example).

Commits
-------

d98aca06d0 Make EmailMessage & SmsMessage transport nullable
2021-01-14 08:17:33 +01:00
Peter Kokot
b236aae766 Update sl_SI translations 2021-01-13 20:28:53 +01:00
Robin Chalas
38f98a1165 Don't trigger deprecation for deprecated aliases pointing to deprecated definitions 2021-01-13 18:24:13 +01:00
Nicolas Grekas
5290e978bd [HttpFoundation] use atomic writes in MockFileSessionStorage 2021-01-13 15:38:32 +01:00
Christian Flothmann
3811030f26 fix typo 2021-01-13 12:59:22 +01:00
Alexander M. Turek
db8ef3042a minor #39810 [Form] remove unused argument (xabbuh)
This PR was merged into the 5.1 branch.

Discussion
----------

[Form] remove unused argument

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

The constructor expects only three arguments.

Commits
-------

b6d9c6c2c0 remove unused argument
2021-01-13 11:43:25 +01:00
Olivier Dolbeau
d98aca06d0 Make EmailMessage & SmsMessage transport nullable 2021-01-13 11:32:36 +01:00
Christian Flothmann
b6d9c6c2c0 remove unused argument
The constructor expects only three arguments.
2021-01-13 10:37:20 +01:00
Fabien Potencier
d23b74ebce bug #39735 [Serializer] Rename normalize param (VincentLanglet)
This PR was merged into the 4.4 branch.

Discussion
----------

[Serializer] Rename normalize param

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| License       | MIT

The ProblemNormalizer is the only one Normalizer which
- Use a different param name `$exception` instead of the one in the interface `$object`.
- Doesn't type check the param.

The first point lead to an unfixable error with Psalm when extending the ProblemNormalizer
- If the variable is named `$object` it does not match with the parent
- If the variable is named `$exception` it does not match with the interface

Commits
-------

7e6eee2789 Rename normalize param
2021-01-13 08:03:18 +01:00
Robin Chalas
03b2771e2c minor #39805 [SecurityBundle] Remove dead condition (chalasr)
This PR was merged into the 5.2 branch.

Discussion
----------

[SecurityBundle] Remove dead condition

| Q             | A
| ------------- | ---
| Branch?       | 5.3
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |  -
| License       | MIT
| Doc PR        | -

SecurityUserValueResolver has been removed in 5.0.

Commits
-------

2127a9b37a [SecurityBundle] Drop dead check
2021-01-12 21:58:34 +01:00
Robin Chalas
2127a9b37a [SecurityBundle] Drop dead check 2021-01-12 21:56:41 +01:00
Wouter de Jong
f448627e6b minor #39803 [SecurityBundle] Remove invalid service definition (chalasr)
This PR was merged into the 5.2 branch.

Discussion
----------

[SecurityBundle] Remove invalid service definition

| Q             | A
| ------------- | ---
| Branch?       | 5.2
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Removes an abstract service definition that points to an undefined class: `FirewallEventBubblingListener` was part of the new authenticator system at some point, but was removed before being released.

Targets 5.2, as 5.1 will be soon EOL.

Commits
-------

15d8080296 [SecurityBundle] Remove invalid service definition
2021-01-12 20:36:30 +01:00
Nicolas Grekas
d4c70a53ca [DI] fix param annotation 2021-01-12 20:08:29 +01:00
Robin Chalas
15d8080296 [SecurityBundle] Remove invalid service definition 2021-01-12 19:31:56 +01:00
Nicolas Grekas
a60879371f Merge branch '5.2' into 5.x
* 5.2:
  [Semaphore] Dont allow unserializing classes with a destructor
2021-01-12 15:39:23 +01:00
Nicolas Grekas
c6149d3618 minor #39800 [Semaphore] Dont allow unserializing classes with a destructor (nicolas-grekas)
This PR was merged into the 5.2 branch.

Discussion
----------

[Semaphore] Dont allow unserializing classes with a destructor

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

92a2afb694 [Semaphore] Dont allow unserializing classes with a destructor
2021-01-12 15:39:08 +01:00
Nicolas Grekas
92a2afb694 [Semaphore] Dont allow unserializing classes with a destructor 2021-01-12 15:35:33 +01:00
Nicolas Grekas
a176f8767c Merge branch '5.2' into 5.x
* 5.2:
  Dont allow unserializing classes with a destructor
  Dont allow unserializing classes with a destructor - 4.4
  [Cache] fix possible collision when writing tmp file in filesystem adapter
  a colon followed by spaces exclusively separates mapping keys and values
  Contracts: Remove ellipsis
  fix handling float-like key attribute values
  Fix transient test with HttpClient jitter
  Fix missing BCC recipients in SES bridge
  Move AuthenticationSuccessEvent outside try/catch block
  Dont allow unserializing classes with a destructor - 5.2
  Dont allow unserializing classes with a destructor - 5.1
2021-01-12 15:29:08 +01:00
Nicolas Grekas
2052534540 Merge branch '5.1' into 5.2
* 5.1:
  Dont allow unserializing classes with a destructor
  Dont allow unserializing classes with a destructor - 4.4
  [Cache] fix possible collision when writing tmp file in filesystem adapter
  a colon followed by spaces exclusively separates mapping keys and values
  Contracts: Remove ellipsis
  fix handling float-like key attribute values
  Fix missing BCC recipients in SES bridge
  Dont allow unserializing classes with a destructor - 5.1
2021-01-12 15:28:55 +01:00
Nicolas Grekas
73a70acb2b Merge branch '4.4' into 5.1
* 4.4:
  Dont allow unserializing classes with a destructor
  Dont allow unserializing classes with a destructor - 4.4
  [Cache] fix possible collision when writing tmp file in filesystem adapter
  a colon followed by spaces exclusively separates mapping keys and values
  Contracts: Remove ellipsis
  fix handling float-like key attribute values
  Fix missing BCC recipients in SES bridge
2021-01-12 15:25:50 +01:00
Nicolas Grekas
e6cfa099a8 bug #39797 Dont allow unserializing classes with a destructor (jderusse)
This PR was merged into the 4.4 branch.

Discussion
----------

Dont allow unserializing classes with a destructor

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Prevent destructors with side-effects from being unserialized

Commits
-------

facc095944 Dont allow unserializing classes with a destructor
2021-01-12 15:21:03 +01:00
Jérémy Derussé
facc095944
Dont allow unserializing classes with a destructor 2021-01-12 13:42:25 +01:00
Nicolas Grekas
15e7eeefd0 minor #39760 [HttpClient] Fix transient test with HttpClient jitter (jderusse)
This PR was merged into the 5.2 branch.

Discussion
----------

[HttpClient] Fix transient test with HttpClient jitter

| Q             | A
| ------------- | ---
| Branch?       | 5.2
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | f-
| License       | MIT
| Doc PR        | -

Fix transient test, when asserting jitter generates random delay

Commits
-------

70fe66005a Fix transient test with HttpClient jitter
2021-01-12 12:36:23 +01:00
Nicolas Grekas
6eff2630a1 bug #39743 [Mailer] Fix missing BCC recipients in SES bridge (jderusse)
This PR was merged into the 4.4 branch.

Discussion
----------

[Mailer] Fix missing BCC recipients in SES bridge

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #36333
| License       | MIT
| Doc PR        | -

When using the `ses` (alias of `ses+https`) scheme, the bridge send the RawEmail to AWS.
But RawEmails does not contains the BCC recipients.

This PR adds the envelope's recipients to the list of Destinations in Amazon SES payload.

Commits
-------

1cfc763018 Fix missing BCC recipients in SES bridge
2021-01-12 12:30:25 +01:00