Commit Graph

22814 Commits

Author SHA1 Message Date
Jules Pietri
b4b5d63660 [Form] fix #15544 when a collection type attribute "required" is false, "prototype" should too 2015-12-18 17:43:43 +01:00
Fabien Potencier
8d010230ef bug #16860 [Yaml] do not remove "comments" in scalar blocks (xabbuh)
This PR was merged into the 2.3 branch.

Discussion
----------

[Yaml] do not remove "comments" in scalar blocks

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #12478, #15857
| License       | MIT
| Doc PR        |

Inside scalar blocks, lines starting with a `#` character must be
treated like every other strings and must not be ignored as comments.

Commits
-------

3c72fcc [Yaml] do not remove "comments" in scalar blocks
2015-12-18 17:24:33 +01:00
Fabien Potencier
dae4267216 bug #17002 [Console][Table] fixed render row that contains multiple cells. (aitboudad)
This PR was merged into the 2.7 branch.

Discussion
----------

[Console][Table] fixed render row that contains multiple cells.

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |  #16998
| License       | MIT
| Doc PR        | n/a

Commits
-------

3790ac7 [Console][Table] fixed render row with multiple cells.
2015-12-18 17:14:15 +01:00
Fabien Potencier
bfd522ff16 minor #16966 [Validator] Updated Bulgarian translation (RoumenDamianoff)
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #16966).

Discussion
----------

[Validator] Updated Bulgarian translation

Updated Bulgarian translation.

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

862b872 updated validators.bg.xlf
2015-12-18 17:08:10 +01:00
Roumen Damianoff
862b8722b3 updated validators.bg.xlf 2015-12-18 17:08:09 +01:00
Nicolas Grekas
85814de44c Merge branch '2.3' into 2.7
* 2.3:
  prefer phpunit 5.x on hhvm
  [FrameworkBundle][HttpKernel] the finder is required to discover bundle commands
  [travis] Auto-conf deps=high matrix line
  Fix the logout path when not using the router
  [HttpFoundation] Added the ability of mapping stream wrapper protocols when using X-Sendfile
  [HttpFoundation] Add a test case for using BinaryFileResponse with stream wrappers

Conflicts:
	.travis.yml
	src/Symfony/Bundle/FrameworkBundle/composer.json
	src/Symfony/Bundle/SecurityBundle/Templating/Helper/LogoutUrlHelper.php
2015-12-18 16:35:58 +01:00
Nicolas Grekas
f76595662c minor #17024 prefer phpunit 5.x on hhvm (eventhorizonpl)
This PR was submitted for the 3.0 branch but it was merged into the 2.3 branch instead (closes #17024).

Discussion
----------

prefer phpunit 5.x on hhvm

Hi,

HHVM is identified as PHP 5.6 compiler. There are some unsolved problems with tests on hhvm, but using a recent phpunit should be a good start point. How about using 5.1?

Best regards,
Michal

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

Commits
-------

7a06d92 prefer phpunit 5.x on hhvm
2015-12-18 16:27:37 +01:00
Michal Piotrowski
7a06d92925 prefer phpunit 5.x on hhvm 2015-12-18 16:27:37 +01:00
Nicolas Grekas
6b13708ab6 bug #16971 [HttpFoundation] Added the ability of using BinaryFileResponse with stream wrappers (jakzal, Sander-Toonen)
This PR was merged into the 2.3 branch.

Discussion
----------

[HttpFoundation] Added the ability of using BinaryFileResponse with stream wrappers

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #12990 #13187
| License       | MIT
| Doc PR        | ~

Commits
-------

1da3d61 [HttpFoundation] Added the ability of mapping stream wrapper protocols when using X-Sendfile
dd129b7 [HttpFoundation] Add a test case for using BinaryFileResponse with stream wrappers
2015-12-18 11:44:19 +01:00
Nicolas Grekas
c2b7ccb36c bug #17048 Fix the logout path when not using the router (stof)
This PR was merged into the 2.3 branch.

Discussion
----------

Fix the logout path when not using the router

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #17029
| License       | MIT
| Doc PR        | n/a

This needs to use the base url, not the base path, so that it goes through the front controller when not using url rewriting.

Commits
-------

1a2567e Fix the logout path when not using the router
2015-12-18 10:38:22 +01:00
Nicolas Grekas
6499a2c4d5 bug #17049 Fix the logout path when not using the router (stof)
This PR was merged into the 2.7 branch.

Discussion
----------

Fix the logout path when not using the router

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #17029
| License       | MIT
| Doc PR        | n/a

This needs to use the base url, not the base path, so that it goes through the front controller when not using url rewriting.

Similar to #17048, but in the new code location

Commits
-------

542b877 Fix the logout path when not using the router
2015-12-18 10:31:06 +01:00
Nicolas Grekas
e69491c819 bug #17057 [FrameworkBundle][HttpKernel] the finder is required to discover bundle commands (xabbuh)
This PR was squashed before being merged into the 2.3 branch (closes #17057).

Discussion
----------

[FrameworkBundle][HttpKernel] the finder is required to discover bundle commands

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #17038
| License       | MIT
| Doc PR        |

Commits
-------

17fcef5 [FrameworkBundle][HttpKernel] the finder is required to discover bundle commands
2015-12-18 10:21:37 +01:00
Christian Flothmann
17fcef5aff [FrameworkBundle][HttpKernel] the finder is required to discover bundle commands 2015-12-18 10:21:31 +01:00
Nicolas Grekas
1dff640f1b minor #16974 [travis] Auto-conf deps=high matrix line (nicolas-grekas)
This PR was merged into the 2.3 branch.

Discussion
----------

[travis] Auto-conf deps=high matrix line

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

eb9f98e [travis] Auto-conf deps=high matrix line
2015-12-18 09:56:03 +01:00
Nicolas Grekas
eb9f98e81f [travis] Auto-conf deps=high matrix line 2015-12-18 09:19:35 +01:00
Jakub Zalas
0a496e7011 [Security] Enable bcrypt validation and result length tests on all PHP versions 2015-12-17 18:05:04 +00:00
Jakub Zalas
5c302669eb [Security] Verify if a password encoded with bcrypt is no longer than 72 characters 2015-12-17 18:04:54 +00:00
Christophe Coevoet
542b877424 Fix the logout path when not using the router
This needs to use the base url, not the base path, so that it goes
through the front controller when not using url rewriting.
2015-12-17 14:04:43 +01:00
Christophe Coevoet
1a2567e19e Fix the logout path when not using the router
This needs to use the base url, not the base path, so that it goes
through the front controller when not using url rewriting.
2015-12-17 13:54:40 +01:00
Maxime Steinhausser
2e158df2c7 [Console] Avoid extra blank lines when rendering exceptions 2015-12-17 00:47:15 +01:00
Tobias Schultze
2d48af7745 bug #17006 [Form] Fix casting regression in DoctrineChoiceLoader (bendavies)
This PR was merged into the 2.7 branch.

Discussion
----------

[Form] Fix casting regression in DoctrineChoiceLoader

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

In symfony 2.7, the [DoctrineChoiceLoader](9543b36a34/src/Symfony/Bridge/Doctrine/Form/ChoiceList/DoctrineChoiceLoader.php) and [IdReader](9543b36a34/src/Symfony/Bridge/Doctrine/Form/ChoiceList/IdReader.php) were introduce to replace the deprecated [EntityChoiceList](9543b36a34/src/Symfony/Bridge/Doctrine/Form/ChoiceList/EntityChoiceList.php)

There appears to have been a change in behaviour in the refactor, as the old `EntityChoiceList` [casts ID to strings](9543b36a34/src/Symfony/Bridge/Doctrine/Form/ChoiceList/EntityChoiceList.php (L248)), whereas the new `DoctrineChoiceLoader` [does not](https://github.com/symfony/symfony/blob/2.7/src/Symfony/Bridge/Doctrine/Form/ChoiceList/DoctrineChoiceLoader.php#L159). The casting behavior was [maintained elsewhere](https://github.com/symfony/symfony/blob/2.7/src/Symfony/Bridge/Doctrine/Form/ChoiceList/DoctrineChoiceLoader.php#L122), however.

Since the new `DoctrineChoiceLoader` deprecated `EntityChoiceList`, i'm calling this a regression.

Commits
-------

54bbade [Form] cast IDs to match deprecated behaviour of EntityChoiceList
2015-12-15 20:21:59 +01:00
Ben Davies
54bbade3e6 [Form] cast IDs to match deprecated behaviour of EntityChoiceList 2015-12-15 11:02:11 +00:00
Tobias Schultze
88d586b447 Merge branch '2.3' into 2.7 2015-12-15 02:31:17 +01:00
Tobias Schultze
b178e6804b minor #16698 [PropertyAccessor] A little refactor (aivus)
This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #16698).

Discussion
----------

[PropertyAccessor] A little refactor

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

 - Remove obsolete code
 - Remove excessive actions
 - Fix phpdoc & comments

Commits
-------

457b3f0 [PropertyAccessor] A little refactor  - Remove obsolete code  - Remove excessive actions  - Fix phpdoc & comments
2015-12-15 02:27:15 +01:00
Ilya Antipenko
457b3f0047 [PropertyAccessor] A little refactor
- Remove obsolete code
 - Remove excessive actions
 - Fix phpdoc & comments
2015-12-15 02:27:13 +01:00
Tobias Schultze
b23c9a3b5b minor #16839 [PropertyAccess] minor: constants as internal and removed unused var (dunglas)
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #16839).

Discussion
----------

[PropertyAccess] minor: constants as internal and removed unused var

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

6c9bb86 [PropertyAccess] minor: constants as internal and removed unused var
2015-12-15 02:21:41 +01:00
Kévin Dunglas
6c9bb86b47 [PropertyAccess] minor: constants as internal and removed unused var 2015-12-15 02:21:26 +01:00
Tobias Schultze
ab188a727d minor #17011 [CONSOLE] Remove unnecessary test (krzysiekpiasecki)
This PR was submitted for the 3.0 branch but it was merged into the 2.7 branch instead (closes #17011).

Discussion
----------

[CONSOLE] Remove unnecessary test

Question interface 'quarantees'  that $validator is null or callable

Commits
-------

5dc9bd9 Remove unnecessary test
2015-12-14 19:14:10 +01:00
Krzysztof Piasecki
5dc9bd9fe3 Remove unnecessary test
Question interface guarantees, that $validator is callable or null
2015-12-14 19:14:08 +01:00
Abdellatif Ait boudad
3790ac7ba1 [Console][Table] fixed render row with multiple cells. 2015-12-14 12:15:32 +00:00
Tobias Schultze
9543b36a34 minor #16972 [2.7][Console] Table: fix some PhpDoc (ogizanagi)
This PR was merged into the 2.7 branch.

Discussion
----------

[2.7][Console] Table: fix some PhpDoc

| Q             | A
| ------------- | ---
| Fixed tickets | n/a
| License       | MIT

Commits
-------

1eaef57 [2.7][Console] Table: fix some PhpDoc
2015-12-12 21:03:44 +01:00
Sander-Toonen
1da3d616a3 [HttpFoundation] Added the ability of mapping stream wrapper protocols when using X-Sendfile 2015-12-12 19:44:35 +00:00
Tobias Schultze
c2cad23357 minor #16936 [Security] backported phpdoc from Guard component. (hhamon)
This PR was merged into the 2.3 branch.

Discussion
----------

[Security] backported phpdoc from Guard component.

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | ~
| License       | MIT
| Doc PR        | ~

Commits
-------

cab6fd5 [Security] backported phpdoc from Guard component.
2015-12-12 15:43:15 +01:00
Maxime Steinhausser
1eaef57c13 [2.7][Console] Table: fix some PhpDoc 2015-12-11 19:18:28 +01:00
Jakub Zalas
dd129b71e3 [HttpFoundation] Add a test case for using BinaryFileResponse with stream wrappers 2015-12-11 17:13:59 +00:00
Abdellatif Ait boudad
369b2d4876 [Translation][Writer] avoid calling setBackup if the dumper is not an instance of FileDumper. 2015-12-11 07:55:10 +00:00
Nicolas Grekas
c7f7a9a569 minor #16946 Clean useless deprecation silencing (nicolas-grekas)
This PR was merged into the 2.3 branch.

Discussion
----------

Clean useless deprecation silencing

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

We added these when we triggered unsilenced notices. But we silence them now.

Commits
-------

9953550 Clean useless deprecation silencing
2015-12-11 08:22:19 +01:00
Nicolas Grekas
f253d624a0 Merge branch '2.3' into 2.7
* 2.3:
  [Process] Enhance compatiblity with --enable-sigchild
  [Process] Always call proc_close
  [Validator] Updated Luxembourgish translations for 2.8
  [FrameworkBundle] prevent cache:clear creating too long paths

Conflicts:
	src/Symfony/Component/Process/Tests/ProcessTest.php
	src/Symfony/Component/Process/Tests/SigchildDisabledProcessTest.php
	src/Symfony/Component/Process/Tests/SigchildEnabledProcessTest.php
	src/Symfony/Component/Process/Tests/SimpleProcessTest.php
	src/Symfony/Component/Validator/Resources/translations/validators.lb.xlf
2015-12-10 17:58:22 +01:00
Nicolas Grekas
423f83f75e bug #16915 [Process] Enhance compatiblity with --enable-sigchild (nicolas-grekas)
This PR was merged into the 2.3 branch.

Discussion
----------

[Process] Enhance compatiblity with --enable-sigchild

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #16888
| License       | MIT
| Doc PR        | -

This is complete rewrite of the fallback `--enable-sigchild` handling in the Process class.
It removes most of the differences between this and a non-sigchild-enabled php.
Which means the test suite doesn't need anymore to be replayed 3 times (which is how I started this PR, looking for a way to test this component in less time).

I validated this with a locally compiled php, sigchild-enabled. Green.
Changes affect only this special-mode php.

Ping @romainneutron and @Seldaek (original writer of the sigchild support)

Submitted on 2.3 as bugfix, which it is to me.

Commits
-------

e7cc4aa [Process] Enhance compatiblity with --enable-sigchild
2015-12-10 17:39:45 +01:00
Nicolas Grekas
e7cc4aa715 [Process] Enhance compatiblity with --enable-sigchild 2015-12-10 16:01:44 +01:00
Nicolas Grekas
99535506e8 Clean useless deprecation silencing 2015-12-10 15:12:08 +01:00
Kévin Dunglas
23431e99d6 [FrameworkBundle] Compute the kernel root hash only one time 2015-12-10 11:46:31 +01:00
Hugo Hamon
cab6fd531e [Security] backported phpdoc from Guard component. 2015-12-10 09:14:03 +01:00
Tobias Schultze
4cde2d1e33 bug #16829 [FrameworkBundle] prevent cache:clear creating too long paths (Tobion)
This PR was merged into the 2.3 branch.

Discussion
----------

[FrameworkBundle] prevent cache:clear creating too long paths

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #15547 #16783
| License       | MIT
| Doc PR        | -

Commits
-------

6e279c5 [FrameworkBundle] prevent cache:clear creating too long paths
2015-12-10 01:42:36 +01:00
Kévin Dunglas
447ea791be bug #16921 Fix short array syntax for php 5.3 (ewgRa)
This PR was merged into the 2.7 branch.

Discussion
----------

Fix short array syntax for php 5.3

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

70afcc8 fix short array syntax for php 5.3
2015-12-09 13:35:21 +01:00
Evgeniy Sokolov
70afcc8023 fix short array syntax for php 5.3 2015-12-09 12:45:47 +01:00
Fabien Potencier
0b0070e81b bug #16450 [Serializer] Fixed array_unique on array of objects in getAllowedAttributes. (CornyPhoenix)
This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #16450).

Discussion
----------

[Serializer] Fixed `array_unique` on array of objects in `getAllowedAttributes`.

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #16445
| License       | MIT
| Doc PR        | symfony/symfony-docs#16445

Commits
-------

6110bd9 [Serializer] Fixed  on array of objects in .
2015-12-08 21:34:13 +01:00
Konstantin Simon Maria Möllers
6110bd9c60 [Serializer] Fixed on array of objects in . 2015-12-08 21:34:12 +01:00
Fabien Potencier
420da14156 bug #16757 [FrameworkBundle] [Translation] Fixed translations not written when no translations directory in update command (jeremyFreeAgent)
This PR was merged into the 2.7 branch.

Discussion
----------

[FrameworkBundle] [Translation] Fixed translations not written when no translations directory in update command

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Currently when you run the TranslationUpdateCommand and want to write the translation in the domain file without a `translations` directory the output is `[OK] Success` but the file is not created.

This PR fix the creation of the directory.

Commits
-------

8c45107 [FrameworkBundle] [Translation] Fixed translations not written when no translations directory in update command
2015-12-08 19:14:24 +01:00
Fabien Potencier
d6dd9a48dd minor #16894 Backport: [Validator] Updated Luxembourgish translations for 2.8 (mweimerskirch)
This PR was merged into the 2.3 branch.

Discussion
----------

Backport: [Validator] Updated Luxembourgish translations for 2.8

| Q             | A
| ------------- | ---
| Fixed tickets | https://github.com/symfony/symfony/pull/16847#discussion-diff-46756549
| License       | MIT

Commits
-------

f9a811b [Validator] Updated Luxembourgish translations for 2.8
2015-12-08 19:06:43 +01:00