As discussed on IRC meetings and in PR #2669 I came up with implementation.
This is option2, I think more elegant.
BC break: yes
Feature addition: no/feature move
Symfony2 test pass: yes
Symfony2 test written: yes
Todo: feedback needed
Commits
-------
af32590 [FrameworkBundle] Use only _route_params to generate redirect routes
Discussion
----------
[FrameworkBundle] Use only _route_params to generate redirect routes
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Routes in RedirectController are generated using all request attributes, which is inconvenient since I abuse request attributes to store other things (device types and such) relevant to the app. It renders the RedirectController useless since it adds unrelated query parameters to URLs it creates.
Commits
-------
c8bafcf Updated validators.sk.xlf file
Discussion
----------
[FrameworkBundle] Slovak translations updated
Bug fix: no
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: -
Todo: -
---------------------------------------------------------------------------
by stof at 2012-01-09T20:33:53Z
can you send the ids below 41 to the 2.0 branch ? Only 42-28 are new for 2.1
---------------------------------------------------------------------------
by pulzarraider at 2012-01-09T20:39:42Z
Done, see #3073.
Commits
-------
bea7a9c [Console] Fix tests on windows
Discussion
----------
[Console] Fix tests on windows
Rebased version of #3059 after merging #3066. This code isn't in 2.0 but still needs fixing.
Commits
-------
c7ab9ba [Console] Allow redefinition of application options descriptions
Discussion
----------
[Console] Allow redefinition of application options descriptions
Bug fix: no
Feature addition: yes
Backwards compatibility break: no
Symfony2 tests pass: yes
This allows you to redefine an `InputOption` as long as it keeps the same semantic (same default, same name, same alias, same modes). There are two purposes:
- Modifying the description with a more accurate one
- Making sure the option appears in your commands' help
Concrete example: I often want to provide a verbose version of commands. It's an elegant and very common pattern, but I basically can't document what is going to happen if you do `--verbose` since the base Application already defines `--verbose`. Also the `--verbose` option does not appear when you do `console <command> --help`, which means people probably won't think of using that option.
Commits
-------
8ee9161 [Security] Adding more extensive PHPDoc to UserInterface, AdvancedUserInterface and UserProviderInterface
Discussion
----------
More extensive PHPDoc for Security interfaces
Hey guys!
We've started to get into the habit of documenting interfaces and methods in the official docs. I think these things should be omitted from the documentation entirely, and replaced with a link to API docs that rock (I've started doing this already).
This PR just takes some of the details we have in the docs and pushes them back as PHPDoc. I use `@see`, `<code>` and changed a particular `@throws` to have a FQ class name since there's no `use` statement.
Thanks!
---------------------------------------------------------------------------
by weaverryan at 2012/01/07 20:24:15 -0800
Ok, updated and I think it's clearer now.
---------------------------------------------------------------------------
by fabpot at 2012/01/07 23:29:45 -0800
@weaverryan Great! I think that's a really good idea to document interfaces in the API, that makes a lot of sense.
---------------------------------------------------------------------------
by maastermedia at 2012/01/08 02:10:04 -0800
+1 Symfony API needs that atention also, yes. Thank you.
---------------------------------------------------------------------------
by lsmith77 at 2012/01/08 11:45:04 -0800
@fabpot: but then we should also add a list of interfaces to the API http://screencast.com/t/vu4Tljkri0
Commits
-------
10ecaba slovenian validators.xlf updated
Discussion
----------
Validators.sl.xlf updated
PR sent intentionally to symfony:master because of different translations set in translations.XYZ.xlf and translations.XYZ.xliff in current 2.0 branch.
Commits
-------
c9129e5 Fix Console tests on windows
Discussion
----------
Fix Console tests on windows (2.0)
Rebased #3059 on 2.0 - once this is applied I will rebase it again because some of the fixes could not be applied to 2.0.
Commits
-------
707bcc3 Updated CHANGELOG with GetSetNormalizer BC change
85bf553 GetSetMethodNormalizer uses lcfirst instead of strtolower when computing method names
01fcb1b Updated GetSetMethodNormalizerTest to expect camelCased functions instead of lowercased
Discussion
----------
[Serializer] GetSetMethodNormalizer uses `lcfirst` instead of `strtolower` (on master)
Bug fix: yes
Feature addition: no
Backwards compatibility break: yes
Symfony2 tests pass: yes
Fixes the following tickets: #2863
Rebased PR #2977 onto `master` (was on `2.0`).
---------------------------------------------------------------------------
by fabpot at 2012/01/06 10:57:23 -0800
Can you add a note in the CHANGELOG to explain the change and the potential BC break?
---------------------------------------------------------------------------
by ericclemmons at 2012/01/08 13:34:17 -0800
@fabpot Updated `CHANGELOG-2.1` since this is going onto `master`.
---------------------------------------------------------------------------
by stof at 2012/01/08 13:48:59 -0800
@ericclemmons you should rebase your branch on top of master. github says it cannot be merged as is
---------------------------------------------------------------------------
by ericclemmons at 2012/01/08 14:02:11 -0800
@stof Done. (There was another Serializer entry in the CHANGELOG that didn't exist when I made this branch.)
Commits
-------
1728493 made the assertions in the RequestTest more explicit and improved PHPDoc
Discussion
----------
made the assertions in the RequestTest more explicit and improved PHPDoc
as discussed in 4f1edb50d8 (comments)
Commits
-------
9441c46 [DependencyInjection] PhpDumper, fixes#2730
Discussion
----------
[DependencyInjection] PhpDumper, fixes#2730
Hey, this PR fixes#2730, if no parameters are set, the constructor wont get passed a ParameterBag
Bug fix: yes (#2730)
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
3rd and last try ;) this time i think its all fine
Commits
-------
3702541 Add tests
4f38b14 Remove `elseif`
a5efe6a Add info to CHANGELOG-2.1
3d20e39 [Form] Enable empty root form name
Discussion
----------
[Form] Enable empty root form name
BC Break: no
Feature addition: yes
Symfony2 tests pass: yes
Fixes the following issues: #2790
Todo: need more testing
This PR enables usage of empty string as a form name (only at root level).
---------------------------------------------------------------------------
by canni at 2011/12/21 09:44:51 -0800
@stof corrected
---------------------------------------------------------------------------
by canni at 2012/01/03 01:23:37 -0800
@Tobion corrected, thx
---------------------------------------------------------------------------
by fabpot at 2012/01/05 19:22:25 -0800
@canni: Can you add some unit tests for this new feature? Thanks.
---------------------------------------------------------------------------
by canni at 2012/01/06 03:09:39 -0800
@fabpot Will do :)
---------------------------------------------------------------------------
by canni at 2012/01/07 07:36:10 -0800
@fabpot done.
BC Break: no
Feature addition: yes
Symfony2 tests pass: yes
Fixes the following issues: #2790
Todo: need more testing
This PR enables usage of empty string as a form name (only at root level).
Commits
-------
dcee6ff [TwigBridge] Improve test coverage
Discussion
----------
[TwigBridge] Improve test coverage
related to https://github.com/fabpot/Twig/issues/580
[Travis is happy](http://travis-ci.org/#!/vicb/symfony/builds/484594) but it seems he doesn't like branch name with `/` when displaying status images.
It could have been submitted against 2.0 but there is an issue here: the bridge is tied to Twig so that would mean testing against every single Twig version shipped with 2.0 which I don't want.
I have "solved" the issue by ensuring that Twig version is at least 1.5.0 in the tests set up. This is not a perfect solution but I can not imagine something better for now.